René's URL Explorer Experiment


Title: Fix key exchange hang for outofproc transports by PaulHigin · Pull Request #11380 · PowerShell/PowerShell · GitHub

Open Graph Title: Fix key exchange hang for outofproc transports by PaulHigin · Pull Request #11380 · PowerShell/PowerShell

X Title: Fix key exchange hang for outofproc transports by PaulHigin · Pull Request #11380 · PowerShell/PowerShell

Description: PR Summary This PR fixes the remoting key exchange hang in OutOfProc transport connections, when transferring SecureString objects. Fixes issue: #259 PR Context When a SecureString object is transferred over the remoting layer, a key exchange algorithm is lazily run so that the contents of the SecureString can be encrypted. This is not strictly necessary since both WinRM and SSH remoting channels already encrypt data on the wire by default. But the key exchange must remain for compatibility reasons. The hang occurs when the target sends an encrypted SecureString object to the client for the first time. The client begins a key exchange handshake with the target so that it can handle the object. This works fine for WinRM based remote connections because the client processes session and command protocol messages on different threads. But the OutOfProc based transport implementations process client protocol messages on a single thread, and the lazily initiated key exchange results in a deadlock. The fix is to update the OutOfProc transport manager base class to detect and process command and session client protocol messages on separate threads. This is not a low risk change since it affects four remote implementations that are based on the OutOfProc transport: background jobs, PowerShellDirect, named pipes, SSH. Repro Steps: $session = New-PSSession -Host localhost Invoke-Command $session { $ss = ConvertTo-SecureString "Hello" -AsPlainText -Force } Invoke-Command $session { $ss } #Result Hang #Expected SecureString object to be returned. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary This PR fixes the remoting key exchange hang in OutOfProc transport connections, when transferring SecureString objects. Fixes issue: #259 PR Context When a SecureString object is transf...

X Description: PR Summary This PR fixes the remoting key exchange hang in OutOfProc transport connections, when transferring SecureString objects. Fixes issue: #259 PR Context When a SecureString object is transf...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11380

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ed4c8d7f-e58a-2d14-3f00-af09742759bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5D4:227A70:1B012A:24CECA:6AFD4F27
html-safe-noncefed806f0931ed55ab016071e584cb9bc3b642dc205d94f748165f73b5b39e90d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUQ0OjIyN0E3MDoxQjAxMkE6MjRDRUNBOjZBRkQ0RjI3IiwidmlzaXRvcl9pZCI6Ijg1NjgzMzExMjMwNDQ0NzA1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac643b474a5e71087886de092f7990142789f967ff72663dcfe4c758271792888c
hovercard-subject-tagpull_request:354209836
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11380/files
twitter:imagehttps://avatars.githubusercontent.com/u/14019529?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14019529?s=400&v=4
og:image:altPR Summary This PR fixes the remoting key exchange hang in OutOfProc transport connections, when transferring SecureString objects. Fixes issue: #259 PR Context When a SecureString object is transf...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11380/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11380%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11380%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11380/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11380/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11380/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Andrew (anmenaga)https://github.com/anmenaga
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
Conversation 17 https://github.com/PowerShell/PowerShell/pull/11380
Commits 6 https://github.com/PowerShell/PowerShell/pull/11380/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11380/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Fix key exchange hang for outofproc transports https://github.com/PowerShell/PowerShell/pull/11380/files#top
Show all changes 6 commits https://github.com/PowerShell/PowerShell/pull/11380/files
ca0980a Fix key exchange hang for outofproc transports by using separate proc… PaulHigin Dec 16, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/ca0980a5dacec194ec15af24ea67de78948f6df6
55ab0c1 Address CodeFactor issues PaulHigin Dec 17, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/55ab0c176e0b230c5186fe8a7f12cb4df89e63d3
3f7558e Merge remote-tracking branch 'upstream/master' into fix-outofproc-tra… PaulHigin Dec 17, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/3f7558eb92c15787a91171568bfc738838a09541
4863655 Add clarifying comment per CR. PaulHigin Dec 17, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/4863655d409dc50908c5258bc41878deb55adb68
005a7f2 Merge remote-tracking branch 'upstream/master' into fix-outofproc-tra… PaulHigin Dec 17, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/005a7f2c782a8c6ae71f984c59d7881974f6db6b
1553b85 Merge remote-tracking branch 'upstream/master' into fix-outofproc-tra… PaulHigin Dec 17, 2019 https://github.com/PowerShell/PowerShell/pull/11380/commits/1553b85ae343ed74df012ab0836cc3f744b6133b
Clear filters https://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L55
src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cshttps://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
View file https://github.com/PowerShell/PowerShell/blob/1553b85ae343ed74df012ab0836cc3f744b6133b/src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11380/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11380/files
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com/PowerShell/PowerShell/pull/11380/files#diff-7630249a2c753e1d09bbb06acc0b5bc3481f7bded608f04a90ae6d69f434c40e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.