René's URL Explorer Experiment


Title: Update setting PSModulePath to concatenate the process + machine env var by SteveL-MSFT · Pull Request #11276 · PowerShell/PowerShell · GitHub

Open Graph Title: Update setting PSModulePath to concatenate the process + machine env var by SteveL-MSFT · Pull Request #11276 · PowerShell/PowerShell

X Title: Update setting PSModulePath to concatenate the process + machine env var by SteveL-MSFT · Pull Request #11276 · PowerShell/PowerShell

Description: PR Summary The problem is that Windows treats User scope env vars as the preferred value over Machine scope env vars. So if a user has PSModulePath defined in their User scope, then the Machine scope one isn't used. In other words, the Process scope env var is the same as the User scope env var. However, Windows treats PATH differently in that it concatenates PATH from User scope with PATH from Machine scope. PSModulePath works like PATH so it should also do the same thing that Windows doesn't automatically do. You can observe this with just cmd.exe. The fix here is to start with env var inherited by Process. If it's the same as the one in User scope, it means the user hasn't modified it and it's incomplete, so we append the Machine scope one. If it's different, we just use the Process one. Also fixed an issue where PSModulePath was a single path without a path separator. PR Context Fix #11172 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary The problem is that Windows treats User scope env vars as the preferred value over Machine scope env vars. So if a user has PSModulePath defined in their User scope, then the Machine sc...

X Description: PR Summary The problem is that Windows treats User scope env vars as the preferred value over Machine scope env vars. So if a user has PSModulePath defined in their User scope, then the Machine sc...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11276

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:339478fd-52db-99f2-bd3e-13a9fffff31b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8940:2A53E5:2213CD:2E58A2:6AFD4617
html-safe-nonce22926f7521e8ebf808a9bb3d8bbef39e06e8262ca97febaa75c3550cba9dc201
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTQwOjJBNTNFNToyMjEzQ0Q6MkU1OEEyOjZBRkQ0NjE3IiwidmlzaXRvcl9pZCI6IjQ5MTAwNTk2MDE1OTM3MTQxOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac49ab01786a713f4f11694726a7ad3a1f4ed30f82307b169b833ffd5651f3ebe4
hovercard-subject-tagpull_request:349729278
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11276/files
twitter:imagehttps://avatars.githubusercontent.com/u/11859881?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11859881?s=400&v=4
og:image:altPR Summary The problem is that Windows treats User scope env vars as the preferred value over Machine scope env vars. So if a user has PSModulePath defined in their User scope, then the Machine sc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11276/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11276%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11276%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11276/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11276/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11276/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
SteveL-MSFT:psmodulepath-updatehttps://github.com/SteveL-MSFT/PowerShell/tree/psmodulepath-update
Conversation 10 https://github.com/PowerShell/PowerShell/pull/11276
Commits 5 https://github.com/PowerShell/PowerShell/pull/11276/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11276/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11276/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
Update setting PSModulePath to concatenate the process + machine env var https://github.com/PowerShell/PowerShell/pull/11276/files#top
Show all changes 5 commits https://github.com/PowerShell/PowerShell/pull/11276/files
c97a565 Update setting PSModulePath to concatenate the process + machine env var SteveL-MSFT Dec 6, 2019 https://github.com/PowerShell/PowerShell/pull/11276/commits/c97a56582f026f9c77274ba6c931a51415aefdc3
6bd6dd6 add some tracing SteveL-MSFT Dec 6, 2019 https://github.com/PowerShell/PowerShell/pull/11276/commits/6bd6dd6ff6c3999045239e59bdf08754a9ac666b
3926930 fix test to be dynamic to the system SteveL-MSFT Dec 6, 2019 https://github.com/PowerShell/PowerShell/pull/11276/commits/3926930400a878bae6b2c3b7bd57c53b25b350f6
55b8daa Update src/System.Management.Automation/engine/Modules/ModuleIntrinsi… SteveL-MSFT Dec 6, 2019 https://github.com/PowerShell/PowerShell/pull/11276/commits/55b8daaf6b9b7dcf50d693f10984c0c65b08d20d
b7c8bc3 Update src/System.Management.Automation/engine/Modules/ModuleIntrinsi… SteveL-MSFT Dec 9, 2019 https://github.com/PowerShell/PowerShell/pull/11276/commits/b7c8bc391749897dc18e828b70e53644c72f569d
Clear filters https://github.com/PowerShell/PowerShell/pull/11276/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
ModuleIntrinsics.cs https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
ModulePath.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
View file https://github.com/SteveL-MSFT/PowerShell/blob/b7c8bc391749897dc18e828b70e53644c72f569d/src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11276/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11276/files
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/engine/Module/ModulePath.Tests.ps1https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
View file https://github.com/SteveL-MSFT/PowerShell/blob/b7c8bc391749897dc18e828b70e53644c72f569d/test/powershell/engine/Module/ModulePath.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11276/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/pull/11276/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.