René's URL Explorer Experiment


Title: Fix PowerShell class definition leaking into another Runspace by daxian-dbw · Pull Request #11273 · PowerShell/PowerShell · GitHub

Open Graph Title: Fix PowerShell class definition leaking into another Runspace by daxian-dbw · Pull Request #11273 · PowerShell/PowerShell

X Title: Fix PowerShell class definition leaking into another Runspace by daxian-dbw · Pull Request #11273 · PowerShell/PowerShell

Description: PR Summary Fix #9313 The root problem is that a scope is holding on the shared default TypeResolutionState object when there is no PowerShell class defined in the parent chain of the scope, and then the TypeResolutionState object is used as a key to cache the found type. A scope should not hold on to the default TypeResolutionState object, but should always refer to the parent's TypeResolutionState object when no PowerShell class defined in itself. When a PowerShell class is defined in a scope, a new TypeResolutionState will be created for the specific scope. PR Context PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary Fix #9313 The root problem is that a scope is holding on the shared default TypeResolutionState object when there is no PowerShell class defined in the parent chain of the scope, and the...

X Description: PR Summary Fix #9313 The root problem is that a scope is holding on the shared default TypeResolutionState object when there is no PowerShell class defined in the parent chain of the scope, and the...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11273

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8b0511b6-a1de-5b9d-e2da-da36f8e17b21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA96:9FBED:257979:324048:6AFD463D
html-safe-nonce8892a2f392419de08f7a0f907c5f6a3e521fa8345e36b246797c874a8fcddb44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTk2OjlGQkVEOjI1Nzk3OTozMjQwNDg6NkFGRDQ2M0QiLCJ2aXNpdG9yX2lkIjoiNTQ2NTY2NDE2ODgwMTQyMDg2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb0500595b4ff1f57b3d03a45170c729a9af7fc66bc474021568e1b78f7fbfa84
hovercard-subject-tagpull_request:349607876
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11273/files
twitter:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
og:image:altPR Summary Fix #9313 The root problem is that a scope is holding on the shared default TypeResolutionState object when there is no PowerShell class defined in the parent chain of the scope, and the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11273/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11273%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11273%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11273/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11273/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11273/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
daxian-dbw:leakhttps://github.com/daxian-dbw/PowerShell/tree/leak
Conversation 5 https://github.com/PowerShell/PowerShell/pull/11273
Commits 1 https://github.com/PowerShell/PowerShell/pull/11273/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11273/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11273/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11273/files
Fix PowerShell class definition leaking into another Runspace https://github.com/PowerShell/PowerShell/pull/11273/files#top
Show all changes 1 commit https://github.com/PowerShell/PowerShell/pull/11273/files
48e2da1 Fix the class leak daxian-dbw Dec 5, 2019 https://github.com/PowerShell/PowerShell/pull/11273/commits/48e2da1c0fb387f2d166db54ce5b9c2d75112239
Clear filters https://github.com/PowerShell/PowerShell/pull/11273/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11273/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11273/files
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/SessionStateScope.cshttps://github.com/PowerShell/PowerShell/pull/11273/files#diff-5af9563f9c75216df68c5b0eb88ac8a46041b101e00baa93b607f5e4548f0a12
View file https://github.com/daxian-dbw/PowerShell/blob/48e2da1c0fb387f2d166db54ce5b9c2d75112239/src/System.Management.Automation/engine/SessionStateScope.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11273/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11273/files#diff-5af9563f9c75216df68c5b0eb88ac8a46041b101e00baa93b607f5e4548f0a12
https://github.com/PowerShell/PowerShell/pull/11273/files#diff-5af9563f9c75216df68c5b0eb88ac8a46041b101e00baa93b607f5e4548f0a12
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.