René's URL Explorer Experiment


Title: Allow `pwsh` to inherit `$env:PSModulePath` and enable `powershell.exe` to start correctly by SteveL-MSFT · Pull Request #11057 · PowerShell/PowerShell · GitHub

Open Graph Title: Allow `pwsh` to inherit `$env:PSModulePath` and enable `powershell.exe` to start correctly by SteveL-MSFT · Pull Request #11057 · PowerShell/PowerShell

X Title: Allow `pwsh` to inherit `$env:PSModulePath` and enable `powershell.exe` to start correctly by SteveL-MSFT · Pull Request #11057 · PowerShell/PowerShell

Description: PR Summary Since $env:PSModulePath is shared across all instances of PowerShell, PowerShell 7 needs to ensure it inherits the env var, but put its paths in front. If starting Windows PowerShell, it will special case powershell.exe and powershell_ise.exe removing PowerShell 7 specific paths creating a new environment for the new process. This is a breaking change as previously, if pwsh detects it is started from PowerShell, it will clear out $env:PSModulePath and create it from scratch. This change will preserve additions from the system or user env vars but not all have the complicated logic in Windows PowerShell. It will always add user module path, shared module path, and $PSHome module path if it's not already there on startup. PR Context Fix #9957 Fix #9921 Fix #7082 Fix #6850 Fix #10620 Implement PowerShell/PowerShell-RFC#233 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary Since $env:PSModulePath is shared across all instances of PowerShell, PowerShell 7 needs to ensure it inherits the env var, but put its paths in front. If starting Windows PowerShell, i...

X Description: PR Summary Since $env:PSModulePath is shared across all instances of PowerShell, PowerShell 7 needs to ensure it inherits the env var, but put its paths in front. If starting Windows PowerShell, i...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ae389589-4628-36d4-15d5-5976b50c74e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80DC:4F58E:5C6FA:7F2F7:6AFD3812
html-safe-nonce00c5c29bd4453966a41cbe5e76b24ba2ee5112c0175095326e82f01486246417
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MERDOjRGNThFOjVDNkZBOjdGMkY3OjZBRkQzODEyIiwidmlzaXRvcl9pZCI6IjcyMDk0MTYwNDYyNTQzMDczNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb904c527277f20cfda6ff7747ee1f453f1df9d3fa208ffc49e2c4f01490c803c
hovercard-subject-tagpull_request:340182879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11057/files
twitter:imagehttps://avatars.githubusercontent.com/u/11859881?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11859881?s=400&v=4
og:image:altPR Summary Since $env:PSModulePath is shared across all instances of PowerShell, PowerShell 7 needs to ensure it inherits the env var, but put its paths in front. If starting Windows PowerShell, i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11057/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11057%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11057%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11057/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11057/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11057/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests364 (364)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
SteveL-MSFT:psmodulepathhttps://github.com/SteveL-MSFT/PowerShell/tree/psmodulepath
Conversation 47 https://github.com/PowerShell/PowerShell/pull/11057
Commits 10 https://github.com/PowerShell/PowerShell/pull/11057/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11057/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Allow pwsh to inherit $env:PSModulePath and enable powershell.exe to start correctly https://github.com/PowerShell/PowerShell/pull/11057/files#top
Show all changes 10 commits https://github.com/PowerShell/PowerShell/pull/11057/files
ee25143 Enable Windows PowerShell to run from pwsh SteveL-MSFT Nov 13, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/ee2514302e355f6c87a03369798668238edfb25d
7f16a5f address CodeFactor issues SteveL-MSFT Nov 13, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/7f16a5fb1aa85c392bacd56f08f980e13e6e7193
e8d95c5 fix Codacy issue and fix build on non-Windows SteveL-MSFT Nov 13, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/e8d95c561ad11a92d648c1e2a2aa6bda1aa60cb8
a20e43d fix test failures SteveL-MSFT Nov 13, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/a20e43d4a21a172678fd75958330a2bb9f101cc1
8f4b896 Update test/powershell/engine/Module/ModulePath.Tests.ps1 SteveL-MSFT Nov 14, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/8f4b896b00e6c9bc6b97fef8894ff7e9b518c675
73da3ae address Rob's feedback SteveL-MSFT Nov 14, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/73da3aeaec8f0cd18b16ae1c17861003a55777e3
c0b67ed address Dongbo's feedback SteveL-MSFT Nov 15, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/c0b67edc8f001be29610570d0a18cfc844063983
35a01a5 fix cert module no longer requiring removing psmodulepath for powersh… SteveL-MSFT Nov 15, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/35a01a559084387714abd84394e617bb2b33409b
f6b0432 address Dongbo's comments SteveL-MSFT Nov 15, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/f6b043294b92a71f3b1bb06f25a39c2015a77f9f
fe951a2 Remove the unneeded `ToArray()` call daxian-dbw Nov 16, 2019 https://github.com/PowerShell/PowerShell/pull/11057/commits/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc
Clear filters https://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
ModuleIntrinsics.cs https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
NativeCommandProcessor.cs https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f4036ed1a5c3c9f35845bfd272e345992a55ee26e27bdf38446ab9c66e971aaf
TabCompletion.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11057/files#diff-393e1fa171a673ad5e5c3c1f3700ad03d32d46031ffcf72e4eaac1a7c7c46579
Import-Module.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f3da09f05a2256df4921b8dffeac44bec68ef5ebd32c130da72d921a88b54798
certificateCommon.psm1 https://github.com/PowerShell/PowerShell/pull/11057/files#diff-265e5779072358138089044545bccef52d3737766088b9990841ed7c62e6f6ec
ModulePath.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11057/files#diff-a0089152fd4635eea0a26cc28654ed773e2eab933c4da5e136ccb85c2cc3737a
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
View file https://github.com/SteveL-MSFT/PowerShell/blob/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc/src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11057/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/NativeCommandProcessor.cshttps://github.com/PowerShell/PowerShell/pull/11057/files#diff-f4036ed1a5c3c9f35845bfd272e345992a55ee26e27bdf38446ab9c66e971aaf
View file https://github.com/SteveL-MSFT/PowerShell/blob/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc/src/System.Management.Automation/engine/NativeCommandProcessor.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11057/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f4036ed1a5c3c9f35845bfd272e345992a55ee26e27bdf38446ab9c66e971aaf
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f4036ed1a5c3c9f35845bfd272e345992a55ee26e27bdf38446ab9c66e971aaf
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1https://github.com/PowerShell/PowerShell/pull/11057/files#diff-393e1fa171a673ad5e5c3c1f3700ad03d32d46031ffcf72e4eaac1a7c7c46579
View file https://github.com/SteveL-MSFT/PowerShell/blob/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11057/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-393e1fa171a673ad5e5c3c1f3700ad03d32d46031ffcf72e4eaac1a7c7c46579
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-393e1fa171a673ad5e5c3c1f3700ad03d32d46031ffcf72e4eaac1a7c7c46579
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f3da09f05a2256df4921b8dffeac44bec68ef5ebd32c130da72d921a88b54798
View file https://github.com/SteveL-MSFT/PowerShell/blob/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc/test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11057/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f3da09f05a2256df4921b8dffeac44bec68ef5ebd32c130da72d921a88b54798
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f3da09f05a2256df4921b8dffeac44bec68ef5ebd32c130da72d921a88b54798
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-f3da09f05a2256df4921b8dffeac44bec68ef5ebd32c130da72d921a88b54798
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Security/certificateCommon.psm1https://github.com/PowerShell/PowerShell/pull/11057/files#diff-265e5779072358138089044545bccef52d3737766088b9990841ed7c62e6f6ec
View file https://github.com/SteveL-MSFT/PowerShell/blob/fe951a2bc4eb2d6761dc082cb92018bcb5ea48cc/test/powershell/Modules/Microsoft.PowerShell.Security/certificateCommon.psm1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11057/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-265e5779072358138089044545bccef52d3737766088b9990841ed7c62e6f6ec
https://github.com/PowerShell/PowerShell/pull/11057/files#diff-265e5779072358138089044545bccef52d3737766088b9990841ed7c62e6f6ec
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11057/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.