Title: Use better order of evaluation in IsNull/IsNullLike by vexx32 · Pull Request #10769 · PowerShell/PowerShell · GitHub
Open Graph Title: Use better order of evaluation in IsNull/IsNullLike by vexx32 · Pull Request #10769 · PowerShell/PowerShell
X Title: Use better order of evaluation in IsNull/IsNullLike by vexx32 · Pull Request #10769 · PowerShell/PowerShell
Description: PR Summary Initial implementation of IsNullLike used a slightly less optimal order of evaluation. The expected most common cases are (in order): null, AutomationNull.Value, DBNull.Value, NullString.Value This also changes IsNull() to use obj is null instead of obj == null. PR Context See #10422 and #10704 (this PR could be made a part of either of those, but is a smaller change and easier to get in first, so that we can focus on more important outstanding issues and review comments in the other PRs) PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Open Graph Description: PR Summary Initial implementation of IsNullLike used a slightly less optimal order of evaluation. The expected most common cases are (in order): null, AutomationNull.Value, DBNull.Value, NullString...
X Description: PR Summary Initial implementation of IsNullLike used a slightly less optimal order of evaluation. The expected most common cases are (in order): null, AutomationNull.Value, DBNull.Value, NullString...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/10769
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f0f2fc4f-05a9-a756-797c-c48edf0a77f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92DA:1D8DD8:6526AB:871355:6A5B3606 |
| html-safe-nonce | f4dc0b75e7573db8fc6c1a5f0db8f49e445fc80b35d9516c179cb83e14a9d369 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkRBOjFEOEREODo2NTI2QUI6ODcxMzU1OjZBNUIzNjA2IiwidmlzaXRvcl9pZCI6IjUyMjE1MDE3OTc3NzM1NTUyMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 19011825768b5c5f0df048d2116c8c30d1650291d781448f750523181696f5a6 |
| hovercard-subject-tag | pull_request:326998143 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/10769/files |
| twitter:image | https://avatars.githubusercontent.com/u/32407840?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/32407840?s=400&v=4 |
| og:image:alt | PR Summary Initial implementation of IsNullLike used a slightly less optimal order of evaluation. The expected most common cases are (in order): null, AutomationNull.Value, DBNull.Value, NullString... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width