Title: Remove unused `SourceLength` remoting property causing formatting issues by SteveL-MSFT · Pull Request #10765 · PowerShell/PowerShell · GitHub
Open Graph Title: Remove unused `SourceLength` remoting property causing formatting issues by SteveL-MSFT · Pull Request #10765 · PowerShell/PowerShell
X Title: Remove unused `SourceLength` remoting property causing formatting issues by SteveL-MSFT · Pull Request #10765 · PowerShell/PowerShell
Description: PR Summary #8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called Length and if so then formatting simply used ToString() which is undesired in this case. This is a very specific case where it is an object that contains only a member called Length. Searching the codebase, it appears SourceLength isn't actually used, so the fix is to remove this property and the check for it. PR Context Fix #10762 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Open Graph Description: PR Summary #8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called Length and if so then formatting simpl...
X Description: PR Summary #8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called Length and if so then formatting simpl...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/10765
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:58dd4666-c599-8ac9-5c0a-fe0c322acb01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D602:6A178:1A8A24:23E884:6AFD4F30 |
| html-safe-nonce | cf324226537836973cd947f98a0029928261947487bc236944ea5045b14086fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjAyOjZBMTc4OjFBOEEyNDoyM0U4ODQ6NkFGRDRGMzAiLCJ2aXNpdG9yX2lkIjoiMTY5NjU3NzU2OTA4MTM0Nzg4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | de154833c3939714501e41091320af74cd8aae3493a9058642ca20f01ddebe21 |
| hovercard-subject-tag | pull_request:326928139 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/10765/files |
| twitter:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| og:image:alt | PR Summary #8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called Length and if so then formatting simpl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b6f01f7cb9f35f8c09949773241a3d49dd04b340 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width