René's URL Explorer Experiment


Title: Flag `default` switch statement condition clause as keyword by msftrncs · Pull Request #10487 · PowerShell/PowerShell · GitHub

Open Graph Title: Flag `default` switch statement condition clause as keyword by msftrncs · Pull Request #10487 · PowerShell/PowerShell

X Title: Flag `default` switch statement condition clause as keyword by msftrncs · Pull Request #10487 · PowerShell/PowerShell

Description: PR Summary Flag the switch statement condition clause default token as a keyword token to facilitate (PSReadLine) highlighting it as a keyword. Closes #10470. This change is to treat the default clause keyword as a full keyword token, and as such token based highlighters will see it as a keyword. PR Context Flagging the default condition clause token of the switch statement as a keyword will facilitate highlighting of the keyword to better contrast against other bareword string literal conditions. A simple (partial) example: # return simple element value (need to check for Boolean datatype, and process value accordingly) switch ($node.Name) { true { $true; continue } # return a Boolean TRUE value false { $false; continue } # return a Boolean FALSE value default { $node.Value } # return the element value } Highlighting of the default keyword in the above example makes it easier to distinguish the special condition clause from the other bareword conditions. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary Flag the switch statement condition clause default token as a keyword token to facilitate (PSReadLine) highlighting it as a keyword. Closes #10470. This change is to treat the default c...

X Description: PR Summary Flag the switch statement condition clause default token as a keyword token to facilitate (PSReadLine) highlighting it as a keyword. Closes #10470. This change is to treat the default c...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/10487

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c9a48ecd-85d7-eca2-f11e-8a5d959daa8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB29A:3A46ED:289AEB:3734AF:6AFE1A9A
html-safe-nonce7f1c5a28ec8bbeefd26ed97e26b07e6a8429eb9c5ebe1e658db7bcc4b9972019
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjlBOjNBNDZFRDoyODlBRUI6MzczNEFGOjZBRkUxQTlBIiwidmlzaXRvcl9pZCI6IjY3Mjg4MDg5NzI4NzkyMDI4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac895e89fa5e4960eae23a1c78a5c8d3f9a0674cc347fe80d4004db73154312382
hovercard-subject-tagpull_request:314343684
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/10487/files
twitter:imagehttps://avatars.githubusercontent.com/u/26179051?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26179051?s=400&v=4
og:image:altPR Summary Flag the switch statement condition clause default token as a keyword token to facilitate (PSReadLine) highlighting it as a keyword. Closes #10470. This change is to treat the default c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned0525ab1464526bf4532a5551aa348cf100dff75ef808a96fc67a08b1d946aa9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef3993a71fa20f7be8e167132fbf9619bc66e12
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/10487/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F10487%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F10487%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/10487/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/10487/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/10487/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
msftrncs:SwitchDefaultAsKeywordhttps://github.com/msftrncs/PowerShell/tree/SwitchDefaultAsKeyword
Conversation 38 https://github.com/PowerShell/PowerShell/pull/10487
Commits 4 https://github.com/PowerShell/PowerShell/pull/10487/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/10487/checks
Files changed https://github.com/PowerShell/PowerShell/pull/10487/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/10487/files
Flag default switch statement condition clause as keyword https://github.com/PowerShell/PowerShell/pull/10487/files#top
Show all changes 4 commits https://github.com/PowerShell/PowerShell/pull/10487/files
5d0cac4 Add `Default` TokenKind msftrncs Oct 3, 2019 https://github.com/PowerShell/PowerShell/pull/10487/commits/5d0cac4cf36510d40f67b6891be1670b9d8d2810
7a9aa2c Correct test for change of Default keyword. msftrncs Oct 1, 2019 https://github.com/PowerShell/PowerShell/pull/10487/commits/7a9aa2c728a9fcee966ebabd742b6b8580dc442a
e7f6c17 Add tests for parsing 'limited' keywords. msftrncs Oct 3, 2019 https://github.com/PowerShell/PowerShell/pull/10487/commits/e7f6c17bf2f0361b2989c0b88158323b83671ec7
8a46649 Keep backward compatibility daxian-dbw Jun 9, 2020 https://github.com/PowerShell/PowerShell/pull/10487/commits/8a4664962fd645e6c01434f1fd0f4bbd2f3dc27c
Clear filters https://github.com/PowerShell/PowerShell/pull/10487/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/10487/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/10487/files
Parser.cs https://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
token.cs https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
tokenizer.cs https://github.com/PowerShell/PowerShell/pull/10487/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
Parsing.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/10487/files#diff-839a9048cb6a280aed2176533cc3fb05a07f9f8ba1b93a7866df68f6139e3c9b
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L49
src/System.Management.Automation/engine/parser/Parser.cshttps://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
View file https://github.com/msftrncs/PowerShell/blob/8a4664962fd645e6c01434f1fd0f4bbd2f3dc27c/src/System.Management.Automation/engine/parser/Parser.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/10487/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/10487/files
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-341c1ed732e70ecccf60b626fc0955a96a786e844c067c12fb782139a2358085
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L49
src/System.Management.Automation/engine/parser/token.cshttps://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
View file https://github.com/msftrncs/PowerShell/blob/8a4664962fd645e6c01434f1fd0f4bbd2f3dc27c/src/System.Management.Automation/engine/parser/token.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/10487/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-862f23aaf51d467e076149ecfe6d6529fbab2ebba8513b977b4c77ac00e41965
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L49
src/System.Management.Automation/engine/parser/tokenizer.cshttps://github.com/PowerShell/PowerShell/pull/10487/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
View file https://github.com/msftrncs/PowerShell/blob/8a4664962fd645e6c01434f1fd0f4bbd2f3dc27c/src/System.Management.Automation/engine/parser/tokenizer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/10487/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Language/Parser/Parsing.Tests.ps1https://github.com/PowerShell/PowerShell/pull/10487/files#diff-839a9048cb6a280aed2176533cc3fb05a07f9f8ba1b93a7866df68f6139e3c9b
View file https://github.com/msftrncs/PowerShell/blob/8a4664962fd645e6c01434f1fd0f4bbd2f3dc27c/test/powershell/Language/Parser/Parsing.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/10487/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/10487/files#diff-839a9048cb6a280aed2176533cc3fb05a07f9f8ba1b93a7866df68f6139e3c9b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.