René's URL Explorer Experiment


Title: Generated get/set methods incorrectly marked non-virtual · Issue #8302 · PowerShell/PowerShell · GitHub

Open Graph Title: Generated get/set methods incorrectly marked non-virtual · Issue #8302 · PowerShell/PowerShell

X Title: Generated get/set methods incorrectly marked non-virtual · Issue #8302 · PowerShell/PowerShell

Description: While testing an experimental feature to add support for interface declarations, I found that types generated using the class keyword can't correctly override get/set methods associated with properties. Steps to reproduce Add-Type @' nam...

Open Graph Description: While testing an experimental feature to add support for interface declarations, I found that types generated using the class keyword can't correctly override get/set methods associated with proper...

X Description: While testing an experimental feature to add support for interface declarations, I found that types generated using the class keyword can't correctly override get/set methods associated with pr...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/8302

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Generated get/set methods incorrectly marked non-virtual","articleBody":"While testing an experimental feature to [add support for interface declarations](https://github.com/PowerShell/PowerShell/issues/2223#issuecomment-439602845), I found that types generated using the `class` keyword can't correctly override get/set methods associated with properties.\r\n\r\n# Steps to reproduce\r\n\r\n```powershell\r\nAdd-Type @'\r\nnamespace TypeTest {\r\n  public interface Interface {\r\n    string S { get; set; }\r\n  }\r\n}\r\n'@\r\n\r\n# Execute this as a separate statement to ensure TypeTest.Interface is defined before the class definition is\r\nclass TestClass : TypeTest.Interface {\r\n  [string]$S\r\n}\r\n\r\n```\r\n\r\n# Expected behavior\r\n\r\nNew type `[TestClass]` implementing `[TypeTest.Interface]` should have been compiled and loaded.\r\n\r\n# Actual behavior\r\n\r\n```none\r\nAt line:1 char:1\r\n+ class TestClass : TypeTest.Interface {\r\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nError during creation of type \"TestClass\". Error message:\r\nMethod 'get_S' in type 'TestClass' from assembly 'Powershell Class Assembly, Version=1.0.0.1, Culture=neutral, PublicKeyToken=null' does not have an implementation.\r\n    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException\r\n    + FullyQualifiedErrorId : TypeCreationError\r\n```\r\n\r\n# Solution\r\n\r\nAfter comparing the CIL emitted by the C# compiler when implicitly implementing an interface property, I found that the get/set methods generated by the compiler are marked `virtual`.\r\n\r\nThe fix is to either attempt to discover properties with matching signatures in associated instances and mark the backing get/set methods `virtual`, or simply just mark *all* get/set methods `virtual` (might incur slight overhead in method resolution at runtime rather than at compile time)\r\n\r\n# Environment data\r\n\r\n\u003c!-- provide the output of $PSVersionTable -->\r\n\r\n```none\r\n\r\nName                           Value\r\n----                           -----\r\nPSVersion                      6.2.0-preview.1\r\nPSEdition                      Core\r\nGitCommitId                    6.2.0-preview.1-79-g16569b157a430cc5d4a2e7bf189dcfef64beb31f\r\nOS                             Microsoft Windows 10.0.17134 \r\nPlatform                       Win32NT\r\nPSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}\r\nPSRemotingProtocolVersion      2.3\r\nSerializationVersion           1.1.0.1\r\nWSManStackVersion              3.0\r\n```\r\n","author":{"url":"https://github.com/IISResetMe","@type":"Person","name":"IISResetMe"},"datePublished":"2018-11-17T15:53:23Z","url":"https://github.com/PowerShell/PowerShell/issues/8302"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7947f7b5-f91a-5627-9503-9d0ecde8a14e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id854C:3E0E71:70A885:9E6476:6AFDC0BD
html-safe-noncef03c057a1d942a6344c7cfb728364a238d9c49448cc0e9bb41603ac5c2c65031
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTRDOjNFMEU3MTo3MEE4ODU6OUU2NDc2OjZBRkRDMEJEIiwidmlzaXRvcl9pZCI6IjgzOTgwNjcxNDc1NzM0MTIwMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac34df8db9b43bce40c9dc0798d290f12dd38191d375cd5cc925c71ac782d5b8d6
hovercard-subject-tagissue:381874938
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/8302/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7d6b08414d49663d68eba731a32ced5583ca2527d4e93cd98840aa1b94361380/PowerShell/PowerShell/issues/8302
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d6b08414d49663d68eba731a32ced5583ca2527d4e93cd98840aa1b94361380/PowerShell/PowerShell/issues/8302
og:image:altWhile testing an experimental feature to add support for interface declarations, I found that types generated using the class keyword can't correctly override get/set methods associated with proper...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIISResetMe
hostnamegithub.com
expected-hostnamegithub.com
None35c6bf57da1370dc64866160540c0ee9f825f291935b3bf6ec5492b00e35f3a6
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseab48c73a2978548773f5f24717ed9e58508befdb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/8302#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F8302
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F8302
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/8302
Reloadhttps://github.com/PowerShell/PowerShell/issues/8302
Reloadhttps://github.com/PowerShell/PowerShell/issues/8302
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8302
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8302
#8303https://github.com/PowerShell/PowerShell/pull/8303
Generated get/set methods incorrectly marked non-virtualhttps://github.com/PowerShell/PowerShell/issues/8302#top
#8303https://github.com/PowerShell/PowerShell/pull/8303
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
Resolution-FixedThe issue is fixed.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-Fixed%22
WG-Enginecore PowerShell engine, interpreter, and runtimehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine%22
https://github.com/IISResetMe
Mathias R. Jessen (IISResetMe)https://github.com/IISResetMe
on Nov 17, 2018https://github.com/PowerShell/PowerShell/issues/8302#issue-381874938
add support for interface declarationshttps://github.com/PowerShell/PowerShell/issues/2223#issuecomment-439602845
Ilya (iSazonov)https://github.com/iSazonov
WG-Enginecore PowerShell engine, interpreter, and runtimehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine%22
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
on Nov 18, 2018https://github.com/PowerShell/PowerShell/issues/8302#event-1973199650
Ilya (iSazonov)https://github.com/iSazonov
completedhttps://github.com/PowerShell/PowerShell/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#8303https://github.com/PowerShell/PowerShell/pull/8303
on Nov 30, 2018https://github.com/PowerShell/PowerShell/issues/8302#event-1997741913
Ilya (iSazonov)https://github.com/iSazonov
Resolution-FixedThe issue is fixed.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-Fixed%22
on Apr 2, 2019https://github.com/PowerShell/PowerShell/issues/8302#event-2245434167
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/8302
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8302
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
Resolution-FixedThe issue is fixed.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-Fixed%22
WG-Enginecore PowerShell engine, interpreter, and runtimehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.