René's URL Explorer Experiment


Title: ModuleSpecification/FullyQualifiedName usage does not handle paths well · Issue #8261 · PowerShell/PowerShell · GitHub

Open Graph Title: ModuleSpecification/FullyQualifiedName usage does not handle paths well · Issue #8261 · PowerShell/PowerShell

X Title: ModuleSpecification/FullyQualifiedName usage does not handle paths well · Issue #8261 · PowerShell/PowerShell

Description: Opened out of #8218. We do very little santisation/normalisation on paths passed in as module names in ModuleSpecification types to various cmdlets. Not many users rely directly on this functionality, but things like RequiredModules in m...

Open Graph Description: Opened out of #8218. We do very little santisation/normalisation on paths passed in as module names in ModuleSpecification types to various cmdlets. Not many users rely directly on this functionali...

X Description: Opened out of #8218. We do very little santisation/normalisation on paths passed in as module names in ModuleSpecification types to various cmdlets. Not many users rely directly on this functionali...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/8261

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ModuleSpecification/FullyQualifiedName usage does not handle paths well","articleBody":"Opened out of https://github.com/PowerShell/PowerShell/pull/8218.\r\n\r\nWe do very little santisation/normalisation on paths passed in as module names in `ModuleSpecification` types to various cmdlets.\r\n\r\nNot many users rely directly on this functionality, but things like `RequiredModules` in module manifests do.\r\n\r\nWe currently don't have any layering or type API (that I know of) to reflect that a path passed in has been converted by PowerShell to one that's safe for .NET to operate on, and the ideal scenario would be for us to change that. Otherwise we are doomed to repeat the same path checks/resolutions at every layer in the code, either hurting perf or causing serious bugs.\r\n\r\n## Steps to reproduce\r\n\r\nSome examples of this problem:\r\n- Remove module using a path in a qualified name doesn't work:\r\n    ```powershell\r\n       Describe \"Remove-Module works with FullyQualifiedName using a path for the name\" {\r\n        BeforeAll {\r\n            $moduleName = 'rmomod'\r\n            $moduleVersion = '1.2'\r\n            $modulePath = Join-Path $TestDrive $moduleName\r\n            $manifestPath = Join-Path $modulePath \"$moduleName.psd1\"\r\n    \r\n            New-Item -ItemType Directory -Path $modulePath\r\n    \r\n            New-ModuleManifest -Path $manifestPath -ModuleVersion $moduleVersion\r\n    \r\n            if ($IsWindows)\r\n            {\r\n                $sep = '\\'\r\n                $altSep = '/'\r\n            }\r\n            else\r\n            { \r\n                $sep = '/'\r\n                $altSep = '\\'\r\n            }\r\n    \r\n            $absoluteTestCases = @(\r\n                @{ ModuleName = $moduleName; Case = 'module name' }\r\n                @{ ModuleName = $modulePath; Case = 'absolute module dir path' }\r\n                @{ ModuleName = \"$TestDrive${altSep}$moduleName\"; Case = 'absolute module dir path with alt dir separators' }\r\n                @{ ModuleName = $manifestPath; Case = 'absolute manifest path' }\r\n                @{ ModuleName = \"$TestDrive${altSep}$moduleName${sep}$moduleName.psd1\"; Case = 'absolute manifest path with alt dir separators' }\r\n            )\r\n\r\n            $relativeTestCases = @(\r\n                @{ Case = 'relative path to module dir'; Location = $TestDrive; ModuleName = \"./$moduleName\" }\r\n                @{ Case = 'relative path to module dir with alt sep'; Location = \"$TestDrive/duck\"; ModuleName = \"..${altSep}moduleName\" }\r\n                @{ Case = 'relative path to manifest with alt sep'; Location = \"$TestDrive/$moduleName\"; ModuleName = \"./$moduleName.psd1\" }\r\n                @{ Case = 'relative path to manifest with alt sep'; Location = $TestDrive; ModuleName = \".${sep}$moduleName{$altSep}$moduleName.psd1\" }\r\n                @{ Case = 'current dir being module dir'; Location = \"$TestDrive/$moduleName\"; ModuleName = \".\" }\r\n            )\r\n        }\r\n    \r\n        BeforeEach {\r\n            Import-Module $modulePath\r\n        }\r\n    \r\n        AfterEach {\r\n            Remove-Module $moduleName -ErrorAction SilentlyContinue\r\n        }\r\n    \r\n        It \"Removes the module by \u003cCase>\" -TestCases $absoluteTestCases {\r\n            param([string]$ModuleName, [string]$Case)\r\n    \r\n            $fqn = @{\r\n                ModuleName = $ModuleName\r\n                ModuleVersion = $moduleVersion\r\n            }\r\n    \r\n            Remove-Module -FullyQualifiedName $fqn -ErrorAction Stop\r\n            Get-Module $moduleName | Should -HaveCount 0\r\n        }\r\n\r\n        It \"Removes the module by \u003cCase>\" -TestCases $relativeTestCases {\r\n            param([string]$Location, [string]$ModuleName, [string]$Case)\r\n\r\n            $fqn = @{\r\n                ModuleName = $ModuleName\r\n                ModuleVersion = $moduleVersion\r\n            }\r\n\r\n            if (-not (Test-Path $Location))\r\n            {\r\n                New-Item -ItemType Directory -Path $Location\r\n            }\r\n\r\n            Push-Location $Location\r\n            try\r\n            {\r\n                Remove-Module -FullyQualifiedName $fqn -ErrorAction Stop\r\n                Get-Module $moduleName | Should -HaveCount 0\r\n            }\r\n            finally\r\n            {\r\n                Pop-Location\r\n            }\r\n        }\r\n    }\r\n    ```\r\n- Required modules in a script:\r\n    ```powershell\r\n    Describe \"Requiring modules by absolute path\" {\r\n        BeforeAll {\r\n            $scriptPath = Join-Path $TestDrive \"script.ps1\"\r\n            $success = 'SUCCESS'\r\n\r\n            $moduleName = 'reqmod'\r\n            $modulePath = Join-Path $TestDrive $moduleName\r\n            $manifestPath = Join-Path $modulePath \"$moduleName.psd1\"\r\n\r\n            New-Item -ItemType Directory $modulePath -Force\r\n\r\n            New-ModuleManifest -Path $manifestPath -ModuleVersion '3.2.4'\r\n\r\n            if ($IsWindows)\r\n            {\r\n                $sep = '\\'\r\n                $altSep = '/'\r\n            }\r\n            else\r\n            {\r\n                $sep = '/'\r\n                $altSep = '\\'\r\n            }\r\n\r\n            $oldModulePath = $env:PSModulePath\r\n            $env:PSModulePath += [System.IO.Path]::PathSeparator + $TestDrive\r\n\r\n            $testCases = @(\r\n                @{ Case = 'module name, with module on path'; ModuleName = $moduleName }\r\n                @{ Case = 'absolute path to module dir'; ModuleName = $modulePath }\r\n                @{ Case = 'absolute path to module dir with alt sep'; ModuleName = \"$TestDrive${altSep}$moduleName\" }\r\n                @{ Case = 'absolute path to manifest'; ModuleName = $manifestPath }\r\n                @{ Case = 'absolute path to manifest with alt sep'; ModuleName = \"$TestDrive${sep}$moduleName${altSep}$moduleName.psd1\" }\r\n            )\r\n        }\r\n\r\n        AfterAll {\r\n            $env:PSModulePath = $oldModulePath\r\n        }\r\n\r\n        Context \"Autoload unloaded required module\" {\r\n            AfterEach {\r\n                Remove-Module $moduleName -ErrorAction SilentlyContinue\r\n            }\r\n\r\n            It \"Autoloads the required module by \u003cCase>\" -TestCases $testCases {\r\n                param([string]$ModuleName, [string]$Case)\r\n\r\n                $script = @\"\r\n    #requires -Modules @{ ModuleName = '$ModuleName'; ModuleVersion = '$moduleVersion' }\r\n    '$success'\r\n    \"@\r\n\r\n                New-Item -Path $scriptPath -Value $script -Force\r\n                & $scriptPath | Should -BeExactly $success\r\n            }\r\n        }\r\n\r\n        Context \"Verify required module is already loaded\" {\r\n            BeforeAll {\r\n                Import-Module $modulePath\r\n            }\r\n\r\n            AfterAll {\r\n                Remove-Module $moduleName -ErrorAction SilentlyContinue\r\n            }\r\n\r\n            It \"Verifies that the required module is loaded by \u003cCase>\" -TestCases $testCases {\r\n                param([string]$ModuleName, [string]$Case)\r\n\r\n                $script = @\"\r\n    #requires -Modules @{ ModuleName = '$ModuleName'; ModuleVersion = '$moduleVersion' }\r\n    '$success'\r\n    \"@\r\n\r\n                New-Item -Path $scriptPath -Value $script -Force\r\n                & $scriptPath | Should -BeExactly $success\r\n            }\r\n        }\r\n    }\r\n    ```\r\n    (This second case actually supports alt separators, which I didn't expect. But still no module dir. And no relative paths either)","author":{"url":"https://github.com/rjmholt","@type":"Person","name":"rjmholt"},"datePublished":"2018-11-13T23:52:45Z","url":"https://github.com/PowerShell/PowerShell/issues/8261"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b107a29d-6227-ec52-2f97-0cd8e97554e6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD89E:9905:8D220:C728D:6AFD4A1A
html-safe-noncef2e3b74d899b98600622d66fa91e314a4b2c1c30b32d20914a9c5cfc7dbc4af8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODlFOjk5MDU6OEQyMjA6QzcyOEQ6NkFGRDRBMUEiLCJ2aXNpdG9yX2lkIjoiODcwNTcxNjQ4MzkxNDU0OTc4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac49fdb129f899ac3c34f0ec0c16ae5b224fb0ae61a5a8a37920cae910bf407da8
hovercard-subject-tagissue:380475831
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/8261/issue_layout
twitter:imagehttps://opengraph.githubassets.com/652a6fb50064425d492ff3c7f06fee166591153f9fa80dad771bc72b64d973e0/PowerShell/PowerShell/issues/8261
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/652a6fb50064425d492ff3c7f06fee166591153f9fa80dad771bc72b64d973e0/PowerShell/PowerShell/issues/8261
og:image:altOpened out of #8218. We do very little santisation/normalisation on paths passed in as module names in ModuleSpecification types to various cmdlets. Not many users rely directly on this functionali...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerjmholt
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/8261#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F8261
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F8261
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/8261
Reloadhttps://github.com/PowerShell/PowerShell/issues/8261
Reloadhttps://github.com/PowerShell/PowerShell/issues/8261
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8261
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8261
ModuleSpecification/FullyQualifiedName usage does not handle paths wellhttps://github.com/PowerShell/PowerShell/issues/8261#top
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
on Nov 13, 2018https://github.com/PowerShell/PowerShell/issues/8261#issue-380475831
#8218https://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
Area-Cmdlets-Corehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Area-Cmdlets-Core%22
on Nov 13, 2018https://github.com/PowerShell/PowerShell/issues/8261#event-1964552178
Ilya (iSazonov)https://github.com/iSazonov
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
on Nov 14, 2018https://github.com/PowerShell/PowerShell/issues/8261#event-1965627200
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
on Nov 14, 2018https://github.com/PowerShell/PowerShell/issues/8261#issuecomment-438791778
Dongbo Wang (@daxian-dbw)https://github.com/daxian-dbw
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/8261#issuecomment-1813883008
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/8261#issuecomment-1813883012
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/8261#event-10976473628
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 23, 2023https://github.com/PowerShell/PowerShell/issues/8261#issuecomment-1824378665
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
completedhttps://github.com/PowerShell/PowerShell/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 23, 2023https://github.com/PowerShell/PowerShell/issues/8261#event-11047345843
Ryan Yates (kilasuit)https://github.com/kilasuit
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
WG-Cmdlets-Corehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets-Core%22
on Jul 17, 2026https://github.com/PowerShell/PowerShell/issues/8261#event-28145159452
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/8261
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/8261
Issue-Enhancementthe issue is more of a feature request than a bughttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Enhancement%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.