René's URL Explorer Experiment


Title: Properly disable (if/def out) all code related to session connection/disconnection for Unix builds · Issue #7008 · PowerShell/PowerShell · GitHub

Open Graph Title: Properly disable (if/def out) all code related to session connection/disconnection for Unix builds · Issue #7008 · PowerShell/PowerShell

X Title: Properly disable (if/def out) all code related to session connection/disconnection for Unix builds · Issue #7008 · PowerShell/PowerShell

Description: This issue is opened based on the comment in PR #6939. Class QueryRunspaces and enum SessionFilterState from ConnectPSSession.cs QueryRunspaces is only used for session disconnect, which is only supported on Windows. PSRemotingCmdlets.cs...

Open Graph Description: This issue is opened based on the comment in PR #6939. Class QueryRunspaces and enum SessionFilterState from ConnectPSSession.cs QueryRunspaces is only used for session disconnect, which is only su...

X Description: This issue is opened based on the comment in PR #6939. Class QueryRunspaces and enum SessionFilterState from ConnectPSSession.cs QueryRunspaces is only used for session disconnect, which is only su...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/7008

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Properly disable (if/def out) all code related to session connection/disconnection for Unix builds","articleBody":"This issue is opened based on the [comment](https://github.com/PowerShell/PowerShell/pull/6939#issuecomment-394880053) in PR #6939.\r\n\r\n\u003e Class QueryRunspaces and enum SessionFilterState from ConnectPSSession.cs\r\n\u003e\r\n\u003e QueryRunspaces is only used for session disconnect, which is only supported on Windows. PSRemotingCmdlets.cs is a heavily loaded file to support many remoting cmdlet base classes. Moving QueryRunspaces there just makes it more bloated and confusing in my opinion.\r\nI feel that QueryRunspaces should be put into a separate utils file that can be skipped for Linux.\r\nYou should also #ifdef out its use in the Get-PSSession parameter set since it is not supported on Linux.\r\n\r\nThe type `QueryRunspaces` is only for session connection/disconnection. It's used in `Connect-PSSession`/`Receive-PSSession`/`Get-PSSession` and it's also directly used by the abstract class `PSRunspaceCmdlet` from `PSRemotingCmdlet.cs`. Now `Connect-PSSession` and `Receive-PSSession` are disabled in Unix build, but `QueryRunspaces` is still used in `Get-PSSession` (in `getrunspacecommand.cs`) and `PSRunspaceCmdlet` (in `PSRemotingCmdlet.cs`), even though the connenction/disconnection feature is not available on Unix platforms.\r\n\r\nSo, we need to properly disable all code realted to session connection/disconnection for Unix build, and then, as @PaulHigin suggested in the comment, `QueryRunspaces` and `SessionFilterState` probably should be moved a separate file that can be skipped for Unix build compilation.\r\n","author":{"url":"https://github.com/daxian-dbw","@type":"Person","name":"daxian-dbw"},"datePublished":"2018-06-05T23:53:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/7008/PowerShell/issues/7008"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:930d6192-3fb8-f628-e331-76e0ee103168
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD05A:1C4230:1187:1686:6A52B351
html-safe-nonce6cbd8b6f336ef0ce3b551410a070eb4831e82fd87e0fcfae6be32865f051183b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDVBOjFDNDIzMDoxMTg3OjE2ODY6NkE1MkIzNTEiLCJ2aXNpdG9yX2lkIjoiNjExODcxODE5ODE2NDY2NTE2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8e0ffbb0c447504bba8632a910fcf3c556f0c02766019c21d09c9a3010fdcc29
hovercard-subject-tagissue:329664195
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/7008/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d1d6fa3766c0f7b6679cd502435462fdebdc0ce3e3a4aca3fa50a0a57c13ef0d/PowerShell/PowerShell/issues/7008
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d1d6fa3766c0f7b6679cd502435462fdebdc0ce3e3a4aca3fa50a0a57c13ef0d/PowerShell/PowerShell/issues/7008
og:image:altThis issue is opened based on the comment in PR #6939. Class QueryRunspaces and enum SessionFilterState from ConnectPSSession.cs QueryRunspaces is only used for session disconnect, which is only su...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedaxian-dbw
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/7008#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F7008
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F7008
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/7008
Reloadhttps://github.com/PowerShell/PowerShell/issues/7008
Reloadhttps://github.com/PowerShell/PowerShell/issues/7008
Please reload this pagehttps://github.com/PowerShell/PowerShell/issues/7008
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.3k https://github.com/PowerShell/PowerShell/issues
Pull requests 288 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Properly disable (if/def out) all code related to session connection/disconnection for Unix buildshttps://github.com/PowerShell/PowerShell/issues/7008#top
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Code%20Cleanup%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Maintainers-Buildspecific to affecting the buildhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Maintainers-Build%22
https://github.com/daxian-dbw
daxian-dbwhttps://github.com/daxian-dbw
on Jun 5, 2018https://github.com/PowerShell/PowerShell/issues/7008#issue-329664195
commenthttps://github.com/PowerShell/PowerShell/pull/6939#issuecomment-394880053
#6939https://github.com/PowerShell/PowerShell/pull/6939
@PaulHiginhttps://github.com/PaulHigin
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Code%20Cleanup%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Maintainers-Buildspecific to affecting the buildhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Maintainers-Build%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.