René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Integrate upstream .NET patches for Console.ReadKey","articleBody":"While I'd hoped this would be easy, I must track it because I am blocked (again) on dotnet/cli#1043.\n\nThis will resolve #571, #461, and #484. The patches were merged in dotnet/corefx#6488, and I've posted manually built patched assemblies to the #porting channel on Slack.\n\nThe `ReadKey` changes are likely to be incompatible with @palladia's changes in #613 to support intercepting `Ctrl-C`.\n\n\u003e Lifetime of terminal attribute settings. Previously we were setting up the terminal's attributes (e.g. disabling echo) the first time the console was used, and leaving those settings for the duration of the process. This has the very bad effect of leaving such settings on the terminal while other code using that terminal runs. For example, if you launch a process with Process.Start and that process expects input, echo will still be disabled, and you won't be able to see the input. This commit changes how we do these attributes. Instead of setting them and leaving them, we only set them while a read operation is in progress, reverting the settings immediately after. (**This does mean that typing prior to a call to Console.ReadKey(intecept: true) will yield visible text**, an unfortunate tradeoff, but it seems to be the better of the options.)\n\n(Emphasis mine. This trade-off is the only solution we have to a myriad of other problems.)\n\nI believe this means that characters typed while `ReadKey` is not blocking will not get captured. However, the only way to know for sure is extensive testing.\n","author":{"url":"https://github.com/andyleejordan","@type":"Person","name":"andyleejordan"},"datePublished":"2016-03-03T17:27:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/617/PowerShell/issues/617"}