Title: Parameters not fully parsed when IDynamicParameters.GetDynamicParameters() is called by tab completion · Issue #5326 · PowerShell/PowerShell · GitHub
Open Graph Title: Parameters not fully parsed when IDynamicParameters.GetDynamicParameters() is called by tab completion · Issue #5326 · PowerShell/PowerShell
X Title: Parameters not fully parsed when IDynamicParameters.GetDynamicParameters() is called by tab completion · Issue #5326 · PowerShell/PowerShell
Description: When IDynamicParameters.GetDynamicParameters() gets called via tab completion, the parameters of the cmdlet are not fully parsed, i.e. if a user specifies e.g. Parameter1via commandline as -Parameter1 'myparameter' using either single or...
Open Graph Description: When IDynamicParameters.GetDynamicParameters() gets called via tab completion, the parameters of the cmdlet are not fully parsed, i.e. if a user specifies e.g. Parameter1via commandline as -Paramet...
X Description: When IDynamicParameters.GetDynamicParameters() gets called via tab completion, the parameters of the cmdlet are not fully parsed, i.e. if a user specifies e.g. Parameter1via commandline as -Paramet...
Opengraph URL: https://github.com/PowerShell/PowerShell/issues/5326
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Parameters not fully parsed when IDynamicParameters.GetDynamicParameters() is called by tab completion","articleBody":"When `IDynamicParameters.GetDynamicParameters()` gets called via tab completion, the parameters of the cmdlet are not fully parsed, i.e. if a user specifies e.g. `Parameter1`via commandline as `-Parameter1 'myparameter'` using either single or double quotes, then the quotes are still present in the C# string. This does not happen at the point of execution. Is there a better workaround to replacing the quotes by calling some other internal method instead? Is this an issue with the `TabExpansion2` method or `PSReadLine` or something else?\r\n\r\nSteps to reproduce\r\n------------------\r\nFirst Compile the following in a classic .Net library project and then import the dll into PowerShell using `Import-Module`\r\n```c#\r\nusing System;\r\nusing System.Management.Automation;\r\n\r\nnamespace ClassLibrary1\r\n{\r\n [Cmdlet(\"Test\", \"TabCompletion\")]\r\n public class TestCmdlet : Cmdlet, IDynamicParameters\r\n {\r\n [Parameter(Mandatory = true)]\r\n public string Parameter1 { get; set; }\r\n\r\n public object GetDynamicParameters()\r\n {\r\n if (!string.IsNullOrEmpty(Parameter1))\r\n {\r\n if (Parameter1.StartsWith(\"\\\"\") || Parameter1.StartsWith(\"\\'\"))\r\n {\r\n throw new Exception(\"Bug: PowerShell has not fully parsed already given input parameter and left the quotes from the command line input\");\r\n }\r\n }\r\n // Here would be some logic to return a dynamic parameter based on the input of non-dynamic parameters\r\n return null;\r\n }\r\n\r\n protected override void ProcessRecord()\r\n {\r\n WriteObject(Parameter1);\r\n }\r\n }\r\n}\r\n```\r\n```powershell\r\nImport-Module $pathToCompiledDll\r\n# Attach VS debugger to powershell process\r\nTest-TabCompletion -Parameter1 \"test\" # do not execute this line but press 'tab' to invoke tab completion\r\n```\r\n\r\nExpected behavior\r\n-----------------\r\n\r\n`Parameter1` should have the value `test` (as observed in the VS debugger since `GetDynamicParameters` suppress any raised exceptions)\r\n\r\nActual behavior\r\n---------------\r\n`Parameter1` has the value `\"test\"`\r\n\r\nNotes: Similarly, single quotes remain as well. If one would have used an interpolated string like `\"test$number\"`, then one would get the value `\"test$number\"`, whereas `\"test$($number)\"`\r\n would at least give `\"test1\"`\r\nThis bug also occurs in Windows PowerShell 5.1\r\n\r\nEnvironment data\r\n----------------\r\n\r\n```powershell\r\n> $PSVersionTable\r\nName Value\r\n---- -----\r\nPSVersion 6.0.0-beta.8\r\nPSEdition Core\r\nGitCommitId v6.0.0-beta.8\r\nOS Microsoft Windows 6.3.9600\r\nPlatform Win32NT\r\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}\r\nPSRemotingProtocolVersion 2.3\r\nSerializationVersion 1.1.0.1\r\nWSManStackVersion 3.0\r\n```","author":{"url":"https://github.com/bergmeister","@type":"Person","name":"bergmeister"},"datePublished":"2017-11-03T11:18:19Z","url":"https://github.com/PowerShell/PowerShell/issues/5326"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:99fe4285-a232-1d94-2cf1-8645415861d9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A7C8:B4351:A59830:ED895A:6AFDA056 |
| html-safe-nonce | 86e7623f970f7bccc23f7f6789df2ac8b5f0f13c8c655e7569fa3e798bb47a0c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0M4OkI0MzUxOkE1OTgzMDpFRDg5NUE6NkFGREEwNTYiLCJ2aXNpdG9yX2lkIjoiMTYwNTg1MTkwODI4MTMxMTMxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 22fc77d56911a0f8c2cc59b0945b3db5c53a5971043423e4ad3a90092604bd7c |
| hovercard-subject-tag | issue:270945663 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/5326/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ceb0ec50efa235ea36a36d0480d936d46c2fb7e3f83735b893a30d7264691955/PowerShell/PowerShell/issues/5326 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ceb0ec50efa235ea36a36d0480d936d46c2fb7e3f83735b893a30d7264691955/PowerShell/PowerShell/issues/5326 |
| og:image:alt | When IDynamicParameters.GetDynamicParameters() gets called via tab completion, the parameters of the cmdlet are not fully parsed, i.e. if a user specifies e.g. Parameter1via commandline as -Paramet... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bergmeister |
| hostname | github.com |
| expected-hostname | github.com |
| None | bc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width