Title: Address Code Cleanup Comments in PR #4318 · Issue #4596 · PowerShell/PowerShell · GitHub
Open Graph Title: Address Code Cleanup Comments in PR #4318 · Issue #4596 · PowerShell/PowerShell
X Title: Address Code Cleanup Comments in PR #4318 · Issue #4596 · PowerShell/PowerShell
Description: There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task. src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertToJsonComman...
Open Graph Description: There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task. src/Microsoft.PowerShell.Commands.Utility/comman...
X Description: There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task. src/Microsoft.PowerShell.Commands.Utility/comman...
Opengraph URL: https://github.com/PowerShell/PowerShell/issues/4596
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Address Code Cleanup Comments in PR #4318","articleBody":"There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task.\r\n\r\n1.\r\nsrc/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertToJsonCommand.cs \r\n@@ -60,6 +61,15 @@ public class ConvertToJsonCommand : PSCmdlet\r\n [Parameter] \r\n public SwitchParameter Compress { get; set; } \r\n\r\n+ /// \u003csummary\u003e \r\n+ /// gets or sets the EnumsAsStrings property. \r\n\r\nPlease correct typo gets -\u003e Gets.\r\n\r\n2. \r\ntest/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1 \r\n+ \r\n+ $response4 = ConvertTo-Json -InputObject $sampleObject -Compress -EnumsAsStrings \r\n+ $response4 | Should Be '{\"SampleSimpleEnum\":\"Ignore\",\"SampleBitwiseEnum\":\"Alias, Function, Cmdlet\"}' \r\n+ \r\n\r\nPlease remove extra line.\r\n\r\n3.\r\ntest/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1 \r\n+ $response4 | Should Be '{\"SampleSimpleEnum\":\"Ignore\",\"SampleBitwiseEnum\":\"Alias, Function, Cmdlet\"}' \r\n+ \r\n+ } \r\n+ \r\n\r\nPlease remove extra line.","author":{"url":"https://github.com/mirichmo","@type":"Person","name":"mirichmo"},"datePublished":"2017-08-16T16:50:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/4596/PowerShell/issues/4596"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3c02cbad-5389-c2f2-e353-94469e279439 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE0E:E260A:8E4D26:CCF960:6A578950 |
| html-safe-nonce | 8868296181c472c3fa5f8aca5e7a011ca64d670ba9da7d27c72c5bce34ebcdee |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTBFOkUyNjBBOjhFNEQyNjpDQ0Y5NjA6NkE1Nzg5NTAiLCJ2aXNpdG9yX2lkIjoiNjgwNDA1MDM1NDE3MjgyMzg4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fcaca96c61a045f58705581ce1e428f288fc7d9c5ab0c9043ccb7c184ee688b3 |
| hovercard-subject-tag | issue:250692221 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/4596/issue_layout |
| twitter:image | https://opengraph.githubassets.com/07ca6f30cf3fa52a79b16d2b320d1c7578f3eb28cea850b6173d49a88acf200e/PowerShell/PowerShell/issues/4596 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/07ca6f30cf3fa52a79b16d2b320d1c7578f3eb28cea850b6173d49a88acf200e/PowerShell/PowerShell/issues/4596 |
| og:image:alt | There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task. src/Microsoft.PowerShell.Commands.Utility/comman... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mirichmo |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6353e56e94423c9cd5abde7708a859afa36a0c1203c73749055bf6ee6704cd0 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f59ab1c46b638204e2aea09126d089be5dc773b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width