René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove FullCLR code","articleBody":"This project started as a fork of the Windows PowerShell 5.1 code base.  As we've progressed towards a PowerShell Core 6.0 release and with the capability of dotnet core 2.0 and dotnet std 2.0 being able to load dotnet framework 4.5.1+ assemblies that are compatible with dotnet std 2.0, we can simplify the code base by removing the legacy FullCLR code so that we no longer have #ifdefs for CORECLR (and !CORECLR).  This was discussed and approved by @PowerShell/powershell-committee.  When reviewing the code, do not blindly just remove the FullCLR code, but validate if updates to .NET Core means using the FullCLR code instead of the limited .NET Core code.\r\n\r\n# Remaining `#if [!]CORECLR` usages\r\n\r\n```powershell\r\nparam($path = \"../repos/PowerShell\")\r\n\r\n$sources = Get-ChildItem -Recurse -Path $path -Include *.cs\r\nforeach ($source in $sources) {\r\n    $content = Get-Content $source -Raw\r\n    if ($content -match \"#if CORECLR\" -or $content -match \"#if !CORECLR\") {\r\n        $source.FullName\r\n    }\r\n}\r\n```\r\n\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/CoreCLR/Stubs.cs\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/CommonUtils.cs\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/ExportCounterCommand.cs\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/GetCounterCommand.cs\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/ImportCounterCommand.cs\r\nsrc/Microsoft.PowerShell.Commands.Diagnostics/NewWinEventCommand.cs\r\nsrc/Microsoft.PowerShell.Commands.Utility/commands/utility/new-object.cs\r\nsrc/Microsoft.PowerShell.LocalAccounts/LocalAccounts/Extensions.cs\r\nsrc/Microsoft.PowerShell.LocalAccounts/LocalAccounts/Sam.cs\r\nsrc/Microsoft.PowerShell.Security/security/AclCommands.cs\r\nsrc/Microsoft.PowerShell.Security/security/CertificateProvider.cs\r\nsrc/Microsoft.PowerShell.Security/security/ExecutionPolicyCommands.cs\r\nsrc/Microsoft.WSMan.Management/CredSSP.cs\r\nsrc/Microsoft.WSMan.Management/Interop.cs\r\nsrc/Microsoft.WSMan.Management/WsManHelper.cs\r\nsrc/System.Management.Automation/cimSupport/cmdletization/xml/CoreCLR/cmdlets-over-objects.xmlSerializer.autogen.cs\r\nsrc/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs\r\nsrc/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs\r\nsrc/System.Management.Automation/DscSupport/CimDSCParser.cs\r\nsrc/System.Management.Automation/engine/debugger/debugger.cs\r\nsrc/System.Management.Automation/engine/hostifaces/Command.cs\r\nsrc/System.Management.Automation/engine/hostifaces/Connection.cs\r\nsrc/System.Management.Automation/engine/hostifaces/ConnectionBase.cs\r\nsrc/System.Management.Automation/engine/hostifaces/HostUtilities.cs\r\nsrc/System.Management.Automation/engine/hostifaces/InternalHost.cs\r\nsrc/System.Management.Automation/engine/hostifaces/LocalConnection.cs\r\nsrc/System.Management.Automation/engine/hostifaces/LocalPipeline.cs\r\nsrc/System.Management.Automation/engine/hostifaces/Parameter.cs\r\nsrc/System.Management.Automation/engine/hostifaces/PowerShell.cs\r\nsrc/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs\r\nsrc/System.Management.Automation/engine/hostifaces/RunspacePool.cs\r\nsrc/System.Management.Automation/engine/hostifaces/RunspacePoolInternal.cs\r\nsrc/System.Management.Automation/engine/interpreter/ControlFlowInstructions.cs\r\nsrc/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs\r\nsrc/System.Management.Automation/engine/parser/Compiler.cs\r\nsrc/System.Management.Automation/engine/parser/FusionAssemblyIdentity.cs\r\nsrc/System.Management.Automation/engine/parser/GlobalAssemblyCache.cs\r\nsrc/System.Management.Automation/engine/parser/Parser.cs\r\nsrc/System.Management.Automation/engine/parser/TypeResolver.cs\r\nsrc/System.Management.Automation/engine/remoting/client/remoterunspace.cs\r\nsrc/System.Management.Automation/engine/remoting/commands/CustomShellCommands.cs\r\nsrc/System.Management.Automation/engine/remoting/commands/EnterPSHostProcessCommand.cs\r\nsrc/System.Management.Automation/engine/remoting/commands/remotingcommandutil.cs\r\nsrc/System.Management.Automation/engine/remoting/commands/ResumeJob.cs\r\nsrc/System.Management.Automation/engine/remoting/commands/SuspendJob.cs\r\nsrc/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs\r\nsrc/System.Management.Automation/engine/remoting/common/RemoteSessionNamedPipe.cs\r\nsrc/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs\r\nsrc/System.Management.Automation/engine/remoting/common/throttlemanager.cs\r\nsrc/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs\r\nsrc/System.Management.Automation/engine/remoting/fanin/InitialSessionStateProvider.cs\r\nsrc/System.Management.Automation/engine/remoting/fanin/WSManPlugin.cs\r\nsrc/System.Management.Automation/engine/remoting/fanin/WSManPluginFacade.cs\r\nsrc/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs\r\nsrc/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs\r\nsrc/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs\r\nsrc/System.Management.Automation/engine/remoting/server/serverremotesession.cs\r\nsrc/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs\r\nsrc/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineDriver.cs\r\nsrc/System.Management.Automation/engine/Attributes.cs\r\nsrc/System.Management.Automation/engine/CommandDiscovery.cs\r\nsrc/System.Management.Automation/engine/CommandMetadata.cs\r\nsrc/System.Management.Automation/engine/ExecutionContext.cs\r\nsrc/System.Management.Automation/engine/GetEvent_Types_Ps1Xml.cs\r\nsrc/System.Management.Automation/engine/InitialSessionState.cs\r\nsrc/System.Management.Automation/engine/LanguagePrimitives.cs\r\nsrc/System.Management.Automation/engine/MshCommandRuntime.cs\r\nsrc/System.Management.Automation/engine/pipeline.cs\r\nsrc/System.Management.Automation/engine/serialization.cs\r\nsrc/System.Management.Automation/engine/Types_Ps1Xml.cs\r\nsrc/System.Management.Automation/engine/Utils.cs\r\nsrc/System.Management.Automation/help/HelpSystem.cs\r\nsrc/System.Management.Automation/help/UpdatableHelpCommandBase.cs\r\nsrc/System.Management.Automation/help/UpdatableHelpSystem.cs\r\nsrc/System.Management.Automation/help/UpdateHelpCommand.cs\r\nsrc/System.Management.Automation/logging/MshLog.cs\r\nsrc/System.Management.Automation/namespaces/FileSystemProvider.cs\r\nsrc/System.Management.Automation/namespaces/RegistryProvider.cs\r\nsrc/System.Management.Automation/namespaces/Win32Native.cs\r\nsrc/System.Management.Automation/security/SecureStringHelper.cs\r\nsrc/System.Management.Automation/singleshell/config/MshSnapinInfo.cs\r\nsrc/System.Management.Automation/utils/ClrFacade.cs\r\nsrc/System.Management.Automation/utils/StructuredTraceSource.cs\r\n","author":{"url":"https://github.com/SteveL-MSFT","@type":"Person","name":"SteveL-MSFT"},"datePublished":"2017-07-27T04:59:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":32},"url":"https://github.com/4357/PowerShell/issues/4357"}