Title: Review all if/def and Unix specific code after moving to .NET Core 2.0 · Issue #3565 · PowerShell/PowerShell · GitHub
Open Graph Title: Review all if/def and Unix specific code after moving to .NET Core 2.0 · Issue #3565 · PowerShell/PowerShell
X Title: Review all if/def and Unix specific code after moving to .NET Core 2.0 · Issue #3565 · PowerShell/PowerShell
Description: PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to: Clean up the code Make sure the code make sense and is not a temporary hack An Example (Please remo...
Open Graph Description: PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to: Clean up the code Make sure the code make sense and is not ...
X Description: PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to: Clean up the code Make sure the code make sense and is not ...
Opengraph URL: https://github.com/PowerShell/PowerShell/issues/3565
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review all if/def and Unix specific code after moving to .NET Core 2.0","articleBody":"PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to:\r\n- Clean up the code\r\n- Make sure the code make sense and is not a temporary hack\r\n\r\n#### An Example (Please remove when fixed)\r\n`Platform.InternalGetFolderPath` in `src/System.Management.Automation/CoreCLR/CorePsPlatform.cs` has the following code:\r\n```\r\n case System.Environment.SpecialFolder.ProgramFiles:\r\n folderPath = \"/bin\";\r\n if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }\r\n break;\r\n case System.Environment.SpecialFolder.ProgramFilesX86:\r\n folderPath = \"/usr/bin\";\r\n if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }\r\n break;\r\n case System.Environment.SpecialFolder.System:\r\n case System.Environment.SpecialFolder.SystemX86:\r\n folderPath = \"/sbin\";\r\n if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }\r\n break;\r\n```\r\nIt use `/bin` for `ProgramFiles`, `/usr/bin` for `ProgramFilesX86` and `/sbin` for `System` and `SystemX86`. It's not clear if this is appropriate, so code like this should be reviewed.","author":{"url":"https://github.com/daxian-dbw","@type":"Person","name":"daxian-dbw"},"datePublished":"2017-04-14T19:04:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/3565/PowerShell/issues/3565"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:43d2986c-983e-3c22-0858-76687f1ce93e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A91A:814DC:F3C06A:145A039:6A5331B2 |
| html-safe-nonce | be0cda01f028cad2f9c495472b622f15a7944f2648f107562461b8069fdd3cce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTFBOjgxNERDOkYzQzA2QToxNDVBMDM5OjZBNTMzMUIyIiwidmlzaXRvcl9pZCI6IjI1NDQ1NDQzNjExNjI2ODI4MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 161c4cf316bd39a38bf1da201cb2737314d9746995c0be654e21c19b85223879 |
| hovercard-subject-tag | issue:221870281 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/3565/issue_layout |
| twitter:image | https://opengraph.githubassets.com/869cb501f2771e4c53d528b1b9ecc04d030a979236735cb7efb1121f7b605d7e/PowerShell/PowerShell/issues/3565 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/869cb501f2771e4c53d528b1b9ecc04d030a979236735cb7efb1121f7b605d7e/PowerShell/PowerShell/issues/3565 |
| og:image:alt | PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to: Clean up the code Make sure the code make sense and is not ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | daxian-dbw |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width