René's URL Explorer Experiment


Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell · GitHub

Open Graph Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell

X Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell

Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt { … } body by string-interpolating the V...

Open Graph Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ...

X Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/28255

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render","articleBody":"## Summary\n\n`PushRunspaceCommand.SetRunspacePrompt()` (line 1138, `src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs`, current HEAD `bf456e85`) builds a `function global:prompt { … }` body by string-interpolating the VM/container name directly into a double-quoted PowerShell string, with no escaping.\n\nBecause the result is executed with `ps.AddScript(promptFn).Invoke()`, any `$(…)` subexpression embedded in the name is evaluated — once when the function is defined, and again **on every subsequent prompt draw**, because that is how the host prompt works.\n\n## Affected code\n\n```csharp\n// PushRunspaceCommand.cs ~line 1178\nstring promptFn = StringUtil.Format(RemotingErrorIdStrings.EnterVMSessionPrompt,\n    @\"function global:prompt { \"\"\",\n    targetName,          // ← no escaping\n    @\"PS $($executionContext.SessionState.Path.CurrentLocation)> \"\" }\");\n\nps.AddScript(promptFn).Invoke();\n```\n\n`targetName` is set from `this.VMName`, `this.ContainerId`, `this.Session.ComputerName`, or `remoteRunspace.ConnectionInfo.ComputerName` depending on the parameter set. None of these values are validated or escaped before use. `StringUtil.Format` is a plain `string.Format(CultureInfo.CurrentCulture, …)` wrapper with no sanitization (confirmed in `StringUtil.cs`).\n\nThe template in `RemotingErrorIdStrings.resx` is `{0}[{1}]: {2}` — slot `{1}` receives `targetName` unmodified.\n\n## Reproduction (no Hyper-V required)\n\nThe following reproduces the exact string-building and execution logic used by the real code path:\n\n```powershell\n$template = \"{0}[{1}]: {2}\"\n$maliciousName = '$(Write-Output \"INJECTED @ $(Get-Date -Format o)\")'\n$arg0 = 'function global:prompt { \"'\n$arg2 = 'PS $($executionContext.SessionState.Path.CurrentLocation)> \" }'\n\n$promptFn = $template -f $arg0, $maliciousName, $arg2\nInvoke-Expression $promptFn\n\nprompt   # fires injection #1\nprompt   # fires injection #2, different timestamp\n```\n\nOutput shows two different timestamps — confirming re-execution on every prompt call, not just at definition time.\n\n## Real-world trigger\n\nAny user who can name or rename a Hyper-V VM or Windows Container to a string containing `$(…)` causes injected code to execute inside the session of any user who runs `Enter-PSSession -VMName` (or `-VMId`, `-ContainerId`) against it. The injected code re-runs after every command typed in that session.\n\n## Suggested fix\n\n**Option A** — escape `targetName` before interpolation using the API already used correctly elsewhere in the codebase (`CodeGeneration.EscapeSingleQuotedStringContent`):\n\n```csharp\nstring safeName = CodeGeneration.EscapeSingleQuotedStringContent(targetName);\nstring promptFn = StringUtil.Format(RemotingErrorIdStrings.EnterVMSessionPrompt,\n    @\"function global:prompt { '\",\n    safeName,\n    @\"' + \"\" PS $($executionContext.SessionState.Path.CurrentLocation)> \"\" }\");\n```\n\n**Option B** — stop building the prompt as script text. Pass `targetName` into the runspace as a variable and reference it from a script block, so it is never evaluated as PowerShell syntax.\n\n## Affected files\n\n- `src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs` (`SetRunspacePrompt()` line 1138; `VMName` property line 158)\n- `src/System.Management.Automation/resources/RemotingErrorIdStrings.resx` (`EnterVMSessionPrompt` key)\n- `src/System.Management.Automation/utils/StringUtil.cs` (Format overloads)","author":{"url":"https://github.com/lupin-sudo","@type":"Person","name":"lupin-sudo"},"datePublished":"2026-10-24T09:57:33Z","url":"https://github.com/PowerShell/PowerShell/issues/28255"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b8ba2b35-9d54-b4c9-7765-486a242c865e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9858:1ECA09:3F5CE8:5398BB:6AFCE8DB
html-safe-nonce5616a6bb92555ab046f063f3fa7bb3ed22b14e51bfaac2d43875ed18810e4842
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODU4OjFFQ0EwOTozRjVDRTg6NTM5OEJCOjZBRkNFOERCIiwidmlzaXRvcl9pZCI6IjMzNjQ0MzM0NDAyMjM4NDg2NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ac5d0fdddfaec13982c5dc98087dc7431008232706a373bebc3d5539f0b0135
hovercard-subject-tagissue:6011721879
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/28255/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8966b35ae4020abf3fce75f8ccc90622ccd22ed67a13c610ea5de8191abcacf5/PowerShell/PowerShell/issues/28255
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8966b35ae4020abf3fce75f8ccc90622ccd22ed67a13c610ea5de8191abcacf5/PowerShell/PowerShell/issues/28255
og:image:altSummary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelupin-sudo
hostnamegithub.com
expected-hostnamegithub.com
None99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseecfd63ca125ec74b42f74eeb158b3fa081c8c497
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/28255#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F28255
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F28255
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/28255
Reloadhttps://github.com/PowerShell/PowerShell/issues/28255
Reloadhttps://github.com/PowerShell/PowerShell/issues/28255
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests364 (364)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/28255
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/28255
#28378https://github.com/PowerShell/PowerShell/pull/28378
SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt renderhttps://github.com/PowerShell/PowerShell/issues/28255#top
#28378https://github.com/PowerShell/PowerShell/pull/28378
In-PRIndicates that a PR is out for the issuehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22In-PR%22
https://github.com/lupin-sudo
lupin-sudohttps://github.com/lupin-sudo
on Oct 24, 2026https://github.com/PowerShell/PowerShell/issues/28255#issue-6011721879
https://github.com/lupin-sudo
lupin-sudohttps://github.com/lupin-sudo
on Oct 24, 2026https://github.com/PowerShell/PowerShell/issues/28255#issuecomment-6382826402
lupin-sudohttps://github.com/lupin-sudo
https://github.com/kilasuit
Ryan Yates (kilasuit)https://github.com/kilasuit
on Nov 8, 2026https://github.com/PowerShell/PowerShell/issues/28255#issuecomment-6722252500
this branchhttps://github.com/kilasuit/PowerShell/tree/28255-remote-runspace-prompt
this PRhttps://github.com/PowerShell/PowerShell/pull/28378
commit f229dc0https://github.com/PowerShell/PowerShell/commit/f229dc0d8123328231dd3c89fe2105a1759c92f0
commit afa9957https://github.com/PowerShell/PowerShell/commit/afa9957490a7eb5dfe9097aa89382186fd9ac68e
Ryan Yates (kilasuit)https://github.com/kilasuit
In-PRIndicates that a PR is out for the issuehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22In-PR%22
on Nov 8, 2026https://github.com/PowerShell/PowerShell/issues/28255#event-35499455648
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/28255
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/28255
In-PRIndicates that a PR is out for the issuehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22In-PR%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.