Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell · GitHub
Open Graph Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell
X Title: SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render · Issue #28255 · PowerShell/PowerShell
Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt { … } body by string-interpolating the V...
Open Graph Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ...
X Description: Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ...
Opengraph URL: https://github.com/PowerShell/PowerShell/issues/28255
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SetRunspacePrompt() injects VM/container name into PowerShell script without escaping — arbitrary code executes on every prompt render","articleBody":"## Summary\n\n`PushRunspaceCommand.SetRunspacePrompt()` (line 1138, `src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs`, current HEAD `bf456e85`) builds a `function global:prompt { … }` body by string-interpolating the VM/container name directly into a double-quoted PowerShell string, with no escaping.\n\nBecause the result is executed with `ps.AddScript(promptFn).Invoke()`, any `$(…)` subexpression embedded in the name is evaluated — once when the function is defined, and again **on every subsequent prompt draw**, because that is how the host prompt works.\n\n## Affected code\n\n```csharp\n// PushRunspaceCommand.cs ~line 1178\nstring promptFn = StringUtil.Format(RemotingErrorIdStrings.EnterVMSessionPrompt,\n @\"function global:prompt { \"\"\",\n targetName, // ← no escaping\n @\"PS $($executionContext.SessionState.Path.CurrentLocation)> \"\" }\");\n\nps.AddScript(promptFn).Invoke();\n```\n\n`targetName` is set from `this.VMName`, `this.ContainerId`, `this.Session.ComputerName`, or `remoteRunspace.ConnectionInfo.ComputerName` depending on the parameter set. None of these values are validated or escaped before use. `StringUtil.Format` is a plain `string.Format(CultureInfo.CurrentCulture, …)` wrapper with no sanitization (confirmed in `StringUtil.cs`).\n\nThe template in `RemotingErrorIdStrings.resx` is `{0}[{1}]: {2}` — slot `{1}` receives `targetName` unmodified.\n\n## Reproduction (no Hyper-V required)\n\nThe following reproduces the exact string-building and execution logic used by the real code path:\n\n```powershell\n$template = \"{0}[{1}]: {2}\"\n$maliciousName = '$(Write-Output \"INJECTED @ $(Get-Date -Format o)\")'\n$arg0 = 'function global:prompt { \"'\n$arg2 = 'PS $($executionContext.SessionState.Path.CurrentLocation)> \" }'\n\n$promptFn = $template -f $arg0, $maliciousName, $arg2\nInvoke-Expression $promptFn\n\nprompt # fires injection #1\nprompt # fires injection #2, different timestamp\n```\n\nOutput shows two different timestamps — confirming re-execution on every prompt call, not just at definition time.\n\n## Real-world trigger\n\nAny user who can name or rename a Hyper-V VM or Windows Container to a string containing `$(…)` causes injected code to execute inside the session of any user who runs `Enter-PSSession -VMName` (or `-VMId`, `-ContainerId`) against it. The injected code re-runs after every command typed in that session.\n\n## Suggested fix\n\n**Option A** — escape `targetName` before interpolation using the API already used correctly elsewhere in the codebase (`CodeGeneration.EscapeSingleQuotedStringContent`):\n\n```csharp\nstring safeName = CodeGeneration.EscapeSingleQuotedStringContent(targetName);\nstring promptFn = StringUtil.Format(RemotingErrorIdStrings.EnterVMSessionPrompt,\n @\"function global:prompt { '\",\n safeName,\n @\"' + \"\" PS $($executionContext.SessionState.Path.CurrentLocation)> \"\" }\");\n```\n\n**Option B** — stop building the prompt as script text. Pass `targetName` into the runspace as a variable and reference it from a script block, so it is never evaluated as PowerShell syntax.\n\n## Affected files\n\n- `src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs` (`SetRunspacePrompt()` line 1138; `VMName` property line 158)\n- `src/System.Management.Automation/resources/RemotingErrorIdStrings.resx` (`EnterVMSessionPrompt` key)\n- `src/System.Management.Automation/utils/StringUtil.cs` (Format overloads)","author":{"url":"https://github.com/lupin-sudo","@type":"Person","name":"lupin-sudo"},"datePublished":"2026-10-24T09:57:33Z","url":"https://github.com/PowerShell/PowerShell/issues/28255"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b8ba2b35-9d54-b4c9-7765-486a242c865e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9858:1ECA09:3F5CE8:5398BB:6AFCE8DB |
| html-safe-nonce | 5616a6bb92555ab046f063f3fa7bb3ed22b14e51bfaac2d43875ed18810e4842 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODU4OjFFQ0EwOTozRjVDRTg6NTM5OEJCOjZBRkNFOERCIiwidmlzaXRvcl9pZCI6IjMzNjQ0MzM0NDAyMjM4NDg2NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ac5d0fdddfaec13982c5dc98087dc7431008232706a373bebc3d5539f0b0135 |
| hovercard-subject-tag | issue:6011721879 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/28255/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8966b35ae4020abf3fce75f8ccc90622ccd22ed67a13c610ea5de8191abcacf5/PowerShell/PowerShell/issues/28255 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8966b35ae4020abf3fce75f8ccc90622ccd22ed67a13c610ea5de8191abcacf5/PowerShell/PowerShell/issues/28255 |
| og:image:alt | Summary PushRunspaceCommand.SetRunspacePrompt() (line 1138, src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs, current HEAD bf456e85) builds a function global:prompt ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lupin-sudo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ecfd63ca125ec74b42f74eeb158b3fa081c8c497 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width