Title: Should The PR Acceptance Criteria checklist be updated to require that commits are Signed & that the Email address provided is reachable? · Issue #27775 · PowerShell/PowerShell · GitHub
Open Graph Title: Should The PR Acceptance Criteria checklist be updated to require that commits are Signed & that the Email address provided is reachable? · Issue #27775 · PowerShell/PowerShell
X Title: Should The PR Acceptance Criteria checklist be updated to require that commits are Signed & that the Email address provided is reachable? · Issue #27775 · PowerShell/PowerShell
Description: During discussion of #27086 in the Cmdlets Working Group it was brought up about this particular comment by @KirtiRamchandani specifically There are still commit provenance concerns in the PR history. One commit is authored and committed...
Open Graph Description: During discussion of #27086 in the Cmdlets Working Group it was brought up about this particular comment by @KirtiRamchandani specifically There are still commit provenance concerns in the PR histo...
X Description: During discussion of #27086 in the Cmdlets Working Group it was brought up about this particular comment by @KirtiRamchandani specifically There are still commit provenance concerns in the PR histo...
Mail addresses
bot@example.com
thatgfsj@example.com
Opengraph URL: https://github.com/PowerShell/PowerShell/issues/27775
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should The PR Acceptance Criteria checklist be updated to require that commits are Signed & that the Email address provided is reachable?","articleBody":"During discussion of #27086 in the Cmdlets Working Group it was brought up about [this particular comment by @KirtiRamchandani](https://github.com/PowerShell/PowerShell/pull/27086#issuecomment-5188818556) specifically\n\n> 4. There are still commit provenance concerns in the PR history. One commit is authored and committed as Thatgfsj \u003cbot@example.com> (d21d9bb11b23709da1b1860283088f77b315b93d), and earlier commits use thatgfsj@example.com. Some local validation/provenance tooling treats placeholder example.com identities as suspicious, so it would be good to re-author/squash with a normal verified GitHub or noreply identity before merge. P.S.: I contribute to MSRC security and regularly use the PowerShell codebase to report security bugs upstream and my workspace device flagged this.\n\n[Verified Commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) is a feature that GitHub either added or exposed more widely years after this repo was created & as far as I can tell was publicised 2021/2022 so many years later than this repo was created and processes put in place.\n\nThere are valid concerns with not requiring commits to be Signed, as well as in the User Experience with working with this repository, even though it is a good recommended practice.\n\nWhilst I sign my commits, this there are a number of issues that come with this, in reduced functionality in some 1st and 3rd party tooling like \n\n - [Rebased commits by the web interface aren't signed](https://github.com/orgs/community/discussions/11639)\n - Additionally Squash Commits via the Web interface don't seem to get signed either.\n - 3rd party apps have to support this as well.\n\nI am not sure if this project specifically really needs to require signed commits from all contributors, based on the following few points\n\n- We have a strong review process for contributions \n- This adds another layer of friction for smaller contributions, like docs in this repo, or spelling issues.\n- Is it required as part of the Microsoft Contributors License Agreement? (which I signed years ago)\n- We then are asking contributors to manage keys that they may not already be doing, as they may have no prior need for using SSH/GPG Keys. GitHub doesn't force users to enable this either.\n- I think Maintainers and long term contributors including those with triage rights **should** have Verified Commits set up, perhaps ideally with Vigilant mode enabled (I currently do not)\n\nThe vast majority of commits to master are verified, however there are some commits that have not been as recently as May this year.\n\n@SteveL-MSFT Asked me to create this issue for the Security Working Group.\nAs such the questions to the Security Working Group is as follows.\n\nDoes the Working group feel that this repository, potentially for as other PowerShell org repositories too, need to update the PR Checklists & Contribution docs as to enforce that all contributors commits are signed?\n\nOn a similar note, should the email associated with the commit be from a reachable domain, and not generalised non-reachable ones?","author":{"url":"https://github.com/kilasuit","@type":"Person","name":"kilasuit"},"datePublished":"2026-08-06T14:49:39Z","url":"https://github.com/PowerShell/PowerShell/issues/27775"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4ef2afb2-4c8d-5a2f-6a08-ebf1d6ba893b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80E0:CDFC:51315:6DF6E:6AFD37B7 |
| html-safe-nonce | 80d9afe47283850cd8d676f17d31f569ea46326a2cbcec4afeab9832b95dd670 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEUwOkNERkM6NTEzMTU6NkRGNkU6NkFGRDM3QjciLCJ2aXNpdG9yX2lkIjoiODM3OTM2MDY0MDg1Mzk0ODM0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 306fd8dff08b54d17e26367e3f170a677b56be3808cb815b114aefef64094370 |
| hovercard-subject-tag | issue:5082410578 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/27775/issue_layout |
| twitter:image | https://opengraph.githubassets.com/61f99b6a41da229740448cb31a91ef036e61b9c29c7719025739387460ce2cb2/PowerShell/PowerShell/issues/27775 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61f99b6a41da229740448cb31a91ef036e61b9c29c7719025739387460ce2cb2/PowerShell/PowerShell/issues/27775 |
| og:image:alt | During discussion of #27086 in the Cmdlets Working Group it was brought up about this particular comment by @KirtiRamchandani specifically There are still commit provenance concerns in the PR histo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kilasuit |
| hostname | github.com |
| expected-hostname | github.com |
| None | 065128366c233a9d57ff68ab6c96e25b99dd1b0ab70d23b70873d3dd6b5e4f19 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 941021edf0c2ec58298f4a2c8f27ae507d129c92 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width