René's URL Explorer Experiment


Title: `Compare-Object` doesn't compare custom value types (`structs`) (that don't implement `IComparable`) correctly · Issue #23805 · PowerShell/PowerShell · GitHub

Open Graph Title: `Compare-Object` doesn't compare custom value types (`structs`) (that don't implement `IComparable`) correctly · Issue #23805 · PowerShell/PowerShell

X Title: `Compare-Object` doesn't compare custom value types (`structs`) (that don't implement `IComparable`) correctly · Issue #23805 · PowerShell/PowerShell

Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerShell 5.1 and PowerShell. Steps to reprodu...

Open Graph Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...

X Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/23805

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`Compare-Object` doesn't compare custom value types (`structs`) (that don't implement `IComparable`) correctly","articleBody":"### Prerequisites\r\n\r\n- [X] Write a descriptive title.\r\n- [X] Make sure you are able to repro it on the [latest released version](https://github.com/PowerShell/PowerShell/releases)\r\n- [X] Search the existing issues.\r\n- [X] Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md).\r\n- [X] Refer to [Differences between Windows PowerShell 5.1 and PowerShell](https://learn.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell).\r\n\r\n### Steps to reproduce\r\n\r\nBecause `Compare-Object` doesn't respect a `false` return value when the `.Equals()` method is called, it falls back to _string_ comparison, which, with the default `.ToString()` implementation, results in false positives.\r\n\r\nHowever, for instances of _value types_, a `false` return value _should_ be trusted, given that a _value_ equality test is performed.\r\n(This only applies if they don't implement `IComparable`; if they do, the latter is used.)\r\n\r\n```powershell\r\nAdd-Type @'\r\npublic struct Foo {\r\n  public int Num;\r\n}\r\n'@\r\n\r\n$instance1, $instance2 = [Foo]::new(), [Foo]::new()\r\n\r\n# Make one instance different\r\n$instance1.Num = 1\r\n\r\n# Compare them.\r\n# !! This currently produces NO output, even though the two instances\r\n# !! are clearly different ($instance1 -eq $instance2 yields $false)\r\nCompare-Object $instance1 $instance2\r\n```\r\n\r\n---\r\n\r\nRelated:\r\n\r\n * #12498\r\n\r\n### Expected behavior\r\n\r\nThe two instances should be considered unequal, and produce something like:\r\n\r\n\r\n```console\r\nInputObject SideIndicator\r\n----------- -------------\r\nFoo          =>\r\nFoo          \u003c=\r\n```\r\n\r\nNote: With the default `.ToString()` implementation, both instances stringify to their (full) type name, so the reason for their inequality doesn't show here (and this default `.ToString()` implementation is also the cause of the false positives).\r\n\r\n\r\n### Actual behavior\r\n\r\nNo output. That is, due to the inappropriate string-comparison fallback (which results in comparing two `'Foo'` strings), `Compare-Object` unexpectedly considered these value-type instances equal, even though they're clearly not (as `$instance1 -eq $instance2` shows).\r\n\r\n\r\n### Error details\r\n\r\n_No response_\r\n\r\n### Environment data\r\n\r\n```powershell\r\nPowerShell 7.5.0-preview.2\r\n```\r\n\r\n\r\n### Visuals\r\n\r\n_No response_","author":{"url":"https://github.com/mklement0","@type":"Person","name":"mklement0"},"datePublished":"2024-05-15T14:22:42Z","url":"https://github.com/PowerShell/PowerShell/issues/23805"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:466d0c72-66fd-554d-7588-c028decd8649
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBC78:21306C:22B5E5:306730:6AFD8264
html-safe-nonce491640083bb7372017b182dfa2786541a366109705faa0f440592a44a9dfca3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzc4OjIxMzA2QzoyMkI1RTU6MzA2NzMwOjZBRkQ4MjY0IiwidmlzaXRvcl9pZCI6IjUzNzExMzgwODA0MTk3MDk1NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca4a674a57fb0610286f80322b2da0368d5b66fea98275f7adc191a9149ffaaf0
hovercard-subject-tagissue:2298085382
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/23805/issue_layout
twitter:imagehttps://opengraph.githubassets.com/276d4b11253cf617bec23c84710164f289c62f4c79cc46ec4d2d006de0273a49/PowerShell/PowerShell/issues/23805
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/276d4b11253cf617bec23c84710164f289c62f4c79cc46ec4d2d006de0273a49/PowerShell/PowerShell/issues/23805
og:image:altPrerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemklement0
hostnamegithub.com
expected-hostnamegithub.com
None42d4967e3c8afca51ccac31f419a705af777226a95f025ea73387d87a306b326
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2329ceed0bc2c7b7c3b9f5f2db6abfc7b6fc3a50
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/23805#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F23805
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F23805
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/23805
Reloadhttps://github.com/PowerShell/PowerShell/issues/23805
Reloadhttps://github.com/PowerShell/PowerShell/issues/23805
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/23805
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/23805
Compare-Object doesn't compare custom value types (structs) (that don't implement IComparable) correctlyhttps://github.com/PowerShell/PowerShell/issues/23805#top
Needs-TriageThe issue is new and needs to be triaged by a work group.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Needs-Triage%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com/mklement0
Michael Klement (mklement0)https://github.com/mklement0
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#issue-2298085382
latest released versionhttps://github.com/PowerShell/PowerShell/releases
FAQhttps://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md
Differences between Windows PowerShell 5.1 and PowerShellhttps://learn.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell
Compare-Object doesn't respect IEquatable #12498https://github.com/PowerShell/PowerShell/issues/12498
Michael Klement (mklement0)https://github.com/mklement0
Needs-TriageThe issue is new and needs to be triaged by a work group.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Needs-Triage%22
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#event-12818821022
https://github.com/scriptingstudio
Matthew Gray (scriptingstudio)https://github.com/scriptingstudio
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#issuecomment-2113149314
https://github.com/mklement0
Michael Klement (mklement0)https://github.com/mklement0
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#issuecomment-2113206462
https://github.com/scriptingstudio
Matthew Gray (scriptingstudio)https://github.com/scriptingstudio
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#issuecomment-2113254013
https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/compare-object?view=powershell-7.4#inputshttps://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/compare-object?view=powershell-7.4#inputs
https://camo.githubusercontent.com/a795f917f169bc859cc037af2a703c620c8fc3323a3aef38c3aa68238fcc961a/68747470733a2f2f6c6561726e2e6d6963726f736f66742e636f6d2f6d656469612f6c6f676f732f6c6f676f2d706f7765727368656c6c2d736f6369616c2e706e67
Compare-Object (Microsoft.PowerShell.Utility) - PowerShellhttps://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/compare-object?view=powershell-7.4
https://github.com/mklement0
Michael Klement (mklement0)https://github.com/mklement0
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#issuecomment-2113293956
System.ValueTypehttps://learn.microsoft.com/en-US/dotnet/api/System.ValueType
Michael Klement (mklement0)https://github.com/mklement0
on May 15, 2024https://github.com/PowerShell/PowerShell/issues/23805#event-12824187734
Steven Bucher (StevenBucher98)https://github.com/StevenBucher98
WG-Cmdlets-Utilityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets-Utility%22
on May 20, 2024https://github.com/PowerShell/PowerShell/issues/23805#event-12869301432
Ryan Yates (kilasuit)https://github.com/kilasuit
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
WG-Cmdlets-Utilityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets-Utility%22
on Jul 17, 2026https://github.com/PowerShell/PowerShell/issues/23805#event-28138263007
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/23805
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/23805
Needs-TriageThe issue is new and needs to be triaged by a work group.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Needs-Triage%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.