Title: `NO_COLOR` implementation differs from the spec: also honors the variable if its value is empty · Issue #21198 · PowerShell/PowerShell · GitHub
Open Graph Title: `NO_COLOR` implementation differs from the spec: also honors the variable if its value is empty · Issue #21198 · PowerShell/PowerShell
X Title: `NO_COLOR` implementation differs from the spec: also honors the variable if its value is empty · Issue #21198 · PowerShell/PowerShell
Description: PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.
Open Graph Description: PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.
X Description: PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.
Opengraph URL: https://github.com/PowerShell/PowerShell
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`NO_COLOR` implementation differs from the spec: also honors the variable if its value is empty","articleBody":"### Prerequisites\r\n\r\n- [X] Write a descriptive title.\r\n- [X] Make sure you are able to repro it on the [latest released version](https://github.com/PowerShell/PowerShell/releases)\r\n- [X] Search the existing issues.\r\n- [X] Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md).\r\n- [X] Refer to [Differences between Windows PowerShell 5.1 and PowerShell](https://learn.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell).\r\n\r\n### Steps to reproduce\r\n\r\n\u003csup>Tangentially related: #21186\u003c/sup>\r\n\r\nThe https://no-color.org/ specification states (emphasis added):\r\n\r\n> should check for a `NO_COLOR` environment variable that, when present and _not an empty string_ (regardless of its value), prevents the addition of ANSI color.\r\n\r\nBy contrast, PowerShell currently bases its behavior purely on the _existence_ of this environment variable, and therefore also considers an _empty_ variable (one whose value is the empty string) as requesting color opt-out.\r\n\r\n```sh\r\n# Run from a POSIX-like shell, such as Bash\r\n\r\n# Non-empty value: OK \r\nNO_COLOR=1 pwsh -noprofile -c '$PSStyle.OutputRendering'\r\n\r\n# Empty value: !! Unexpectedly treated like a non-empty value.\r\nNO_COLOR= pwsh -noprofile -c '$PSStyle.OutputRendering'\r\n```\r\n\r\n----\r\n\r\nAs an aside:\r\n \r\n * What the spec prescribes doesn't align with common practice for flag-like environment variables on Unix-like platforms: usually, for variables whose value doesn't matter, it is just the _existence vs. non-existence_ that governs behavior. \r\n \r\n * The variant behavior does have one advantage, however: it allows calls such as `NO_COLOR= foo ...` (from POSIX-compatible shells) as an ad-hoc, child process-scoped _opt-out_ out of non-coloring, which would otherwise not be possible, as this syntax doesn't support _undefining_ (removing) environment variables ad hoc.\r\n\r\n\r\n\r\n### Expected behavior\r\n\r\n```console\r\nPlainText\r\nHost\r\n```\r\n\r\nThat is:\r\n\r\n* the existence of `NO_COLOR` with a _non-empty_ value should cause PowerShell to set `$PSStyle.OutputRendering` to `PlainText`\r\n* whereas an _empty_ value should not.\r\n\r\n### Actual behavior\r\n\r\n```console\r\nPlainText\r\nPlainText\r\n```\r\n\r\n\r\n### Error details\r\n\r\n_No response_\r\n\r\n### Environment data\r\n\r\n```powershell\r\nPowerShell 7.5.0-preview.1 on Unix-like platforms.\r\n```\r\n\r\n\r\n### Visuals\r\n\r\n_No response_","author":{"url":"https://github.com/mklement0","@type":"Person","name":"mklement0"},"datePublished":"2024-02-07T19:11:16Z","url":"https://github.com/PowerShell/PowerShell/issues/21198"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/issues/:id(.:format) |
| route-controller | issues |
| route-action | show |
| fetch-nonce | v2:8237d319-8061-342d-248c-f3aa296bfacb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9AE6:31688C:6BDC3:9419B:6AFD3D0A |
| html-safe-nonce | 58b9b353e94973eb1b09e4e38f6e94c98e9c51e0516c20591c9a4a89805e24fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUU2OjMxNjg4Qzo2QkRDMzo5NDE5Qjo2QUZEM0QwQSIsInZpc2l0b3JfaWQiOiI0MDgzODM4ODkwMzQ1ODM5ODgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c53ccec7da021c5f0f4dc7f13c4d87fcc7ab601763b77fbb2acd56dda17f8d42 |
| hovercard-subject-tag | repository:49609581 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/issues/21198 |
| twitter:image | https://repository-images.githubusercontent.com/49609581/aad0ad80-cdec-11ea-8248-a37bc0571bfd |
| twitter:card | summary_large_image |
| og:image | https://repository-images.githubusercontent.com/49609581/aad0ad80-cdec-11ea-8248-a37bc0571bfd |
| og:image:alt | PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | bdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474 |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 556dd37bb0aceffb25724e151b5d858b3265b40b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width