René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use correct exceptions","articleBody":"### Summary of the new feature / enhancement\n\nIn PowerShell code base there are some places where we are not accurate with exceptions.\r\nTypical example: https://github.com/PowerShell/PowerShell/blob/4314e634cadde65a743d359106def376ed1c59ee/src/System.Management.Automation/engine/CommandInfo.cs#L286-L294\r\n\r\nHere we throw ArgumentNullException that is not correct if the argument is empty. (There are examples with other exceptions.)\r\n\r\nMy proposal is to fix such code and throw ArgumentNullException if argument is null and ArgumentException is argument is empty.\r\n\r\nThis is not even a breaking change, as it is not a functional exception, and it is worth correcting it for the correct one. If someone even uses this behavior in their code, it is catastrophically bad code.\r\n\r\nThe proposal  comes from the fact that we are blocked from using new .Net API like ArgumentException.ThrowIfNullOrEmpty(). The API makes code more friendly for .Net Rumtime optimizations (like inlining). We already use this kind of API in a lot of places and it's worth updating the rest.\n\n### Proposed technical implementation details (optional)\n\n_No response_","author":{"url":"https://github.com/iSazonov","@type":"Person","name":"iSazonov"},"datePublished":"2023-02-24T15:26:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/19212/PowerShell/issues/19212"}