René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Investigate possible BUG Invoke-WebRequest content type charset","articleBody":"### Prerequisites\r\n\r\n- [X] Write a descriptive title.\r\n- [X] Make sure you are able to repro it on the [latest released version](https://github.com/PowerShell/PowerShell/releases)\r\n- [X] Search the existing issues.\r\n- [X] Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md).\r\n- [X] Refer to [Differences between Windows PowerShell 5.1 and PowerShell](https://docs.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell).\r\n\r\n### Steps to reproduce\r\n\r\nInvoke-WebRequest POST with -Body (string) and -Headers containing a content type with charset (ex. plain/text; charset=\"windows-1251\") and no -ContentType.\r\n\r\n```ps1\r\nInvoke-WebRequest -URI \"some uri\" -Method POST -Headers @{Content-Type=\"plain/text; charset=windows-1251\"} -Body \"string encoded with windows-1251 charset\"\r\n```\r\n\r\nThe charset in the headers are ignored be ignored and default to UTF8.\r\nThis doesn't happen if we use -ContentType\r\n\r\n```ps1\r\nInvoke-WebRequest -URI \"some uri\" -Method POST -ContentType \"plain/text; charset=windows-1251\" -Body \"string encoded with windows-1251 charset\"\r\n```\r\n\r\nBoth should have the same behaviour\r\n\r\nI found this possible bug while reading the code; I haven't encountered it in the real world so I don't really know how we could test it (and if testing it is even possible)\r\n\r\n### Expected behavior\r\n\r\n```console\r\nSetRequestContent should try to get the charset from the ContentType in Headers saved in the WebSession\r\nWebSession.ContentHeaders[HttpKnownHeaderNames.ContentType]\r\n```\r\n\r\n\r\n### Actual behavior\r\n\r\n```console\r\nSetRequestContent only checks for -ContentType charset\r\n```\r\n\r\n\r\n### Error details\r\n\r\n```console\r\nWhile writing some code in `WebRequestPSCmdlet.Common.cs` think I found a BUG (line 1491) it should check for `WebSession.ContentHeaders[HttpKnownHeaderNames.ContentType]` instead of `ContentType` (this should be ok because if both are present `ContentType` overwrites `WebSession.ContentHeaders[HttpKnownHeaderNames.ContentType]`) unfortunately I don't know how to test it (I think it would require sending a wierdily encoded string as Body), if confirmed I'll open another PR to fix it.\r\n```\r\n\r\n\r\n### Environment data\r\n\r\n```powershell\r\nLatest master\r\nhttps://github.com/PowerShell/PowerShell/blob/60b4e9704fca546f76e1128e30de4077c51a3ca2/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs\r\n```\r\n\r\n\r\n### Visuals\r\n\r\n_No response_","author":{"url":"https://github.com/CarloToso","@type":"Person","name":"CarloToso"},"datePublished":"2023-02-15T09:11:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":22},"url":"https://github.com/19156/PowerShell/issues/19156"}