René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Apparently unused code WebRequestPSCmdlet.Common.cs","articleBody":"### Summary of the new feature / enhancement\r\n\r\nI was working on the WebCmdlets trying to understand how to fix issue #2896 and it seems that lines 1380-1406 in WebRequestPSCmdlet.Common.cs are never used\r\n\r\n```cs\r\n                if (keepAuthorization \u0026\u0026 IsRedirectCode(response.StatusCode) \u0026\u0026 response.Headers.Location != null)\r\n                {\r\n                    _cancelToken.Cancel();\r\n                    _cancelToken = null;\r\n\r\n                    // if explicit count was provided, reduce it for this redirection.\r\n                    if (WebSession.MaximumRedirection \u003e 0)\r\n                    {\r\n                        WebSession.MaximumRedirection--;\r\n                    }\r\n                    // For selected redirects that used POST, GET must be used with the\r\n                    // redirected Location.\r\n                    // Since GET is the default; POST only occurs when -Method POST is used.\r\n                    if (Method == WebRequestMethod.Post \u0026\u0026 IsRedirectToGet(response.StatusCode))\r\n                    {\r\n                        // See https://msdn.microsoft.com/library/system.net.httpstatuscode(v=vs.110).aspx\r\n                        Method = WebRequestMethod.Get;\r\n                    }\r\n\r\n                    currentUri = new Uri(request.RequestUri, response.Headers.Location);\r\n                    // Continue to handle redirection\r\n                    using (client = GetHttpClient(handleRedirect: true))\r\n                    using (HttpRequestMessage redirectRequest = GetRequest(currentUri))\r\n                    {\r\n                        response = GetResponse(client, redirectRequest, keepAuthorization);\r\n                    }\r\n                }\r\n```\r\n\r\nAll the redirects are resolved in line 1378\r\n\r\n``` cs\r\nresponse = client.SendAsync(req, HttpCompletionOption.ResponseHeadersRead, _cancelToken.Token).GetAwaiter().GetResult();\r\n```\r\n\r\n### Proposed technical implementation details (optional)\r\n\r\nI think lines 1380-1406 could be repurposed to follow HTTP redirects from HTTPS. Unfortunately I encountered some issues with the `-MaximumRedirection` flag. \r\nCan someone test if those lines are actually never used?\r\nDoes someone know how to check how many redirects are resolved in line 1378?\r\n\r\nSample code that follows HTTPS-\u003eHTTP redirects but can't stop at `-MaximumRedirection` flag\r\n```cs\r\n          if (WebSession.MaximumRedirection \u003e 0 \u0026\u0026 IsRedirectCode(response.StatusCode) \u0026\u0026 response.Headers.Location != null)\r\n                {\r\n                    _cancelToken.Cancel();\r\n                    _cancelToken = null;\r\n\r\n                    // if explicit count was provided, reduce it for this redirection.\r\n                    if (WebSession.MaximumRedirection \u003e 0)\r\n                    {\r\n                        WebSession.MaximumRedirection--;\r\n                    }\r\n                    // For selected redirects that used POST, GET must be used with the\r\n                    // redirected Location.\r\n                    // Since GET is the default; POST only occurs when -Method POST is used.\r\n                    if (Method == WebRequestMethod.Post \u0026\u0026 IsRedirectToGet(response.StatusCode))\r\n                    {\r\n                        // See https://msdn.microsoft.com/library/system.net.httpstatuscode(v=vs.110).aspx\r\n                        Method = WebRequestMethod.Get;\r\n                    }\r\n\r\n                    currentUri = new Uri(request.RequestUri, response.Headers.Location);\r\n                    // Continue to handle redirection\r\n                    using (client = GetHttpClient(handleRedirect: true))\r\n                    using (HttpRequestMessage redirectRequest = GetRequest(currentUri))\r\n                    {\r\n                        response = GetResponse(client, redirectRequest, keepAuthorization);\r\n                    }\r\n                }\r\n```","author":{"url":"https://github.com/CarloToso","@type":"Person","name":"CarloToso"},"datePublished":"2022-11-12T03:32:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/18541/PowerShell/issues/18541"}