René's URL Explorer Experiment


Title: High cpu usage when parsing scripts that include [ordered] · Issue #17308 · PowerShell/PowerShell · GitHub

Open Graph Title: High cpu usage when parsing scripts that include [ordered] · Issue #17308 · PowerShell/PowerShell

X Title: High cpu usage when parsing scripts that include [ordered] · Issue #17308 · PowerShell/PowerShell

Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerShell 5.1 and PowerShell. Steps to reprodu...

Open Graph Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...

X Description: Prerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/17308

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"High cpu usage when parsing scripts that include [ordered]","articleBody":"### Prerequisites\r\n\r\n- [X] Write a descriptive title.\r\n- [X] Make sure you are able to repro it on the [latest released version](https://github.com/PowerShell/PowerShell/releases)\r\n- [X] Search the existing issues.\r\n- [X] Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md).\r\n- [X] Refer to [Differences between Windows PowerShell 5.1 and PowerShell](https://docs.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell).\r\n\r\n### Steps to reproduce\r\n\r\nWe are parsing multiple powershell scripts in parallel using Parser.ParseInput but are having issues with perf when the scrips being parsed includes multiple [ordered] attributes/types.\r\n\r\nThe parser starts to use 100% cpu, and it takes a long time for the parsing to complete.\r\n\r\n[Repro here](https://github.com/Sjark/PowershellParsingIssue)\r\n\r\nThe console app above has 2 identical powershell scripts included, the only difference is that on of them has a bunch of [ordered] before the hashtable assignments.\r\n\r\nThe one without [ordered] completes almost instantly, while the one with [ordered] takes some time and uses a lot of cpu.\r\n\r\n### Expected behavior\r\n\r\n```console\r\nParsing to complete in about the same time with both scripts.\r\n```\r\n\r\n\r\n### Actual behavior\r\n\r\n```console\r\nParsing takes a lot longer and uses a lot more resources when the script includes [ordered].\r\n```\r\n\r\n\r\n### Error details\r\n\r\nThe error seems to be related to `LookForTypeInAssemblies` method within the TypeResolver.cs:68\r\n\r\nEvery time it finds a [ordered] in the script it goes through all loaded assemblies to try and find the matching type, but since [ordered] is not actually a type (just a helper for creating `System.Collections.Specialized.OrderedDictionary`) the method returns null, and will search again the next time it finds an [ordered] attribute.\r\n\r\nI think there should either be a cache for types that did not match any assemblies, so that it doesn't have to look through the same assemblies for the same type multiple times, or there should be a special case for [ordered] so that it does not even try to search through the assemblies for it.\r\n\r\n\r\n### Environment data\r\n\r\n```powershell\r\nWe are using nuget package: System.Management.Automation version 7.2.3\r\n```\r\n\r\n\r\n### Visuals\r\n\r\n_No response_","author":{"url":"https://github.com/Sjark","@type":"Person","name":"Sjark"},"datePublished":"2022-05-11T07:37:18Z","url":"https://github.com/PowerShell/PowerShell/issues/17308"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7dc79dfe-de34-c5d6-0787-6f16279e22ca
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDA22:1EB498:AC75A3:F92D88:6AFDA418
html-safe-nonce743fd8ee3265e017688194c29dfd8d53cccf20dee612dc91074f56a68cced975
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTIyOjFFQjQ5ODpBQzc1QTM6RjkyRDg4OjZBRkRBNDE4IiwidmlzaXRvcl9pZCI6IjEwMTIzOTQ1OTU5OTgwODIwNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac22a72449b0a05ee040f41df0917033165e8c802e0dccb109ddba88f7e7b330f3
hovercard-subject-tagissue:1232146852
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/17308/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6a953209b90346b65a0c2aa97c30c51024c645623ed36aba120f9f58d307acd2/PowerShell/PowerShell/issues/17308
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a953209b90346b65a0c2aa97c30c51024c645623ed36aba120f9f58d307acd2/PowerShell/PowerShell/issues/17308
og:image:altPrerequisites Write a descriptive title. Make sure you are able to repro it on the latest released version Search the existing issues. Refer to the FAQ. Refer to Differences between Windows PowerSh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSjark
hostnamegithub.com
expected-hostnamegithub.com
Nonebc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0ddf53eb35c87f1f8df13dbf75c3bdadbfc6e969
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/17308#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F17308
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F17308
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/17308
Reloadhttps://github.com/PowerShell/PowerShell/issues/17308
Reloadhttps://github.com/PowerShell/PowerShell/issues/17308
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/17308
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/17308
High cpu usage when parsing scripts that include [ordered]https://github.com/PowerShell/PowerShell/issues/17308#top
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Engine-Performancecore PowerShell engine, interpreter, and runtime performancehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine-Performance%22
https://github.com/Sjark
Lasse Meland (Sjark)https://github.com/Sjark
on May 11, 2022https://github.com/PowerShell/PowerShell/issues/17308#issue-1232146852
latest released versionhttps://github.com/PowerShell/PowerShell/releases
FAQhttps://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md
Differences between Windows PowerShell 5.1 and PowerShellhttps://docs.microsoft.com/powershell/scripting/whats-new/differences-from-windows-powershell
Repro herehttps://github.com/Sjark/PowershellParsingIssue
Lasse Meland (Sjark)https://github.com/Sjark
Needs-TriageThe issue is new and needs to be triaged by a work group.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Needs-Triage%22
on May 11, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6587654944
https://github.com/vexx32
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
on May 11, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1124369937
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
WG-Engine-Performancecore PowerShell engine, interpreter, and runtime performancehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine-Performance%22
on May 11, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6594105280
https://github.com/SeeminglyScience
Patrick Meinecke (SeeminglyScience)https://github.com/SeeminglyScience
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125111171
https://github.com/vexx32
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125273899
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125295150
https://github.com/SeeminglyScience
Patrick Meinecke (SeeminglyScience)https://github.com/SeeminglyScience
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125362551
https://github.com/Sjark
Lasse Meland (Sjark)https://github.com/Sjark
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125364759
https://github.com/SeeminglyScience
Patrick Meinecke (SeeminglyScience)https://github.com/SeeminglyScience
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125369102
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125375449
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6601229118
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1125459917
#17804https://github.com/PowerShell/PowerShell/pull/17804
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Needs-TriageThe issue is new and needs to be triaged by a work group.https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Needs-Triage%22
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6601633316
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Mathias R. Jessen (IISResetMe)https://github.com/IISResetMe
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 12, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6601634615
Mathias R. Jessen (IISResetMe)https://github.com/IISResetMe
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Mathias R. Jessen (IISResetMe)https://github.com/IISResetMe
on May 13, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-6604570314
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on May 17, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1129101905
#17328https://github.com/PowerShell/PowerShell/pull/17328
https://github.com/Sjark
Lasse Meland (Sjark)https://github.com/Sjark
on May 17, 2022https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1129356130
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
on Aug 3, 2022https://github.com/PowerShell/PowerShell/issues/17308#event-7121233480
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 15, 2023https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1811661286
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
on Nov 15, 2023https://github.com/PowerShell/PowerShell/issues/17308#event-10961865011
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 22, 2023https://github.com/PowerShell/PowerShell/issues/17308#issuecomment-1822553819
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
completedhttps://github.com/PowerShell/PowerShell/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 22, 2023https://github.com/PowerShell/PowerShell/issues/17308#event-11035023640
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/17308
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/17308
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Engine-Performancecore PowerShell engine, interpreter, and runtime performancehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Engine-Performance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.