René's URL Explorer Experiment


Title: Design Issues in Unix versions of Stop/Restart-Computer cmdlets · Issue #12482 · PowerShell/PowerShell · GitHub

Open Graph Title: Design Issues in Unix versions of Stop/Restart-Computer cmdlets · Issue #12482 · PowerShell/PowerShell

X Title: Design Issues in Unix versions of Stop/Restart-Computer cmdlets · Issue #12482 · PowerShell/PowerShell

Description: Code PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Lines 1 to 159 in b7cb335 // Copyright (c) Microsoft Corporation. // Licensed under the MIT License. #if UNIX using System; using System.Dia...

Open Graph Description: Code PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Lines 1 to 159 in b7cb335 // Copyright (c) Microsoft Corporation. // Licensed under the MIT License....

X Description: Code PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Lines 1 to 159 in b7cb335 // Copyright (c) Microsoft Corporation. // Licensed under the MIT License....

Opengraph URL: https://github.com/PowerShell/PowerShell/issues/12482

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Issues in Unix versions of Stop/Restart-Computer cmdlets","articleBody":"# Code\r\n\r\nhttps://github.com/PowerShell/PowerShell/blob/b7cb335f03fe2992d0cbd61699de9d9aafa1d7c1/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs#L1-L159\r\n\r\nI have several questions on these cmdlets... Below is a summarised list of issues with the current code.\r\n\r\n## 1. There is no null check for `_process.Dispose()` in the cmdlets' `Dispose()` methods\r\n\r\n... despite the fact that the test hook quite clearly prevents `_process` from ever being set if it's enabled. I'm almost as confused by this as I am by the fact that this doesn't make tests fail -- I suspect it's simply taking long enough to call its Dispose() method that the test it was executing inside of has already completed and the error goes unnoticed.\r\n\r\n## 2. The internal `RunCommand()` method has multiple design issues\r\n\r\nThe parameters it exposes are _never used_, and it uses hardcoded values instead.As a result, the different parameters provided by `Stop-Computer` and `Restart-Computer` are completely ignored, and thus the two commands do the exact same thing.\r\n\r\n## 3. The testing method.\r\n\r\nI acknowledge that it is rather difficult to test stopping/restarting a computer without causing interruptions in the test pipeline, but the current state of tests simply don't test _anything_ apart from basic parameter binding, since all other functionality in the cmdlet is completely skipped when the test hook is enabled.\r\n\r\nWe need a more robust way of testing these cmdlets; I think the lack of adequate tests is part of the reason the issues in these cmdlets went unnoticed.\r\n\r\n## 4. `IDisposable` is not implemented properly\r\n\r\nAccording to the documented [recommended pattern](https://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose) there are two additional members that should be implemented as part of the IDisposable pattern, so that multiple calls to Dispose() effectively no-op after the first call.\r\n\r\n# Related Issues/PRs\r\n\r\n#5448 and #11151\r\n\r\n---\r\n\r\nThis code is still present in the current master branch of the repo and was included in 7.1-preview1, but it's still very much unfinished. Are there plans to finish it, at least to a minimum viable product?","author":{"url":"https://github.com/vexx32","@type":"Person","name":"vexx32"},"datePublished":"2020-04-24T19:34:41Z","url":"https://github.com/PowerShell/PowerShell/issues/12482"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1839ea44-1f5e-a001-a1d3-138d32de47c8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC11C:1D853F:668E3:8AACB:6AFD48C5
html-safe-noncecaac7cf81f34a65214444853f8aa6f0b685d0a05a1847e06b951b489d5af357b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTFDOjFEODUzRjo2NjhFMzo4QUFDQjo2QUZENDhDNSIsInZpc2l0b3JfaWQiOiI5MTgzNDI0MDk2ODU4MDk3ODYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacca67cdcd891143884d4733e89b0ea5c97f41da6a01199fcf3045ce5fb26cb7eb
hovercard-subject-tagissue:606536652
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShell/12482/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b710460d1484fc3cfe5ee73573d3c024bf74ecc4684a15812583c9ff40a494b0/PowerShell/PowerShell/issues/12482
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b710460d1484fc3cfe5ee73573d3c024bf74ecc4684a15812583c9ff40a494b0/PowerShell/PowerShell/issues/12482
og:image:altCode PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Lines 1 to 159 in b7cb335 // Copyright (c) Microsoft Corporation. // Licensed under the MIT License....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevexx32
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/issues/12482#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F12482
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F12482
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/issues/12482
Reloadhttps://github.com/PowerShell/PowerShell/issues/12482
Reloadhttps://github.com/PowerShell/PowerShell/issues/12482
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/12482
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/12482
Design Issues in Unix versions of Stop/Restart-Computer cmdletshttps://github.com/PowerShell/PowerShell/issues/12482#top
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Code%20Cleanup%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com/vexx32
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
on Apr 24, 2020https://github.com/PowerShell/PowerShell/issues/12482#issue-606536652
PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cshttps://github.com/PowerShell/PowerShell/blob/b7cb335f03fe2992d0cbd61699de9d9aafa1d7c1/src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs#L1-L159
b7cb335https://github.com/PowerShell/PowerShell/commit/b7cb335f03fe2992d0cbd61699de9d9aafa1d7c1
recommended patternhttps://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose
#5448https://github.com/PowerShell/PowerShell/issues/5448
#11151https://github.com/PowerShell/PowerShell/pull/11151
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get ahttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Question%22
Area-Cmdlets-Managementhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Area-Cmdlets-Management%22
on Apr 24, 2020https://github.com/PowerShell/PowerShell/issues/12482#event-3270765084
Ilya (iSazonov)https://github.com/iSazonov
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Code%20Cleanup%22
Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get ahttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Question%22
on Jan 16, 2021https://github.com/PowerShell/PowerShell/issues/12482#event-4213934819
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/12482#issuecomment-1813723499
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/12482#issuecomment-1813723500
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/12482#issuecomment-1813723501
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
on Nov 16, 2023https://github.com/PowerShell/PowerShell/issues/12482#event-10974953199
https://github.com/apps/microsoft-github-policy-service
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
on Nov 23, 2023https://github.com/PowerShell/PowerShell/issues/12482#issuecomment-1824313291
Microsoft GitHub Policy Servicehttps://aka.ms/1es-gitops
microsoft-github-policy-servicehttps://github.com/apps/microsoft-github-policy-service
completedhttps://github.com/PowerShell/PowerShell/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 23, 2023https://github.com/PowerShell/PowerShell/issues/12482#event-11046806560
Ryan Yates (kilasuit)https://github.com/kilasuit
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
WG-Cmdlets-Managementhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets-Management%22
on Jul 17, 2026https://github.com/PowerShell/PowerShell/issues/12482#event-28145656993
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PowerShell/issues/12482
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PowerShell/issues/12482
Issue-BugIssue has been identified as a bug in the producthttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Bug%22
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityhttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Issue-Code%20Cleanup%22
Resolution-No ActivityIssue has had no activity for 6 months or morehttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Resolution-No%20Activity%22
WG-Cmdletsgeneral cmdlet issueshttps://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22WG-Cmdlets%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.