René's URL Explorer Experiment


Title: Trigger AvoidPositionalParameters rule for function defined and called inside a script. by kalgiz · Pull Request #963 · PowerShell/PSScriptAnalyzer · GitHub

Open Graph Title: Trigger AvoidPositionalParameters rule for function defined and called inside a script. by kalgiz · Pull Request #963 · PowerShell/PSScriptAnalyzer

X Title: Trigger AvoidPositionalParameters rule for function defined and called inside a script. by kalgiz · Pull Request #963 · PowerShell/PSScriptAnalyzer

Description: PR Summary Trigger AvoidPositionalParameters rule for function defined and called inside a script. fixes: #893 The rule doesn't trigger for the function defined and called in the script, because the script is not run and the function definition is not added to the powershell session runspace. Hence, the called function is not recognized as Cmdlet. For the temporary solution I pull the function definitions from the script, store them and search these function calls for positional parameters. PR Checklist Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA. PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes User facing documentation needed Change is not breaking Make sure you've added a new test if existing tests do not effectively test the code changed This PR is ready to merge and is not work in progress If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Open Graph Description: PR Summary Trigger AvoidPositionalParameters rule for function defined and called inside a script. fixes: #893 The rule doesn't trigger for the function defined and called in the script, becaus...

X Description: PR Summary Trigger AvoidPositionalParameters rule for function defined and called inside a script. fixes: #893 The rule doesn't trigger for the function defined and called in the script, be...

Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/pull/963

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a6b3458a-eb6e-d4bd-636e-02253e383d37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D1E:357787:6CB8DA:9478AD:6AFD120F
html-safe-nonce5b95a27be8db5bd847e4732f3a7e794f2e081fcab7d2436e42fc2721544f9f93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDFFOjM1Nzc4Nzo2Q0I4REE6OTQ3OEFEOjZBRkQxMjBGIiwidmlzaXRvcl9pZCI6IjE0NDE0NjI0OTQ1ODgzNzU1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac723efe0fc4d24b28cfadc6ebede5629eda157075f7dd695137d95ebcda6bf1c6
hovercard-subject-tagpull_request:180020975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
twitter:imagehttps://avatars.githubusercontent.com/u/7048436?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7048436?s=400&v=4
og:image:altPR Summary Trigger AvoidPositionalParameters rule for function defined and called inside a script. fixes: #893 The rule doesn't trigger for the function defined and called in the script, becaus...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7c34e25df4e46e972c8f0225e63410231bdeb9ea5634597c712796bbcdb2e627
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id33149177
octolytics-dimension-repository_nwoPowerShell/PSScriptAnalyzer
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33149177
octolytics-dimension-repository_network_root_nwoPowerShell/PSScriptAnalyzer
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8fa571ebaa95e4e6bf872197c0e84b7dc48e6785
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F963%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F963%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
PowerShellhttps://github.com/PowerShell
PSScriptAnalyzerhttps://github.com/PowerShell/PSScriptAnalyzer
Codehttps://github.com/PowerShell/PSScriptAnalyzer
Issues407 (407)https://github.com/PowerShell/PSScriptAnalyzer/issues
Pull requests34 (34)https://github.com/PowerShell/PSScriptAnalyzer/pulls
Discussionshttps://github.com/PowerShell/PSScriptAnalyzer/discussions
Actionshttps://github.com/PowerShell/PSScriptAnalyzer/actions
Projectshttps://github.com/PowerShell/PSScriptAnalyzer/projects
Wikihttps://github.com/PowerShell/PSScriptAnalyzer/wiki
Security and qualityhttps://github.com/PowerShell/PSScriptAnalyzer/security
Insightshttps://github.com/PowerShell/PSScriptAnalyzer/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
PowerShell:developmenthttps://github.com/PowerShell/PSScriptAnalyzer/tree/development
kalgiz:positional-parameter-bug-fixhttps://github.com/kalgiz/PSScriptAnalyzer/tree/positional-parameter-bug-fix
Conversation 32 https://github.com/PowerShell/PSScriptAnalyzer/pull/963
Commits 11 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits
Checks 0 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/checks
Files changed https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Trigger AvoidPositionalParameters rule for function defined and called inside a script. https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#top
Show all changes 11 commits https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
7f04508 Trigger AvoidPositionalParameters rule for function defined and calle… kalgiz Apr 6, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/7f04508f3af7beb951794be3685e00697b5f671e
b3c577e Get rid of debug print. kalgiz Apr 6, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/b3c577e2b6c945a498a86b91d4a1ff186994c27a
365b516 Tests fpr PSAvoidPOsitionalParameters rule. kalgiz Apr 6, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/365b5166d148518c845048686eb6d23f80f4accb
5f0f90d Tests for AvoidPositionalParameters rule fixes. kalgiz Apr 9, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/5f0f90dbf79bd2857ff0edea3bcfde956e8ad7b2
1a2f9fe Counting positional parameters fix. kalgiz Apr 11, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/1a2f9fe89ecb1edc1c4162b5cd80d00bc4044852
29f5017 Code cleanup for AvoidPositionalParameter rule fix. kalgiz Apr 11, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/29f5017120de0ccf4c9737ca8a89d50ee66b63a1
956fcde Trigger AvoidPositionalParameters rule for function defined and calle… kalgiz Apr 6, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/956fcde72d66f6207e52624c9e0c50ac23f44813
014dd71 Tests fpr PSAvoidPOsitionalParameters rule. kalgiz Apr 6, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/014dd71ed6cc4a87605ba46b06383aa18ceb8792
147b16f Counting positional parameters fix. kalgiz Apr 11, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/147b16f3b7396c79a4e62562421689f64c965854
b60f00d Tests fixes for AvoidPositionalParameters rule. kalgiz Apr 12, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/b60f00dc86b75fab975c1c421b78bccadd97219f
479fbc4 Code cleanup kalgiz May 17, 2018 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/commits/479fbc4c542579325e8bca0dd0e87d4ded0cbc2b
Clear filters https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
Helper.cs https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
AvoidPositionalParameters.cs https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
UseCmdletCorrectly.cs https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-3d83abb0ae7bdd066fa2620b4fff6e2c9951994002826b9ad97a8af00b11eada
AvoidPositionalParameters.tests.ps1 https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-2adcf1cbcd88353b90cfb1cd942489a0f04e756b47bf6c70de3f079bffbbb48e
Engine/Helper.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
View file https://github.com/kalgiz/PSScriptAnalyzer/blob/479fbc4c542579325e8bca0dd0e87d4ded0cbc2b/Engine/Helper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
Klaudia Algiz (kalgiz)https://github.com/kalgiz
Apr 6, 2018https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#r179873440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
Rules/AvoidPositionalParameters.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
View file https://github.com/kalgiz/PSScriptAnalyzer/blob/479fbc4c542579325e8bca0dd0e87d4ded0cbc2b/Rules/AvoidPositionalParameters.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
Rules/UseCmdletCorrectly.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-3d83abb0ae7bdd066fa2620b4fff6e2c9951994002826b9ad97a8af00b11eada
View file https://github.com/kalgiz/PSScriptAnalyzer/blob/479fbc4c542579325e8bca0dd0e87d4ded0cbc2b/Rules/UseCmdletCorrectly.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-3d83abb0ae7bdd066fa2620b4fff6e2c9951994002826b9ad97a8af00b11eada
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-3d83abb0ae7bdd066fa2620b4fff6e2c9951994002826b9ad97a8af00b11eada
Tests/Rules/AvoidPositionalParameters.tests.ps1https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-2adcf1cbcd88353b90cfb1cd942489a0f04e756b47bf6c70de3f079bffbbb48e
View file https://github.com/kalgiz/PSScriptAnalyzer/blob/479fbc4c542579325e8bca0dd0e87d4ded0cbc2b/Tests/Rules/AvoidPositionalParameters.tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/963/files#diff-2adcf1cbcd88353b90cfb1cd942489a0f04e756b47bf6c70de3f079bffbbb48e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.