| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:02b74b0b-7c1a-2b6f-fa70-b5e81460167c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5CC:1E3D51:61443:85DE9:6AFCFCF0 |
| html-safe-nonce | 1d8851fbef424d6316bc3fcb35f41597ab62da083974711e0516f05fcc2d2531 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUNDOjFFM0Q1MTo2MTQ0Mzo4NURFOTo2QUZDRkNGMCIsInZpc2l0b3JfaWQiOiI3OTU0MjEwOTYzNjE4MzMxODg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e81e9524cf7c3e3383d22ff7d2a3ed5f33b350e6e28970538b06353e08325d39 |
| hovercard-subject-tag | pull_request:175114163 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PSScriptAnalyzer/935/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/111471e6574b0bbd9cbdeff9fe746003bce54e79dbacaa7c77b7bd306be96a61/PowerShell/PSScriptAnalyzer/pull/935 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/111471e6574b0bbd9cbdeff9fe746003bce54e79dbacaa7c77b7bd306be96a61/PowerShell/PSScriptAnalyzer/pull/935 |
| og:image:alt | PR Summary
Hooray, this is the fix for the most common false positive of PSSA.
The main issue was that it was treating += as assignment. There are more special cases that need to be looked at like ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bergmeister |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfabad6ee26d2b84c7afef4ae0cc71b8b692fb9d66f9f15997652ef991bfd3f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 33149177 |
| octolytics-dimension-repository_nwo | PowerShell/PSScriptAnalyzer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33149177 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PSScriptAnalyzer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 35f85b78676038389558a41adf8d76e474592ede |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F935 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F935 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| PowerShell | https://github.com/PowerShell |
| PSScriptAnalyzer | https://github.com/PowerShell/PSScriptAnalyzer |
| Code | https://github.com/PowerShell/PSScriptAnalyzer |
| Issues407 (407) | https://github.com/PowerShell/PSScriptAnalyzer/issues |
| Pull requests34 (34) | https://github.com/PowerShell/PSScriptAnalyzer/pulls |
| Discussions | https://github.com/PowerShell/PSScriptAnalyzer/discussions |
| Actions | https://github.com/PowerShell/PSScriptAnalyzer/actions |
| Projects | https://github.com/PowerShell/PSScriptAnalyzer/projects |
| Wiki | https://github.com/PowerShell/PSScriptAnalyzer/wiki |
| Security and quality | https://github.com/PowerShell/PSScriptAnalyzer/security |
| Insights | https://github.com/PowerShell/PSScriptAnalyzer/insights |
| https://github.com/PowerShell/PSScriptAnalyzer |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| PowerShell:development | https://github.com/PowerShell/PSScriptAnalyzer/tree/development |
| bergmeister:UseDeclaredVarsMoreThanAssignments_FixFalsePositives | https://github.com/bergmeister/PSScriptAnalyzer/tree/UseDeclaredVarsMoreThanAssignments_FixFalsePositives |
| Conversation | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Commits5 (5) | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits |
| Checks | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/checks |
| Files changed | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files |
| Fix PSUseDeclaredVarsMoreThanAssignments to not give false positives when using += operator | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#top |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| PowerShell:development | https://github.com/PowerShell/PSScriptAnalyzer/tree/development |
| bergmeister:UseDeclaredVarsMoreThanAssignments_FixFalsePositives | https://github.com/bergmeister/PSScriptAnalyzer/tree/UseDeclaredVarsMoreThanAssignments_FixFalsePositives |
|
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Mar 14, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#issue-305367139 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| #699 | https://github.com/PowerShell/PSScriptAnalyzer/issues/699 |
| #827 | https://github.com/PowerShell/PSScriptAnalyzer/issues/827 |
| #903 | https://github.com/PowerShell/PSScriptAnalyzer/issues/903 |
| PowerShell/vscode-powershell#776 | https://github.com/PowerShell/vscode-powershell/issues/776 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| March 14, 2018 22:41 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#commits-pushed-c9f97de |
|
| https://github.com/bergmeister |
| fix false positives such as '$a=@(); $b | foreach-object { $a+=$c}' b… | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/c9f97de464f07f1e69ea4fd70f6019339d7c6b55 |
| c9f97de | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/c9f97de464f07f1e69ea4fd70f6019339d7c6b55 |
|
| https://github.com/bergmeister |
| add test (it turns out a regression happened for 'flags strongly type… | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/7daf5a4fdb9f639e8b4eb37e4d3f676c59ab9603 |
| 7daf5a4 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/7daf5a4fdb9f639e8b4eb37e4d3f676c59ab9603 |
|
| https://github.com/bergmeister |
| fix regression for strongly typed variables by being more selective a… | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/bc1c0079cd2dd3cc0c0c7dc35fc8c363cd325ce9 |
| bc1c007 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/bc1c0079cd2dd3cc0c0c7dc35fc8c363cd325ce9 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
|
Issue - Bug
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20Bug%22 |
|
Area - Rules
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20Rules%22 |
| Mar 14, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1522195379 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| 1.17 | https://github.com/PowerShell/PSScriptAnalyzer/milestone/20 |
| Mar 14, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1522195381 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Mar 14, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1522195382 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| March 14, 2018 23:42 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1522195389 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
|
in progress
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
|
Area - PSUseDeclaredVarsMoreThanAssignments
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20PSUseDeclaredVarsMoreThanAssignments%22 |
|
in progress
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Mar 14, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1522195477 |
| https://github.com/JamesWTruher |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
|
Mar 16, 2018
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935#pullrequestreview-104689551 |
|
View reviewed changes
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files/bc1c0079cd2dd3cc0c0c7dc35fc8c363cd325ce9 |
| Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files/bc1c0079cd2dd3cc0c0c7dc35fc8c363cd325ce9#diff-c3a9e2c8611b9a5f523851b5c888234fdb67c35368374fb4d7a03e46231f047e |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| Mar 16, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#discussion_r175191231 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Mar 16, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#discussion_r175230653 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| https://github.com/JamesWTruher |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
|
Mar 16, 2018
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935#pullrequestreview-104689695 |
|
View reviewed changes
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files/bc1c0079cd2dd3cc0c0c7dc35fc8c363cd325ce9 |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935#pullrequestreview-104689695 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| March 16, 2018 22:55 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#commits-pushed-077d035 |
|
| https://github.com/bergmeister |
| add additional test case for unassigned variable | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/077d0353bda9417a696d052ea7e17c3a4cd23fb0 |
| 077d035 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/077d0353bda9417a696d052ea7e17c3a4cd23fb0 |
|
| https://github.com/bergmeister |
| Merge branch 'development' of | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/647efe7d9017ff6b03b459e2fb642913890f6119 |
| https://github.com/PowerShell/PSScriptA… | https://github.com/PowerShell/PSScriptAnalyzer |
| 647efe7 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935/commits/647efe7d9017ff6b03b459e2fb642913890f6119 |
| …nalyzer | https://github.com/PowerShell/PSScriptAnalyzer |
| https://github.com/JamesWTruher |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
|
Mar 30, 2018
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935#pullrequestreview-108399073 |
|
View reviewed changes
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files/647efe7d9017ff6b03b459e2fb642913890f6119 |
| https://github.com/JamesWTruher |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| 6a8e828 | https://github.com/PowerShell/PSScriptAnalyzer/commit/6a8e8289e8f94622bad33d654657cdb5288309a5 |
| Mar 30, 2018 | https://github.com/PowerShell/PSScriptAnalyzer/pull/935#event-1550178023 |
| https://github.co/hiddenchars |
| https://github.com/PowerShell/PSScriptAnalyzer/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F935 |
|
| https://github.com/JamesWTruher |
|
James Truher (JamesWTruher)
| https://github.com/JamesWTruher |
|
| https://github.com/PowerShell/PSScriptAnalyzer/pull/935/files/647efe7d9017ff6b03b459e2fb642913890f6119 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
|
| https://github.com/bergmeister |
|
Christoph Bergmeister (bergmeister)
| https://github.com/bergmeister |
|
Area - PSUseDeclaredVarsMoreThanAssignments
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20PSUseDeclaredVarsMoreThanAssignments%22 |
|
Area - Rules
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20Rules%22 |
|
Issue - Bug
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20Bug%22 |
|
1.17
| https://github.com/PowerShell/PSScriptAnalyzer/milestone/20 |
|
PSUseDeclaredVarsMoreThanAssignments is thrown incorrectly
| https://github.com/PowerShell/PSScriptAnalyzer/issues/903 |
|
Warning about unused variable in VSCode
| https://github.com/PowerShell/PSScriptAnalyzer/issues/827 |
|
Unassigned variable rule does not consider += operator to be an assignment
| https://github.com/PowerShell/vscode-powershell/issues/776 |
|
PSUseDeclaredVarsMoreThanAssignment not correctly handling array adds
| https://github.com/PowerShell/PSScriptAnalyzer/issues/699 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/935 |
|
| https://github.com/bergmeister |
|
| https://github.com/JamesWTruher |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |