René's URL Explorer Experiment


Title: Lock calls around Test-ModuleManifest, which is not thread safe by bergmeister · Pull Request #1258 · PowerShell/PSScriptAnalyzer · GitHub

Open Graph Title: Lock calls around Test-ModuleManifest, which is not thread safe by bergmeister · Pull Request #1258 · PowerShell/PSScriptAnalyzer

X Title: Lock calls around Test-ModuleManifest, which is not thread safe by bergmeister · Pull Request #1258 · PowerShell/PSScriptAnalyzer

Description: PR Summary This is an alternative, better implementation, compared to PR #1257 Basically the issues below show that Test-ModuleManifest exhibits a concurreny problem in all version of PowerShell and it is not clear yet if that is an issue of the cmdlet itself or something deep within SMA. But as a matter of fact, the only way to avoid it at the moment, is not avoid concurrent calls to Test-ModuleManifest. Please use a whitespace-ignoring diff due to the indentation shift. Fixes #901 Fixes #902 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes [x ] Change is not breaking Make sure all .cs, .ps1 and .psm1 files have the correct copyright header Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Open Graph Description: PR Summary This is an alternative, better implementation, compared to PR #1257 Basically the issues below show that Test-ModuleManifest exhibits a concurreny problem in all version of PowerShell an...

X Description: PR Summary This is an alternative, better implementation, compared to PR #1257 Basically the issues below show that Test-ModuleManifest exhibits a concurreny problem in all version of PowerShell an...

Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/pull/1258

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87b466a1-c8c9-adfd-06c3-e66035f1064a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC066:9FF1A:24CA6B4:33502CD:6AFD3D0F
html-safe-nonce7b36efc85c818fcfdb3e77fefe36e3e78668cb318a386ec079d5b325fc62ef08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDY2OjlGRjFBOjI0Q0E2QjQ6MzM1MDJDRDo2QUZEM0QwRiIsInZpc2l0b3JfaWQiOiI2ODY0NjY0ODY2ODU0ODc4NDc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacff1d1a6ebbf7601f47506aafc79a12dbccde79d5eadc011d87ca887715c12ba5
hovercard-subject-tagpull_request:286846767
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
twitter:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
og:image:altPR Summary This is an alternative, better implementation, compared to PR #1257 Basically the issues below show that Test-ModuleManifest exhibits a concurreny problem in all version of PowerShell an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id33149177
octolytics-dimension-repository_nwoPowerShell/PSScriptAnalyzer
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33149177
octolytics-dimension-repository_network_root_nwoPowerShell/PSScriptAnalyzer
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1258%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1258%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
PowerShellhttps://github.com/PowerShell
PSScriptAnalyzerhttps://github.com/PowerShell/PSScriptAnalyzer
Codehttps://github.com/PowerShell/PSScriptAnalyzer
Issues407 (407)https://github.com/PowerShell/PSScriptAnalyzer/issues
Pull requests34 (34)https://github.com/PowerShell/PSScriptAnalyzer/pulls
Discussionshttps://github.com/PowerShell/PSScriptAnalyzer/discussions
Actionshttps://github.com/PowerShell/PSScriptAnalyzer/actions
Projectshttps://github.com/PowerShell/PSScriptAnalyzer/projects
Wikihttps://github.com/PowerShell/PSScriptAnalyzer/wiki
Security and qualityhttps://github.com/PowerShell/PSScriptAnalyzer/security
Insightshttps://github.com/PowerShell/PSScriptAnalyzer/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
PowerShell:developmenthttps://github.com/PowerShell/PSScriptAnalyzer/tree/development
bergmeister:LockTestModuleManifesthttps://github.com/bergmeister/PSScriptAnalyzer/tree/LockTestModuleManifest
Conversation 1 https://github.com/PowerShell/PSScriptAnalyzer/pull/1258
Commits 1 https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/commits
Checks 0 https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/checks
Files changed https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Lock calls around Test-ModuleManifest, which is not thread safe https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#top
Show all changes 1 commit https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
a116bfe Lock calls around Test-ModuleManifest, which is not thread safe bergmeister Jun 10, 2019 https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/commits/a116bfe89afbaa98192d78b8b430a411a7203e3e
Clear filters https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files
Engine/Helper.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
View file https://github.com/bergmeister/PSScriptAnalyzer/blob/a116bfe89afbaa98192d78b8b430a411a7203e3e/Engine/Helper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
https://github.com/PowerShell/PSScriptAnalyzer/pull/1258/files#diff-427edd792ddc5404af08d95e98ffdd68d3d282caa731e104ee2c1a1998c506b9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.