| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b2155b0a-b94b-56f7-2edb-7dd1ac71d4d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7A0:1D84A0:2E0EBA:3CA4F0:6AFCE3F1 |
| html-safe-nonce | 8e09869c43f27f441ff5075787164776c1ae0f3b2ee9abf3709edd6b682a5e3f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0EwOjFEODRBMDoyRTBFQkE6M0NBNEYwOjZBRkNFM0YxIiwidmlzaXRvcl9pZCI6IjcwODI0ODE3ODgyMTkzNTIwNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b4426342d9b0788508047ff7065bbbce2d0dee85da8c34c494443302fe5a4251 |
| hovercard-subject-tag | pull_request:286346759 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PSScriptAnalyzer/1257/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/99e57cd8c041431fffc2945a3892f38da34bfff668220a64b724d367a4243d38/PowerShell/PSScriptAnalyzer/pull/1257 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/99e57cd8c041431fffc2945a3892f38da34bfff668220a64b724d367a4243d38/PowerShell/PSScriptAnalyzer/pull/1257 |
| og:image:alt | PR Summary
Fixes #901
Fixes #902
Retry Test-ModuleManifest that can sometimes throw due to a thread safety issue in PowerShell itself (I can repro in versions 5-7 and maybe later I want to look int... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bergmeister |
| hostname | github.com |
| expected-hostname | github.com |
| None | 99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3 |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 33149177 |
| octolytics-dimension-repository_nwo | PowerShell/PSScriptAnalyzer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33149177 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PSScriptAnalyzer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ecfd63ca125ec74b42f74eeb158b3fa081c8c497 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1257 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1257 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| Reload | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| PowerShell | https://github.com/PowerShell |
| PSScriptAnalyzer | https://github.com/PowerShell/PSScriptAnalyzer |
| Code | https://github.com/PowerShell/PSScriptAnalyzer |
| Issues407 (407) | https://github.com/PowerShell/PSScriptAnalyzer/issues |
| Pull requests34 (34) | https://github.com/PowerShell/PSScriptAnalyzer/pulls |
| Discussions | https://github.com/PowerShell/PSScriptAnalyzer/discussions |
| Actions | https://github.com/PowerShell/PSScriptAnalyzer/actions |
| Projects | https://github.com/PowerShell/PSScriptAnalyzer/projects |
| Wiki | https://github.com/PowerShell/PSScriptAnalyzer/wiki |
| Security and quality | https://github.com/PowerShell/PSScriptAnalyzer/security |
| Insights | https://github.com/PowerShell/PSScriptAnalyzer/insights |
| https://github.com/PowerShell/PSScriptAnalyzer |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| PowerShell:development | https://github.com/PowerShell/PSScriptAnalyzer/tree/development |
| bergmeister:Retry_TestModuleManifest | https://github.com/bergmeister/PSScriptAnalyzer/tree/Retry_TestModuleManifest |
| Conversation | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| Commits2 (2) | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/commits |
| Checks | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/checks |
| Files changed | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/files |
| Retry Test-Module manifest calls to avoid sporadic failures due to concurrency/thread safety issue in PowerShell itself | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#top |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| PowerShell:development | https://github.com/PowerShell/PSScriptAnalyzer/tree/development |
| bergmeister:Retry_TestModuleManifest | https://github.com/bergmeister/PSScriptAnalyzer/tree/Retry_TestModuleManifest |
|
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Jun 7, 2019 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#issue-453710706 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| #901 | https://github.com/PowerShell/PSScriptAnalyzer/issues/901 |
| #902 | https://github.com/PowerShell/PSScriptAnalyzer/issues/902 |
| PowerShell/PowerShell#9860 | https://github.com/PowerShell/PowerShell/pull/9860 |
| #1258 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1258 |
| PR has a meaningful title | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Summarized changes | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Change is not breaking | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes |
| Make sure all .cs, .ps1 and .psm1 files have the correct copyright header | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Work in Progress | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| June 7, 2019 22:55 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#commits-pushed-52f08b4 |
|
| https://github.com/bergmeister |
| Retry Test-Module manifest calls to avoid sporadic failures to concur… | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/commits/52f08b44b9d55beb16653ea7d7298eede91eb2da |
| 52f08b4 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/commits/52f08b44b9d55beb16653ea7d7298eede91eb2da |
|
| https://github.com/bergmeister |
| cleanup | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/commits/d73eea218fb8409b865d42bd8a88bdf3bf0d58fa |
| d73eea2 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257/commits/d73eea218fb8409b865d42bd8a88bdf3bf0d58fa |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
|
Issue - Bug
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20Bug%22 |
| Jun 7, 2019 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#event-2398516865 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| June 7, 2019 22:06 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#event-2398516979 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Jun 7, 2019 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#event-2398517550 |
|
WIP: Make module intrinsics code thread safe by using a ConcurrentBag instead of a Collection to prevent errors that surface in PSSA
PowerShell/PowerShell#9860
| https://github.com/PowerShell/PowerShell/pull/9860 |
|
Lock calls around Test-ModuleManifest, which is not thread safe
#1258
| https://github.com/PowerShell/PSScriptAnalyzer/pull/1258 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Jun 10, 2019 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#issuecomment-500605236 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| #1258 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1258 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
| https://github.com/bergmeister |
| Christoph Bergmeister (bergmeister) | https://github.com/bergmeister |
| Jun 11, 2019 | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257#event-2405173979 |
| https://github.co/hiddenchars |
| https://github.com/PowerShell/PSScriptAnalyzer/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1257 |
|
| https://github.com/JamesWTruher |
|
James Truher (JamesWTruher)
| https://github.com/JamesWTruher |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
|
Issue - Bug
| https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20Bug%22 |
|
PSUseToExportFieldsInManifest throw System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
| https://github.com/PowerShell/PSScriptAnalyzer/issues/902 |
|
PSMissingModuleManifestField throw System.IndexOutOfRangeException
| https://github.com/PowerShell/PSScriptAnalyzer/issues/901 |
| Please reload this page | https://github.com/PowerShell/PSScriptAnalyzer/pull/1257 |
|
| https://github.com/bergmeister |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |