René's URL Explorer Experiment


Title: Write-Warning instead of returning artificial DiagnosticRecord when type parsing errors occurs since those DiagnosticRecords cannot be suppressed. by bergmeister · Pull Request #1126 · PowerShell/PSScriptAnalyzer · GitHub

Open Graph Title: Write-Warning instead of returning artificial DiagnosticRecord when type parsing errors occurs since those DiagnosticRecords cannot be suppressed. by bergmeister · Pull Request #1126 · PowerShell/PSScriptAnalyzer

X Title: Write-Warning instead of returning artificial DiagnosticRecord when type parsing errors occurs since those DiagnosticRecords cannot be suppressed. by bergmeister · Pull Request #1126 · PowerShell/PSScriptAnalyzer

Description: PR Summary Fixes #1041 as per title and enhances message. I tried looking into being able to support suppressions for a DiagnosticRecord but this did not seem to be possible or very complicated. Since TypeNotFound is not a rule, I think it was confusing anyway to return an object. Consumers like PowerShellEditorServices should check their warning streams to propagate the information to their users. cc TylerLeonhardt Rob Holt (@rjmholt) The failing tests on Ubuntu happen on development as well and seem to be due to an image update (again) PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Change is not breaking Make sure all .cs, .ps1 and .psm1 files have the correct copyright header Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Open Graph Description: PR Summary Fixes #1041 as per title and enhances message. I tried looking into being able to support suppressions for a DiagnosticRecord but this did not seem to be possible or very complicated. Si...

X Description: PR Summary Fixes #1041 as per title and enhances message. I tried looking into being able to support suppressions for a DiagnosticRecord but this did not seem to be possible or very complicated. Si...

Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/pull/1126

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3554517b-02f4-0600-f4b8-3edd3faad0b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC1C:69153:15ADEB:1E0486:6AFE0561
html-safe-nonce050f90525b58c0d5d1ccc2da8590cf333761d5a8ec5465ddf24c7747504dc972
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzFDOjY5MTUzOjE1QURFQjoxRTA0ODY6NkFGRTA1NjEiLCJ2aXNpdG9yX2lkIjoiODQyMjA4Mzk2NDc0MjUzNDQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccfc88024eed560e7eec268572b90e0a75c4a915c06ac0fcd4edc2e2a1be568f8
hovercard-subject-tagpull_request:244701072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
twitter:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
og:image:altPR Summary Fixes #1041 as per title and enhances message. I tried looking into being able to support suppressions for a DiagnosticRecord but this did not seem to be possible or very complicated. Si...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None86d46ece7c3d9b0562692f81a135cb55ad6a1c82c93ab1ac874d2f1b46b28958
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id33149177
octolytics-dimension-repository_nwoPowerShell/PSScriptAnalyzer
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33149177
octolytics-dimension-repository_network_root_nwoPowerShell/PSScriptAnalyzer
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5c18e6799976b7bc2f21178024289bb98edbcc85
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1126%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fpull%2F1126%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
PowerShellhttps://github.com/PowerShell
PSScriptAnalyzerhttps://github.com/PowerShell/PSScriptAnalyzer
Codehttps://github.com/PowerShell/PSScriptAnalyzer
Issues407 (407)https://github.com/PowerShell/PSScriptAnalyzer/issues
Pull requests35 (35)https://github.com/PowerShell/PSScriptAnalyzer/pulls
Discussionshttps://github.com/PowerShell/PSScriptAnalyzer/discussions
Actionshttps://github.com/PowerShell/PSScriptAnalyzer/actions
Projectshttps://github.com/PowerShell/PSScriptAnalyzer/projects
Wikihttps://github.com/PowerShell/PSScriptAnalyzer/wiki
Security and qualityhttps://github.com/PowerShell/PSScriptAnalyzer/security
Insightshttps://github.com/PowerShell/PSScriptAnalyzer/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2Fnew%2Fchoose
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
PowerShell:developmenthttps://github.com/PowerShell/PSScriptAnalyzer/tree/development
bergmeister:TypeNotFound_UseWarningInsteadOfReturningDiagnosticRecordshttps://github.com/bergmeister/PSScriptAnalyzer/tree/TypeNotFound_UseWarningInsteadOfReturningDiagnosticRecords
Conversation 3 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126
Commits 4 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/commits
Checks 0 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/checks
Files changed https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Write-Warning instead of returning artificial DiagnosticRecord when type parsing errors occurs since those DiagnosticRecords cannot be suppressed. https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#top
Show all changes 4 commits https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
f552337 Write warning instead of returning artificial DiagnosticRecord when t… bergmeister Jan 15, 2019 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/commits/f5523375cb3e98cf30528e019abc62f65ac0f163
e161983 adapt test expectation bergmeister Jan 15, 2019 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/commits/e161983059a2e347e617797fc1e9ca522c64f5dd
f99ed9c suppress output from warning which gets captured in warning variable … bergmeister Jan 15, 2019 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/commits/f99ed9cb5faf4eeba1c210e9b42e24b198602edb
aa021e0 Merge branch 'development' of https://github.com/PowerShell/PSScriptA… bergmeister Jan 15, 2019 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/commits/aa021e017f756c91cab393360f0fd2fad14e3063
Clear filters https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
ScriptAnalyzer.cs https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-111e1a18ba64b4ef55b1a611b6808a8671d79cbd45b9612229caa2a9cd2b27f3
Strings.Designer.cs https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-293b49940dbba6c689aed48c0b881a26d7b72718e0d73439857b0779d2dec39f
Strings.resx https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-5ebe9c663a63162f460a9f3b7560cd498ed06ece2b6a47534fa5cb39164ab5e3
InvokeScriptAnalyzer.tests.ps1 https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
Engine/ScriptAnalyzer.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-111e1a18ba64b4ef55b1a611b6808a8671d79cbd45b9612229caa2a9cd2b27f3
View file https://github.com/bergmeister/PSScriptAnalyzer/blob/aa021e017f756c91cab393360f0fd2fad14e3063/Engine/ScriptAnalyzer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-111e1a18ba64b4ef55b1a611b6808a8671d79cbd45b9612229caa2a9cd2b27f3
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-111e1a18ba64b4ef55b1a611b6808a8671d79cbd45b9612229caa2a9cd2b27f3
Engine/Strings.Designer.cshttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-293b49940dbba6c689aed48c0b881a26d7b72718e0d73439857b0779d2dec39f
View file https://github.com/bergmeister/PSScriptAnalyzer/blob/aa021e017f756c91cab393360f0fd2fad14e3063/Engine/Strings.Designer.cs
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files
Engine/Strings.resxhttps://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-5ebe9c663a63162f460a9f3b7560cd498ed06ece2b6a47534fa5cb39164ab5e3
View file https://github.com/bergmeister/PSScriptAnalyzer/blob/aa021e017f756c91cab393360f0fd2fad14e3063/Engine/Strings.resx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-5ebe9c663a63162f460a9f3b7560cd498ed06ece2b6a47534fa5cb39164ab5e3
Tests/Engine/InvokeScriptAnalyzer.tests.ps1https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
View file https://github.com/bergmeister/PSScriptAnalyzer/blob/aa021e017f756c91cab393360f0fd2fad14e3063/Tests/Engine/InvokeScriptAnalyzer.tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/{{ revealButtonHref }}
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com/PowerShell/PSScriptAnalyzer/pull/1126/files#diff-dfc93f2c6f590bf681736728b9a79093ac4ab79ee06f5006c199876228200ccc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.