Title: rule request: AvoidPlusEqualToPopulateDictionary · Issue #2154 · PowerShell/PSScriptAnalyzer · GitHub
Open Graph Title: rule request: AvoidPlusEqualToPopulateDictionary · Issue #2154 · PowerShell/PSScriptAnalyzer
X Title: rule request: AvoidPlusEqualToPopulateDictionary · Issue #2154 · PowerShell/PSScriptAnalyzer
Description: Avoid assignment by addition operator (+=) to populate a dictionary As with using the assignment by addition operator (+=) to build a collection or a string, populating a dictionary using the assignment by addition operator (+=) is in ef...
Open Graph Description: Avoid assignment by addition operator (+=) to populate a dictionary As with using the assignment by addition operator (+=) to build a collection or a string, populating a dictionary using the assig...
X Description: Avoid assignment by addition operator (+=) to populate a dictionary As with using the assignment by addition operator (+=) to build a collection or a string, populating a dictionary using the assig...
Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/issues/2154
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"rule request: AvoidPlusEqualToPopulateDictionary","articleBody":"**Avoid assignment by addition operator (`+=`) to populate a dictionary**\n\nAs with using the assignment by addition operator (`+=`) to build a collection or a string, populating a dictionary using the assignment by addition operator (`+=`) is in effective:\n\n\u003cdetails>\n \u003csummary>Tests\u003c/summary>\n\n```PowerShell\n$tests = @{\n 'Array+=' = {\n param($count)\n\n $result = @()\n foreach($i in 1..$count) {\n $result += $i\n }\n }\n 'IList.Add' = {\n param($count)\n\n $result = [Collections.Generic.List[int]]::new()\n foreach($i in 1..$count) {\n $result.Add($i)\n }\n }\n 'IList+=' = {\n param($count)\n\n $result = [Collections.Generic.List[int]]::new()\n foreach($i in 1..$count) {\n $result += $i\n }\n }\n 'IDictionary[]' = {\n param($count)\n\n $result = @{}\n foreach($i in 1..$count) {\n $result[$i] = $i\n }\n }\n 'IDictionary.Add' = {\n param($count)\n\n $result = @{}\n foreach($i in 1..$count) {\n $result.Add($i, $i)\n }\n }\n\n 'IDictionary+=' = {\n param($count)\n\n $result = @{}\n foreach($i in 1..$count) {\n $result += @{ $i = $i }\n }\n }\n} # Tests\n\n1kb, 5kb, 10kb | ForEach-Object {\n $groupResult = foreach($test in $tests.GetEnumerator()) {\n $ms = (Measure-Command { & $test.Value -Count $_ }).TotalMilliseconds\n\n [pscustomobject]@{\n CollectionSize = $_\n Test = $test.Key\n TotalMilliseconds = [Math]::Round($ms, 2)\n }\n\n [GC]::Collect()\n [GC]::WaitForPendingFinalizers()\n }\n\n $groupResult = $groupResult | Sort-Object TotalMilliseconds\n $groupResult | Select-Object *, @{\n Name = 'RelativeSpeed'\n Expression = {\n $relativeSpeed = $_.TotalMilliseconds / $groupResult[0].TotalMilliseconds\n $speed = [Math]::Round($relativeSpeed, 2).ToString() + 'x'\n if ($speed -eq '1x') { $speed } else { $speed + ' slower' }\n }\n } | Format-Table -AutoSize\n}\n```\n\u003c/details>\n\n```\nCollectionSize Test TotalMilliseconds RelativeSpeed\n-------------- ---- ----------------- -------------\n 1024 IDictionary[] 0.19 1x\n 1024 IList.Add 0.35 1.84x slower\n 1024 IDictionary.Add 0.50 2.63x slower\n 1024 Array+= 0.74 3.89x slower\n 1024 IList+= 1.16 6.11x slower\n 1024 IDictionary+= 39.17 206.16x slower\n\n\nCollectionSize Test TotalMilliseconds RelativeSpeed\n-------------- ---- ----------------- -------------\n 5120 IDictionary[] 0.71 1x\n 5120 IDictionary.Add 1.41 1.99x slower\n 5120 IList.Add 1.50 2.11x slower\n 5120 IList+= 20.33 28.63x slower\n 5120 Array+= 21.51 30.3x slower\n 5120 IDictionary+= 1880.89 2649.14x slower\n\n\nCollectionSize Test TotalMilliseconds RelativeSpeed\n-------------- ---- ----------------- -------------\n 10240 IDictionary[] 0.92 1x\n 10240 IDictionary.Add 3.79 4.12x slower\n 10240 IList.Add 4.71 5.12x slower\n 10240 IList+= 71.91 78.16x slower\n 10240 Array+= 86.93 94.49x slower\n 10240 IDictionary+= 5502.40 5980.87x slower\n```\n\nInstead use (even for a single item):\n\n* the square bracket syntax (`$Dictionary[$Key] = $Value`) or dot syntax (`$Dictionary.$Key = $Value`) which will overwrite any duplicate key\n* the `.Add()` method (`$Dictionary($Key, $Value)`) which returns an error when the key already exists\n\n**Proposed technical implementation details (optional)**\n\nAs apposed to the requests for [avoiding the assignment by addition operator (`+=`) to build a collection or a string](https://github.com/PowerShell/PSScriptAnalyzer/issues/2112#issuecomment-3825547599), the majority of this bad practice syntax would be easier to capture:\n\n* Check for the `+=` operator\n* Directly followed by a hash table syntax `@{ ... }`\n * With a single key-value pair\n * And a dynamic key\n\nEven using a simple search string will capture lot of issues (note that almost all results are embedded in a `foreach` loop):\nhttps://github.com/search?q=language%3Apowershell+%22%2b=%20@%7B%20$%22&type=code\n\nThe LHS could still be anything else than a presumed `IDictionary`, e.g. an `IList`.\nBut than there is still a good reason to avoid the `+=` operator...\n\n**What is the latest version of PSScriptAnalyzer at the point of writing**\n\n`1.24.0`","author":{"url":"https://github.com/iRon7","@type":"Person","name":"iRon7"},"datePublished":"2026-02-14T12:26:14Z","url":"https://github.com/PowerShell/PSScriptAnalyzer/issues/2154"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:17eaf335-ea8c-f9ae-f5ab-55aeab4071b3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BD8E:24FE73:2D1994:3F4CED:6AFCD462 |
| html-safe-nonce | b48acecdf9450e00819394ace48c51c689b0e7e5aacfb8f60ff1dece8027b2a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDhFOjI0RkU3MzoyRDE5OTQ6M0Y0Q0VEOjZBRkNENDYyIiwidmlzaXRvcl9pZCI6IjI3NDk2NzAyOTQxMjg3NDM1MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 61892c8d33f5e5a4e3f62654658c1bcaa15740b30ee7ae39db2eb0d130adb826 |
| hovercard-subject-tag | issue:3941304280 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PSScriptAnalyzer/2154/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c37f55e764f5aceb412738a226df4ee702d41954f891ef6fe72bbe8d5aa08819/PowerShell/PSScriptAnalyzer/issues/2154 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c37f55e764f5aceb412738a226df4ee702d41954f891ef6fe72bbe8d5aa08819/PowerShell/PSScriptAnalyzer/issues/2154 |
| og:image:alt | Avoid assignment by addition operator (+=) to populate a dictionary As with using the assignment by addition operator (+=) to build a collection or a string, populating a dictionary using the assig... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iRon7 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5b7bc7e41e0a604bbdb5035c7ed9620c2d28b9c8a18747182e2262a75abfd91 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 33149177 |
| octolytics-dimension-repository_nwo | PowerShell/PSScriptAnalyzer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33149177 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PSScriptAnalyzer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ff5022cc3aa767e6115451d9c322dd975506d40e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width