Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer · GitHub
Open Graph Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer
X Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer
Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += to build collections so that I don't have...
Open Graph Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += t...
X Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using ...
Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/issues/2112
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Rule request: AvoidUsingPlusEqualOnCollections","articleBody":"**Summary of the new feature**\n> NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1.\n\nAs a code reviewer, I want developers to be warned about using `+=` to build collections so that I don't have to repeatedly explain why their scripts have poor performance and can focus on reviewing logic instead of catching inefficient patterns.\n\n**Problem Statement:**\nUsing `+=` to build arrays and collections in PowerShell is a common performance anti-pattern. Each `+=` operation creates an entirely new array and copies all existing elements, resulting in O(n²) complexity for building collections. This can cause significant performance degradation, especially with large datasets.\n\nFor example, adding 10,000 items to an array using `+=` performs ~50 million copy operations, while using proper collection types performs only 10,000 add operations.\n\n## Proposed technical implementation details\n\n**Rule Name:** `PSAvoidUsingPlusEqualsOnCollections`\n\n**Severity:** Warning\n\n**Behavior:**\n- Skip if using PowerShell v7.5+\n- Flag usage of `+=` operator when the left-hand side is a collection, array, or string.\n- Suggest more efficient alternatives based on the context\n\n**Recommended alternatives to suggest:**\n* Microsoft's documentation has a good start to this:\n* * [Array Addition](https://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#array-addition)\n* * [String Addition](https://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#string-addition)\n\n**Example violations:**\n```powershell\n# Building array with += - Flagged\n$results = @()\nforeach ($item in $data) {\n $results += $item\n}\n\n# Building collection in loop - Flagged\n$numbers = @()\nfor ($i = 1; $i -le 1000; $i++) {\n $numbers += $i\n}\n\n# Adding to existing array - Flagged\n$existingArray += $newItem\n\n# Adding to IDictionaries\n$hashtable = @{}\nfor ($i = 1; $i -le 1000; $i++)\n{\n $hashtable += @{$i = $i }\n}\n```\n\n**Should NOT be flagged:**\n```powershell\n# Numeric operations\n$sum += $number\n```\n\n**Technical Implementation:**\n- I plan on implementing this rule if approved.\n- From my testing, the rule will inherit AstVisitor and visit `VisitAssignmentStatement`.\n- Left-hand assignment's type can be retrieved via `Helper.Instance.GetTypeFromAnalysis()`\n- If not found, analyze where the variable was initialized and go from there. From my testing, analyzing the right-hand side ExpressionAsts' helped determine said type if `GetTypeFromAnalysis` was unreliable.\n- Provide context-appropriate suggestions based on the use case\n\n**Configuration Options (up for discussion):**\n- Add type exclusion (e.g., String)?\n\n## What is the latest version of PSScriptAnalyzer at the point of writing\n\n1.24.0","author":{"url":"https://github.com/DrSkillIssue","@type":"Person","name":"DrSkillIssue"},"datePublished":"2025-06-15T18:03:02Z","url":"https://github.com/PowerShell/PSScriptAnalyzer/issues/2112"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b49ede4f-a591-bf3c-bfeb-c683233e61b5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CC02:18B7E8:4247BC:577B4C:6AFCE902 |
| html-safe-nonce | 8080049197429c210b6a62ea2b84a55cc851e758adec583fd458b77ed953ab0e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzAyOjE4QjdFODo0MjQ3QkM6NTc3QjRDOjZBRkNFOTAyIiwidmlzaXRvcl9pZCI6IjE5NDgwOTEzODY1MTEwMjY0MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b1c3d45a15063eac31158bed0882d11fd680606428d9e20e330b657ae8546be4 |
| hovercard-subject-tag | issue:3147897508 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PSScriptAnalyzer/2112/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c9749b3333b7d12e63ea799912a69b1ca4c94187d42744e5d0230cc098d66c34/PowerShell/PSScriptAnalyzer/issues/2112 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c9749b3333b7d12e63ea799912a69b1ca4c94187d42744e5d0230cc098d66c34/PowerShell/PSScriptAnalyzer/issues/2112 |
| og:image:alt | Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DrSkillIssue |
| hostname | github.com |
| expected-hostname | github.com |
| None | 99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 33149177 |
| octolytics-dimension-repository_nwo | PowerShell/PSScriptAnalyzer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33149177 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PSScriptAnalyzer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ecfd63ca125ec74b42f74eeb158b3fa081c8c497 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width