René's URL Explorer Experiment


Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer · GitHub

Open Graph Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer

X Title: Rule request: AvoidUsingPlusEqualOnCollections · Issue #2112 · PowerShell/PSScriptAnalyzer

Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += to build collections so that I don't have...

Open Graph Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += t...

X Description: Summary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using ...

Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/issues/2112

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Rule request: AvoidUsingPlusEqualOnCollections","articleBody":"**Summary of the new feature**\n> NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1.\n\nAs a code reviewer, I want developers to be warned about using `+=` to build collections so that I don't have to repeatedly explain why their scripts have poor performance and can focus on reviewing logic instead of catching inefficient patterns.\n\n**Problem Statement:**\nUsing `+=` to build arrays and collections in PowerShell is a common performance anti-pattern. Each `+=` operation creates an entirely new array and copies all existing elements, resulting in O(n²) complexity for building collections. This can cause significant performance degradation, especially with large datasets.\n\nFor example, adding 10,000 items to an array using `+=` performs ~50 million copy operations, while using proper collection types performs only 10,000 add operations.\n\n## Proposed technical implementation details\n\n**Rule Name:** `PSAvoidUsingPlusEqualsOnCollections`\n\n**Severity:** Warning\n\n**Behavior:**\n- Skip if using PowerShell v7.5+\n- Flag usage of `+=` operator when the left-hand side is a collection, array, or string.\n- Suggest more efficient alternatives based on the context\n\n**Recommended alternatives to suggest:**\n* Microsoft's documentation has a good start to this:\n* * [Array Addition](https://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#array-addition)\n* * [String Addition](https://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#string-addition)\n\n**Example violations:**\n```powershell\n# Building array with += - Flagged\n$results = @()\nforeach ($item in $data) {\n    $results += $item\n}\n\n# Building collection in loop - Flagged\n$numbers = @()\nfor ($i = 1; $i -le 1000; $i++) {\n    $numbers += $i\n}\n\n# Adding to existing array - Flagged\n$existingArray += $newItem\n\n# Adding to IDictionaries\n$hashtable = @{}\nfor ($i = 1; $i -le 1000; $i++)\n{\n    $hashtable += @{$i = $i }\n}\n```\n\n**Should NOT be flagged:**\n```powershell\n# Numeric operations\n$sum += $number\n```\n\n**Technical Implementation:**\n- I plan on implementing this rule if approved.\n- From my testing, the rule will inherit AstVisitor and visit `VisitAssignmentStatement`.\n- Left-hand assignment's type can be retrieved via `Helper.Instance.GetTypeFromAnalysis()`\n- If not found, analyze where the variable was initialized and go from there. From my testing, analyzing the right-hand side ExpressionAsts' helped determine said type if `GetTypeFromAnalysis` was unreliable.\n- Provide context-appropriate suggestions based on the use case\n\n**Configuration Options (up for discussion):**\n- Add type exclusion (e.g., String)?\n\n## What is the latest version of PSScriptAnalyzer at the point of writing\n\n1.24.0","author":{"url":"https://github.com/DrSkillIssue","@type":"Person","name":"DrSkillIssue"},"datePublished":"2025-06-15T18:03:02Z","url":"https://github.com/PowerShell/PSScriptAnalyzer/issues/2112"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b49ede4f-a591-bf3c-bfeb-c683233e61b5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCC02:18B7E8:4247BC:577B4C:6AFCE902
html-safe-nonce8080049197429c210b6a62ea2b84a55cc851e758adec583fd458b77ed953ab0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzAyOjE4QjdFODo0MjQ3QkM6NTc3QjRDOjZBRkNFOTAyIiwidmlzaXRvcl9pZCI6IjE5NDgwOTEzODY1MTEwMjY0MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1c3d45a15063eac31158bed0882d11fd680606428d9e20e330b657ae8546be4
hovercard-subject-tagissue:3147897508
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PSScriptAnalyzer/2112/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c9749b3333b7d12e63ea799912a69b1ca4c94187d42744e5d0230cc098d66c34/PowerShell/PSScriptAnalyzer/issues/2112
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c9749b3333b7d12e63ea799912a69b1ca4c94187d42744e5d0230cc098d66c34/PowerShell/PSScriptAnalyzer/issues/2112
og:image:altSummary of the new feature NOTE: I do believe this rule isn't relevant for v7.5+ but a lot of us are unfortunately stuck on v5.1. As a code reviewer, I want developers to be warned about using += t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDrSkillIssue
hostnamegithub.com
expected-hostnamegithub.com
None99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id33149177
octolytics-dimension-repository_nwoPowerShell/PSScriptAnalyzer
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33149177
octolytics-dimension-repository_network_root_nwoPowerShell/PSScriptAnalyzer
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseecfd63ca125ec74b42f74eeb158b3fa081c8c497
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PSScriptAnalyzer/issues/2112#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2F2112
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2F2112
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/2112
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/2112
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/2112
PowerShellhttps://github.com/PowerShell
PSScriptAnalyzerhttps://github.com/PowerShell/PSScriptAnalyzer
Codehttps://github.com/PowerShell/PSScriptAnalyzer
Issues407 (407)https://github.com/PowerShell/PSScriptAnalyzer/issues
Pull requests34 (34)https://github.com/PowerShell/PSScriptAnalyzer/pulls
Discussionshttps://github.com/PowerShell/PSScriptAnalyzer/discussions
Actionshttps://github.com/PowerShell/PSScriptAnalyzer/actions
Projectshttps://github.com/PowerShell/PSScriptAnalyzer/projects
Wikihttps://github.com/PowerShell/PSScriptAnalyzer/wiki
Security and qualityhttps://github.com/PowerShell/PSScriptAnalyzer/security
Insightshttps://github.com/PowerShell/PSScriptAnalyzer/insights
https://github.com/PowerShell/PSScriptAnalyzer
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/2112
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/2112
Rule request: AvoidUsingPlusEqualOnCollectionshttps://github.com/PowerShell/PSScriptAnalyzer/issues/2112#top
https://github.com/DrSkillIssue
Dr. Skill Issue (DrSkillIssue)https://github.com/DrSkillIssue
on Jun 15, 2025https://github.com/PowerShell/PSScriptAnalyzer/issues/2112#issue-3147897508
Array Additionhttps://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#array-addition
String Additionhttps://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/performance/script-authoring-considerations?view=powershell-7.5#string-addition
https://github.com/iRon7
iRon7https://github.com/iRon7
on Jan 26, 2026https://github.com/PowerShell/PSScriptAnalyzer/issues/2112#issuecomment-3801010605
#1935https://github.com/PowerShell/PSScriptAnalyzer/issues/1935
#904https://github.com/PowerShell/PSScriptAnalyzer/issues/904
#806https://github.com/PowerShell/PSScriptAnalyzer/issues/806
PowerShell rulehttps://github.com/iRon7/PSRules/blob/main/AvoidPlusEqualsToBuildCollections.psm1
I'd still recommend explicit assignment.https://stackoverflow.com/questions/60708578/why-should-i-avoid-using-the-increase-assignment-operator-to-create-a-colle#comment140179941_78929196
https://github.com/bergmeister
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
on Jan 30, 2026https://github.com/PowerShell/PSScriptAnalyzer/issues/2112#issuecomment-3825547599
#933https://github.com/PowerShell/PSScriptAnalyzer/pull/933
https://github.com/iRon7
iRon7https://github.com/iRon7
on Jan 30, 2026https://github.com/PowerShell/PSScriptAnalyzer/issues/2112#issuecomment-3825629345
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/2112
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/2112
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.