Title: Suppression with `SuppressMessageAttribute` is completely broken for variables · Issue #2040 · PowerShell/PSScriptAnalyzer · GitHub
Open Graph Title: Suppression with `SuppressMessageAttribute` is completely broken for variables · Issue #2040 · PowerShell/PSScriptAnalyzer
X Title: Suppression with `SuppressMessageAttribute` is completely broken for variables · Issue #2040 · PowerShell/PSScriptAnalyzer
Description: Steps to reproduce Consider this code: $foo = "never used" # Should generate PSUseDeclaredVarsMoreThanAssignments $global:var1 = $null # Should generate PSAvoidGlobalVars Now let's try to add these suppressions: [Diagnostics.CodeAnalysis...
Open Graph Description: Steps to reproduce Consider this code: $foo = "never used" # Should generate PSUseDeclaredVarsMoreThanAssignments $global:var1 = $null # Should generate PSAvoidGlobalVars Now let's try to add these...
X Description: Steps to reproduce Consider this code: $foo = "never used" # Should generate PSUseDeclaredVarsMoreThanAssignments $global:var1 = $null # Should generate PSAvoidGlobalVars Now let's tr...
Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/issues/2040
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Suppression with `SuppressMessageAttribute` is completely broken for variables","articleBody":"Steps to reproduce\r\n------------------\r\n\r\nConsider this code:\r\n\r\n```powershell\r\n$foo = \"never used\" # Should generate PSUseDeclaredVarsMoreThanAssignments\r\n\r\n$global:var1 = $null # Should generate PSAvoidGlobalVars\r\n```\r\n\r\nNow let's try to add these suppressions:\r\n\r\n```powershell\r\n[Diagnostics.CodeAnalysis.SuppressMessage('NonexistentRule', '')]\r\n$foo = \"never used\" # Should still generate PSUseDeclaredVarsMoreThanAssignments\r\n\r\n[Diagnostics.CodeAnalysis.SuppressMessage('PSAvoidGlobalVars', '')]\r\n$global:var1 = $null # Should NOT generate PSAvoidGlobalVars\r\n```\r\n\r\nExpected behavior\r\n-----------------\r\n\r\nI should still see the `PSUseDeclaredVarsMoreThanAssignments` warning, but not the `PSAvoidGlobalVars` one.\r\n\r\nActual behavior\r\n---------------\r\n\r\nThe opposite happens, the first message is suppressed, but the second is not:\r\n\r\n```\r\nRuleName Severity ScriptName Line Message\r\n-------- -------- ---------- ---- -------\r\nPSAvoidGlobalVars Warning Test.ps1 5 Found global variable 'global:var1'.\r\n```\r\n\r\nEnvironment data\r\n----------------\r\n\r\n```powershell\r\n\u003e $PSVersionTable\r\n\r\nName Value\r\n---- -----\r\nPSVersion 7.4.5\r\nPSEdition Core\r\nGitCommitId 7.4.5\r\nOS Microsoft Windows 10.0.22631\r\nPlatform Win32NT\r\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}\r\nPSRemotingProtocolVersion 2.3\r\nSerializationVersion 1.1.0.1\r\nWSManStackVersion 3.0\r\n\r\n\u003e (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }\r\n1.23.0\r\n```\r\n","author":{"url":"https://github.com/BalassaMarton","@type":"Person","name":"BalassaMarton"},"datePublished":"2024-10-31T09:33:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/2040/PSScriptAnalyzer/issues/2040"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:34bbbf48-d1ba-3211-d5f6-fed5e89e478c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C058:2E90F6:1FA1BD3:2DE6CF8:6A55006B |
| html-safe-nonce | 50dcd34140192005ec80bf5090b0aa2282a20f04969205c8023e0c4a14f58e9b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDU4OjJFOTBGNjoxRkExQkQzOjJERTZDRjg6NkE1NTAwNkIiLCJ2aXNpdG9yX2lkIjoiNTE5NTcxMTM1MjM4NDMyMzY5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 87d59ef83d0bab6877246d992f41b6819b481183528f02b0f86bc42f26d3c7ae |
| hovercard-subject-tag | issue:2626400069 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PSScriptAnalyzer/2040/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9bdc20ddbea358a48ee38536f9a925d26ac5afb0fd19541e377fd308230a96d1/PowerShell/PSScriptAnalyzer/issues/2040 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9bdc20ddbea358a48ee38536f9a925d26ac5afb0fd19541e377fd308230a96d1/PowerShell/PSScriptAnalyzer/issues/2040 |
| og:image:alt | Steps to reproduce Consider this code: $foo = "never used" # Should generate PSUseDeclaredVarsMoreThanAssignments $global:var1 = $null # Should generate PSAvoidGlobalVars Now let's try to add these... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BalassaMarton |
| hostname | github.com |
| expected-hostname | github.com |
| None | eae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 33149177 |
| octolytics-dimension-repository_nwo | PowerShell/PSScriptAnalyzer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33149177 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PSScriptAnalyzer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a35ab858be185cd86d12b93a43bccf34e8d8536 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width