René's URL Explorer Experiment


Title: PSSA should have a new rule to check for properly used Process blocks · Issue #1571 · PowerShell/PSScriptAnalyzer · GitHub

Open Graph Title: PSSA should have a new rule to check for properly used Process blocks · Issue #1571 · PowerShell/PSScriptAnalyzer

X Title: PSSA should have a new rule to check for properly used Process blocks · Issue #1571 · PowerShell/PSScriptAnalyzer

Description: For some cases the formatter is changing code where it cannot run. Rules that trigger this are: PSUseConsistentWhitespace.CheckParameter when $True PSAvoidUsingCmdletAliases when $True The source script triggering this bug is not valid, ...

Open Graph Description: For some cases the formatter is changing code where it cannot run. Rules that trigger this are: PSUseConsistentWhitespace.CheckParameter when $True PSAvoidUsingCmdletAliases when $True The source s...

X Description: For some cases the formatter is changing code where it cannot run. Rules that trigger this are: PSUseConsistentWhitespace.CheckParameter when $True PSAvoidUsingCmdletAliases when $True The source s...

Opengraph URL: https://github.com/PowerShell/PSScriptAnalyzer/issues/1571

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PSSA should have a new rule to check for properly used Process blocks","articleBody":"For some cases the formatter is changing code where it cannot run. Rules that trigger this are:\r\n\r\n- `PSUseConsistentWhitespace.CheckParameter` when `$True`\r\n- `PSAvoidUsingCmdletAliases` when `$True`\r\n\r\nThe source script triggering this bug is not valid, however\r\n\r\n- the `PSAvoidUsingCmdletAliases`: `pwsh` **will execute** this with no errors (It runs normally, it never assigns `$x`)\r\n- the `CheckParameter`: This code is broken, `pwsh` **will not execute** this\r\n\r\n### Possible Cause of `PSAvoidUsingCmdletAliases`\r\n\r\n>From the docs: If your function defines a `Begin`, `Process` or `End` block, all of your code must reside inside those blocks. No code will be recognized outside the blocks if any of the blocks are defined.\r\n\r\nI think the cause is the script reaches a statement that is not inside a `begin/process/end` block -- so it assumes the function is a non-pipeline function. In that context, `process` is not a keyword but an identifier.  It replaces `process` with `Get-Process` (which would the correct behavior if it was a normal function)\r\n\r\n`Invoke-ScriptAnalyzer`  has the same behavior. \r\n\r\n![image](https://user-images.githubusercontent.com/25640518/90344893-3fd95780-dfe3-11ea-8db5-816d476f8465.png)\r\n\r\n### Potential fix for `PSAvoidUsingCmdletAliases` ?\r\n\r\n- PSSA should have a rule to check for functions that have code outside `begin/process/end` blocks. \r\n- Can the parser test if there are any `begin/process/end` statements, then treat it as a pipeline function?\r\n- Can the formatter abort if errors occur? (Right now there's no errors on mutation)\r\n\r\nSteps to reproduce\r\n------------------\r\n\r\n```PowerShell\r\n$script = @'\r\nfunction Do-Stuff {\r\n$x = 2\r\nProcess { }\r\n}\r\n'@\r\n$scriptFixed = @'\r\nfunction Do-Stuff {\r\n#$x = 2\r\nProcess { }\r\n}\r\n'@\r\n\r\n$settings = @{\r\n    IncludeRules = @('PSUseCorrectCasing', 'PSUseConsistentIndentation')\r\n    Rules        = @{\r\n        PSAvoidUsingCmdletAliases = @{\r\n            Enable = $false\r\n        }\r\n        PSUseConsistentIndentation = @{\r\n            Enable          = $true\r\n            Kind            = 'space'\r\n            PipelineIndentation = 'IncreaseIndentationAfterEveryPipeline'\r\n            IndentationSize = 4\r\n        }\r\n\r\n    }\r\n}\r\n\r\nInvoke-Formatter -ScriptDefinition $script -Settings $settings\r\nInvoke-Formatter -ScriptDefinition $scriptFixed -Settings $settings\r\n```\r\n\r\nExpected behavior\r\n-----------------\r\n\r\nIndent and replace aliases. \r\n\r\n```ps1\r\nfunction Do-Stuff {\r\n    $x = 2\r\n    Process { }\r\n}\r\n\r\nfunction Do-Stuff {\r\n    #$x = 2\r\n    Process { }\r\n}\r\n```\r\n\r\nActual behavior\r\n---------------\r\n\r\nIndent, and replaces keyword as if it was not in the keyword context.\r\n\r\n```ps1\r\nfunction Do-Stuff {\r\n    $x = 2\r\n    Get-Process { }\r\n}\r\n\r\nfunction Do-Stuff {\r\n    #$x = 2\r\n    Process { }\r\n}\r\n```\r\n\r\n### Another example not using pipeline functions\r\n\r\nSteps to reproduce\r\n------------------\r\n\r\n```\r\n$Original = @'\r\nFunction BadCode {\r\n    \"stuff\" | Format-CodeColor\" 'ps1'\r\n\r\n    $InputList | ForEach-Object {\r\n    } | Select-Object -First 2\r\n    | Join-String -sep \", \" -OutputPrefix 'Results: '\r\n}\r\n'@\r\n\r\n$settings = @{\r\n    IncludeRules = @(\r\n        \"PSUseConsistentWhitespace\"\r\n    )\r\n    Rules        = @{\r\n        PSUseConsistentWhitespace = @{\r\n            Enable         = $True\r\n            CheckParameter = $false\r\n        }\r\n    }\r\n}\r\n\r\n$out1 = Invoke-Formatter -ScriptDefinition $Original -Settings $settings\r\n\r\n$settings.rules.PSUseConsistentWhitespace.CheckParameter = $True\r\n$out2 = Invoke-Formatter -ScriptDefinition $Original -Settings $settings\r\n\r\n$out1\r\n'+' * 30\r\n$out2\r\n\r\nif ($out1 -ne $out2) {\r\n    Write-Error 'formatting does not match'\r\n}\r\n```\r\n\r\nExpected behavior 2\r\n-----------------\r\n\r\nGive an error, or don't mutate code\r\n\r\nActual behavior 2\r\n---------------\r\n\r\n```powershell\r\nFunction BadCode {\r\n    \"`nPS> Top | Bot | Se\" -OutputPrefix 'Results: '\r\n}\r\n```\r\n\r\nEnvironment data\r\n----------------\r\n\r\n\u003c!-- Provide the output of the following 2 commands -->\r\n\r\n```PowerShell\r\n>> $PSVersionTable | ft\r\n\r\nName                           Value\r\n----                           -----\r\nPSVersion                      7.0.3\r\nPSEdition                      Core\r\nGitCommitId                    7.0.3\r\nOS                             Microsoft Windows 10.0.19041\r\nPlatform                       Win32NT\r\nPSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}\r\nPSRemotingProtocolVersion      2.3\r\nSerializationVersion           1.1.0.1\r\nWSManStackVersion              3.0\r\n\r\n>> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }\r\n\r\n1.19.1\r\n\r\n>> $psEditor | select EditorServicesVersion\r\n\r\nEditorServicesVersion\r\n---------------------\r\n2.3.0.0\r\n\r\n```\r\n\r\n","author":{"url":"https://github.com/jbolton-corvalgroup","@type":"Person","name":"jbolton-corvalgroup"},"datePublished":"2020-08-16T23:58:08Z","url":"https://github.com/PowerShell/PSScriptAnalyzer/issues/1571"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f748732e-cf3b-6fb5-b166-90304cb5eed7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA6A6:218437:3A54C2:4CF373:6AFCE749
html-safe-nonce28474ec380a67770db850561168914cfc2ed5b705d88a48b4cae174f82124c05
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE2OjIxODQzNzozQTU0QzI6NENGMzczOjZBRkNFNzQ5IiwidmlzaXRvcl9pZCI6IjE1NTk1MzkwMzExMTUzNjAwNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace1db600241c9ffb1a67f2057eeeec1d0533181c2dc2dd217b7e0153b435962ec
hovercard-subject-tagissue:679853310
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PSScriptAnalyzer/1571/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f63706f680c5b592aaa99cde107f9afca159d87feb6abdda44b55a7de97f054c/PowerShell/PSScriptAnalyzer/issues/1571
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f63706f680c5b592aaa99cde107f9afca159d87feb6abdda44b55a7de97f054c/PowerShell/PSScriptAnalyzer/issues/1571
og:image:altFor some cases the formatter is changing code where it cannot run. Rules that trigger this are: PSUseConsistentWhitespace.CheckParameter when $True PSAvoidUsingCmdletAliases when $True The source s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbolton-corvalgroup
hostnamegithub.com
expected-hostnamegithub.com
None99aede4c5f55ec5cf06666a8c9e03ebf9f85f7231223e7f1c38c16e5504835b3
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/PSScriptAnalyzer git https://github.com/PowerShell/PSScriptAnalyzer.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id33149177
octolytics-dimension-repository_nwoPowerShell/PSScriptAnalyzer
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33149177
octolytics-dimension-repository_network_root_nwoPowerShell/PSScriptAnalyzer
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseecfd63ca125ec74b42f74eeb158b3fa081c8c497
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/PSScriptAnalyzer/issues/1571#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2F1571
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPSScriptAnalyzer%2Fissues%2F1571
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FPSScriptAnalyzer
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Reloadhttps://github.com/PowerShell/PSScriptAnalyzer/issues/1571
PowerShellhttps://github.com/PowerShell
PSScriptAnalyzerhttps://github.com/PowerShell/PSScriptAnalyzer
Codehttps://github.com/PowerShell/PSScriptAnalyzer
Issues407 (407)https://github.com/PowerShell/PSScriptAnalyzer/issues
Pull requests34 (34)https://github.com/PowerShell/PSScriptAnalyzer/pulls
Discussionshttps://github.com/PowerShell/PSScriptAnalyzer/discussions
Actionshttps://github.com/PowerShell/PSScriptAnalyzer/actions
Projectshttps://github.com/PowerShell/PSScriptAnalyzer/projects
Wikihttps://github.com/PowerShell/PSScriptAnalyzer/wiki
Security and qualityhttps://github.com/PowerShell/PSScriptAnalyzer/security
Insightshttps://github.com/PowerShell/PSScriptAnalyzer/insights
https://github.com/PowerShell/PSScriptAnalyzer
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
PSSA should have a new rule to check for properly used Process blockshttps://github.com/PowerShell/PSScriptAnalyzer/issues/1571#top
Area - Ruleshttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20Rules%22
Issue - New Rulehttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20New%20Rule%22
https://github.com/jbolton-corvalgroup
jbolton-corvalgrouphttps://github.com/jbolton-corvalgroup
on Aug 16, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#issue-679853310
https://user-images.githubusercontent.com/25640518/90344893-3fd95780-dfe3-11ea-8db5-816d476f8465.png
Needs: Triage 🔍https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Needs%3A%20Triage%20%3Amag%3A%22
on Aug 16, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#event-3659742646
https://github.com/ninmonkey
Jake Bolton (ninmonkey)https://github.com/ninmonkey
on Aug 17, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#issuecomment-674595860
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
on Aug 18, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#issuecomment-675625159
Sydney Smith (SydneyhSmith)https://github.com/SydneyhSmith
on Aug 18, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#event-3667485755
Sydney Smith (SydneyhSmith)https://github.com/SydneyhSmith
Area - Ruleshttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20Rules%22
Issue - New Rulehttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20New%20Rule%22
Needs: Triage 🔍https://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Needs%3A%20Triage%20%3Amag%3A%22
on Aug 18, 2020https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#event-3667486792
https://github.com/ninmonkey
Jake Bolton (ninmonkey)https://github.com/ninmonkey
on Sep 5, 2021https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#issuecomment-913065700
Rob Holt (@rjmholt)https://github.com/rjmholt
#1638https://github.com/PowerShell/PSScriptAnalyzer/pull/1638
Andy Jordan (andyleejordan)https://github.com/andyleejordan
American Pharoah https://github.com/orgs/PowerShell/projects/5
on May 16, 2022https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#event-15236513201
Andy Jordan (andyleejordan)https://github.com/andyleejordan
American Pharoah https://github.com/orgs/PowerShell/projects/5
on May 16, 2022https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Sydney Smith (SydneyhSmith)https://github.com/SydneyhSmith
American Pharoah https://github.com/orgs/PowerShell/projects/5
on Jul 13, 2022https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Sydney Smith (SydneyhSmith)https://github.com/SydneyhSmith
completedhttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 6, 2022https://github.com/PowerShell/PSScriptAnalyzer/issues/1571#event-7332491055
American Pharoah https://github.com/orgs/PowerShell/projects/5
on Sep 6, 2022https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/PSScriptAnalyzer/issues/1571
Area - Ruleshttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Area%20-%20Rules%22
Issue - New Rulehttps://github.com/PowerShell/PSScriptAnalyzer/issues?q=state%3Aopen%20label%3A%22Issue%20-%20New%20Rule%22
American Pharoah Closedhttps://github.com/orgs/PowerShell/projects/5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.