René's URL Explorer Experiment


Title: incorrect assertions in test specs · Issue #176 · PowerShell/EditorSyntax · GitHub

Open Graph Title: incorrect assertions in test specs · Issue #176 · PowerShell/EditorSyntax

X Title: incorrect assertions in test specs · Issue #176 · PowerShell/EditorSyntax

Description: This is to point out some incorrect assertions in the spec tests. EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1 Lines 428 to 430 in 44eac87 3++2 # ^ ^^ constant.numeric.integer.powershell # ^ keyword.operator.assignment.powe...

Open Graph Description: This is to point out some incorrect assertions in the spec tests. EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1 Lines 428 to 430 in 44eac87 3++2 # ^ ^^ constant.numeric.integer.powersh...

X Description: This is to point out some incorrect assertions in the spec tests. EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1 Lines 428 to 430 in 44eac87 3++2 # ^ ^^ constant.numeric.integer.powersh...

Opengraph URL: https://github.com/PowerShell/EditorSyntax/issues/176

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"incorrect assertions in test specs","articleBody":"This is to point out some incorrect assertions in the spec tests.\r\n\r\nhttps://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L428-L430\r\n\r\nThe `++` is actually the unary increment operator, and PowerShell will flag this as an error because it cannot be used on a constant.\r\n![image](https://user-images.githubusercontent.com/26179051/57748613-525a3800-76a0-11e9-98fe-c4bf88e9d2ed.png)\r\n\r\nhttps://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L569-L571\r\n\r\nThese are not operators in these instances, so even though the grammar scopes them as such, asserting these tests is misleading and will require correcting when the grammar is improved.  This is covered in issue #112.\r\n\r\nhttps://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L771-L776\r\n\r\nThe `#` is this spec is not a line comment token.  Its actually part of an unquoted non-expanding string that describes a function/command name.  This is covered in issue #62.\r\n\r\n(Example under PR #156)\r\n![image](https://user-images.githubusercontent.com/26179051/57748968-c8ab6a00-76a1-11e9-9f50-917af4f94d78.png)\r\n\r\nhttps://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L1181-L1187\r\n\r\nLine 1186 specs the `$` as `definition.variable`.  This is covered in  issue #132.\r\n\r\n(Example under PR #156 I have scoped it as `punctuation.section.embedded.begin`)\r\n![image](https://user-images.githubusercontent.com/26179051/57749248-e62d0380-76a2-11e9-869e-338273196d74.png)\r\n\r\nThis might only be a partial listing.   This is some of the specs I am constantly looking at when checking my work.  I list these more so that others can avoid needing to question these.\r\n\r\n\r\n","author":{"url":"https://github.com/msftrncs","@type":"Person","name":"msftrncs"},"datePublished":"2019-05-15T05:00:48Z","url":"https://github.com/PowerShell/EditorSyntax/issues/176"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1c82d861-590a-722b-97ef-8c9af0b3c972
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9FD2:208520:14187C:1C6B18:6AFE0F2D
html-safe-nonce349fa600ef99ecfab5f547ea124f494fdabdc479eeef6f4d2c840b3796358303
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkQyOjIwODUyMDoxNDE4N0M6MUM2QjE4OjZBRkUwRjJEIiwidmlzaXRvcl9pZCI6IjMxMzI5NTc0Mjc2NDE0ODcxNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5059f7fa60cd81b41e428aafed209a50a0383dadb32e63250cc83beb66e29801
hovercard-subject-tagissue:444237138
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/EditorSyntax/176/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bfd552f44b1124d8783390e62b868188480488f9588e7a205aef52d6aa06a453/PowerShell/EditorSyntax/issues/176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfd552f44b1124d8783390e62b868188480488f9588e7a205aef52d6aa06a453/PowerShell/EditorSyntax/issues/176
og:image:altThis is to point out some incorrect assertions in the spec tests. EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1 Lines 428 to 430 in 44eac87 3++2 # ^ ^^ constant.numeric.integer.powersh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsftrncs
hostnamegithub.com
expected-hostnamegithub.com
None1fd4053be37b4bd545b4f38f1cecad058c343776acf2cbc6806316f26270e55e
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/EditorSyntax git https://github.com/PowerShell/EditorSyntax.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id59601299
octolytics-dimension-repository_nwoPowerShell/EditorSyntax
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id59601299
octolytics-dimension-repository_network_root_nwoPowerShell/EditorSyntax
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release635a57b3d0df6bc21c0f39fc7078888fb90e4066
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/EditorSyntax/issues/176#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FEditorSyntax%2Fissues%2F176
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FEditorSyntax%2Fissues%2F176
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FEditorSyntax
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/176
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/176
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/176
PowerShellhttps://github.com/PowerShell
EditorSyntaxhttps://github.com/PowerShell/EditorSyntax
Codehttps://github.com/PowerShell/EditorSyntax
Issues69 (69)https://github.com/PowerShell/EditorSyntax/issues
Pull requests5 (5)https://github.com/PowerShell/EditorSyntax/pulls
Actionshttps://github.com/PowerShell/EditorSyntax/actions
Projectshttps://github.com/PowerShell/EditorSyntax/projects
Wikihttps://github.com/PowerShell/EditorSyntax/wiki
Security and qualityhttps://github.com/PowerShell/EditorSyntax/security
Insightshttps://github.com/PowerShell/EditorSyntax/insights
https://github.com/PowerShell/EditorSyntax
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/176
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/176
incorrect assertions in test specshttps://github.com/PowerShell/EditorSyntax/issues/176#top
https://github.com/msftrncs
Carl Morris (msftrncs)https://github.com/msftrncs
on May 15, 2019https://github.com/PowerShell/EditorSyntax/issues/176#issue-444237138
EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L428-L430
44eac87https://github.com/PowerShell/EditorSyntax/commit/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc
https://user-images.githubusercontent.com/26179051/57748613-525a3800-76a0-11e9-98fe-c4bf88e9d2ed.png
EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L569-L571
44eac87https://github.com/PowerShell/EditorSyntax/commit/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc
#112https://github.com/PowerShell/EditorSyntax/issues/112
EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L771-L776
44eac87https://github.com/PowerShell/EditorSyntax/commit/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc
#62https://github.com/PowerShell/EditorSyntax/issues/62
#156https://github.com/PowerShell/EditorSyntax/pull/156
https://user-images.githubusercontent.com/26179051/57748968-c8ab6a00-76a1-11e9-9f50-917af4f94d78.png
EditorSyntax/spec/testfiles/syntax_test_TheBigTestFile.ps1https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L1181-L1187
44eac87https://github.com/PowerShell/EditorSyntax/commit/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc
#132https://github.com/PowerShell/EditorSyntax/issues/132
#156https://github.com/PowerShell/EditorSyntax/pull/156
https://user-images.githubusercontent.com/26179051/57749248-e62d0380-76a2-11e9-869e-338273196d74.png
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/EditorSyntax/issues/176
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/176
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.