René's URL Explorer Experiment


Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax · GitHub

Open Graph Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax

X Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax

Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch...

Open Graph Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I...

X Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every them...

Opengraph URL: https://github.com/PowerShell/EditorSyntax/issues/129

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Issues with Insiders changes and themes","articleBody":"\r\n\r\n### Environment\r\n\r\n- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider\r\n- Your primary theme: Microsoft's Monokai\r\n\r\n### Issue Description\r\n\r\nWith the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those. \r\n\r\nIf you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.\r\n\r\nI don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living. \r\n\r\n#### Screenshots\r\n\r\nInsiders\r\n![2018-08-13_10-51-17](https://user-images.githubusercontent.com/6662208/44050661-4713bafa-9efd-11e8-988c-f431fe7f0332.png)\r\n\r\nStable\r\n![2018-08-13_10-52-55](https://user-images.githubusercontent.com/6662208/44050674-5221ff2e-9efd-11e8-8ff7-3fcae76c7a19.png)\r\n\r\nInsiders\r\n![2018-08-13_11-00-08](https://user-images.githubusercontent.com/6662208/44050704-64871654-9efd-11e8-8508-88f2a44b342c.png)\r\n\r\nStable\r\n![2018-08-13_10-59-30](https://user-images.githubusercontent.com/6662208/44050711-6c19e9dc-9efd-11e8-8fb2-2fc85e48afce.png)\r\n\r\nInsiders\r\n![2018-08-13_11-00-57](https://user-images.githubusercontent.com/6662208/44050725-749f9250-9efd-11e8-94e4-e2b7734d4b06.png)\r\n\r\nStable\r\n![2018-08-13_11-01-30](https://user-images.githubusercontent.com/6662208/44050730-7ab3811a-9efd-11e8-8fea-6854626ff1d1.png)\r\n\r\n\r\n\r\n### Expected Behavior\r\n\r\nUsers expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.\r\n\r\nIf you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.\r\n\r\n","author":{"url":"https://github.com/gerane","@type":"Person","name":"gerane"},"datePublished":"2018-08-13T18:39:58Z","url":"https://github.com/PowerShell/EditorSyntax/issues/129"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e1235810-3f12-9ddb-9d01-2c9272c6dddf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD298:3F9E0A:C7703:117A89:6AFE140B
html-safe-nonced134d3fd584af02888c85097f44b8e0c6072874b8e1d3691330eadff1d692a34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjk4OjNGOUUwQTpDNzcwMzoxMTdBODk6NkFGRTE0MEIiLCJ2aXNpdG9yX2lkIjoiMzAxMTU2Mzg4Nzg3MTc5MjEzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacad55718fcdfc84f04fc0725305f4df7035a042edad1df03ddd472555de6cbb37
hovercard-subject-tagissue:350145356
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/EditorSyntax/129/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c259b78c144275c9ce29e9e50e8d8904dbfe80f19a523d4b2e096a22030983e5/PowerShell/EditorSyntax/issues/129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c259b78c144275c9ce29e9e50e8d8904dbfe80f19a523d4b2e096a22030983e5/PowerShell/EditorSyntax/issues/129
og:image:altEnvironment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegerane
hostnamegithub.com
expected-hostnamegithub.com
None3cd8a1d79ccbf9aecac62781f79072482a49047fb982b8c9e2ad4aca8bf6a9af
turbo-cache-controlno-preview
go-importgithub.com/PowerShell/EditorSyntax git https://github.com/PowerShell/EditorSyntax.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id59601299
octolytics-dimension-repository_nwoPowerShell/EditorSyntax
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id59601299
octolytics-dimension-repository_network_root_nwoPowerShell/EditorSyntax
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05539640a34afe6142a519483d78ddd766a1304a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/PowerShell/EditorSyntax/issues/129#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FEditorSyntax%2Fissues%2F129
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FEditorSyntax%2Fissues%2F129
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=PowerShell%2FEditorSyntax
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/129
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/129
Reloadhttps://github.com/PowerShell/EditorSyntax/issues/129
PowerShellhttps://github.com/PowerShell
EditorSyntaxhttps://github.com/PowerShell/EditorSyntax
Codehttps://github.com/PowerShell/EditorSyntax
Issues69 (69)https://github.com/PowerShell/EditorSyntax/issues
Pull requests5 (5)https://github.com/PowerShell/EditorSyntax/pulls
Actionshttps://github.com/PowerShell/EditorSyntax/actions
Projectshttps://github.com/PowerShell/EditorSyntax/projects
Wikihttps://github.com/PowerShell/EditorSyntax/wiki
Security and qualityhttps://github.com/PowerShell/EditorSyntax/security
Insightshttps://github.com/PowerShell/EditorSyntax/insights
https://github.com/PowerShell/EditorSyntax
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/129
New issuehttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/129
Issues with Insiders changes and themeshttps://github.com/PowerShell/EditorSyntax/issues/129#top
https://github.com/gerane
Brandon Padgett (gerane)https://github.com/gerane
on Aug 13, 2018https://github.com/PowerShell/EditorSyntax/issues/129#issue-350145356
David Wilson (@daviwil)https://github.com/daviwil
Øyvind Kallstad (@gravejester)https://github.com/gravejester
https://user-images.githubusercontent.com/6662208/44050661-4713bafa-9efd-11e8-988c-f431fe7f0332.png
https://user-images.githubusercontent.com/6662208/44050674-5221ff2e-9efd-11e8-8ff7-3fcae76c7a19.png
https://user-images.githubusercontent.com/6662208/44050704-64871654-9efd-11e8-8508-88f2a44b342c.png
https://user-images.githubusercontent.com/6662208/44050711-6c19e9dc-9efd-11e8-8fb2-2fc85e48afce.png
https://user-images.githubusercontent.com/6662208/44050725-749f9250-9efd-11e8-94e4-e2b7734d4b06.png
https://user-images.githubusercontent.com/6662208/44050730-7ab3811a-9efd-11e8-8fea-6854626ff1d1.png
Sign up for freehttps://github.com/signup?return_to=https://github.com/PowerShell/EditorSyntax/issues/129
Sign in to commenthttps://github.com/login?return_to=https://github.com/PowerShell/EditorSyntax/issues/129
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.