Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax · GitHub
Open Graph Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax
X Title: Issues with Insiders changes and themes · Issue #129 · PowerShell/EditorSyntax
Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch...
Open Graph Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I...
X Description: Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every them...
Opengraph URL: https://github.com/PowerShell/EditorSyntax/issues/129
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Issues with Insiders changes and themes","articleBody":"\r\n\r\n### Environment\r\n\r\n- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider\r\n- Your primary theme: Microsoft's Monokai\r\n\r\n### Issue Description\r\n\r\nWith the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those. \r\n\r\nIf you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.\r\n\r\nI don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living. \r\n\r\n#### Screenshots\r\n\r\nInsiders\r\n\r\n\r\nStable\r\n\r\n\r\nInsiders\r\n\r\n\r\nStable\r\n\r\n\r\nInsiders\r\n\r\n\r\nStable\r\n\r\n\r\n\r\n\r\n### Expected Behavior\r\n\r\nUsers expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.\r\n\r\nIf you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.\r\n\r\n","author":{"url":"https://github.com/gerane","@type":"Person","name":"gerane"},"datePublished":"2018-08-13T18:39:58Z","url":"https://github.com/PowerShell/EditorSyntax/issues/129"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e1235810-3f12-9ddb-9d01-2c9272c6dddf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D298:3F9E0A:C7703:117A89:6AFE140B |
| html-safe-nonce | d134d3fd584af02888c85097f44b8e0c6072874b8e1d3691330eadff1d692a34 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjk4OjNGOUUwQTpDNzcwMzoxMTdBODk6NkFGRTE0MEIiLCJ2aXNpdG9yX2lkIjoiMzAxMTU2Mzg4Nzg3MTc5MjEzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ad55718fcdfc84f04fc0725305f4df7035a042edad1df03ddd472555de6cbb37 |
| hovercard-subject-tag | issue:350145356 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/EditorSyntax/129/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c259b78c144275c9ce29e9e50e8d8904dbfe80f19a523d4b2e096a22030983e5/PowerShell/EditorSyntax/issues/129 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c259b78c144275c9ce29e9e50e8d8904dbfe80f19a523d4b2e096a22030983e5/PowerShell/EditorSyntax/issues/129 |
| og:image:alt | Environment Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider Your primary theme: Microsoft's Monokai Issue Description With the changes to the syntax it breaks most every theme. I... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gerane |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3cd8a1d79ccbf9aecac62781f79072482a49047fb982b8c9e2ad4aca8bf6a9af |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/EditorSyntax git https://github.com/PowerShell/EditorSyntax.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 59601299 |
| octolytics-dimension-repository_nwo | PowerShell/EditorSyntax |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 59601299 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/EditorSyntax |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 05539640a34afe6142a519483d78ddd766a1304a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width