Title: Cleanup targets.py · Issue #54 · PPPLDeepLearning/plasma-python · GitHub
Open Graph Title: Cleanup targets.py · Issue #54 · PPPLDeepLearning/plasma-python
X Title: Cleanup targets.py · Issue #54 · PPPLDeepLearning/plasma-python
Description: Consider renaming TTDTarget to LogTTDTarget for clarity 7x threshold_range() class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/plasma-python/blob/v0.9/plasma/utils/perfor...
Open Graph Description: Consider renaming TTDTarget to LogTTDTarget for clarity 7x threshold_range() class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/pla...
X Description: Consider renaming TTDTarget to LogTTDTarget for clarity 7x threshold_range() class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/pla...
Opengraph URL: https://github.com/PPPLDeepLearning/plasma-python/issues/54
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cleanup targets.py","articleBody":"- [ ] Consider renaming `TTDTarget` to `LogTTDTarget` for clarity\r\n- [ ] 7x `threshold_range()` class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/plasma-python/blob/v0.9/plasma/utils/performance.py\r\n- [ ] `MaxHingeTarget.loss()` (method unique to that class) is unused\r\n- [ ] Base class `Target` is an invalid configuration option (predicts TTD directly, without the 0 mask before `T_warning` like in `TTDLinearTarget`?)\r\n\r\nRelated to #53, and the broader efforts of #42. \r\n","author":{"url":"https://github.com/felker","@type":"Person","name":"felker"},"datePublished":"2020-01-06T20:05:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/54/plasma-python/issues/54"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e5499282-8b02-22e1-ff92-b69e68c46ddb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8ADC:11B3A2:3B0889:4CDBB0:698E68AD |
| html-safe-nonce | 0b1bad1b4fd15a664d7f3e8928838fb735c582f92f0da2f76fc83e99c6027368 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QURDOjExQjNBMjozQjA4ODk6NENEQkIwOjY5OEU2OEFEIiwidmlzaXRvcl9pZCI6IjY0MzQ2MzU1MzEyMjEzNjI4NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6b8697d96bda95592a1064aeafa4183b9b619cbb820b9a3b0bdf59ea43ad7a7d |
| hovercard-subject-tag | issue:545914450 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PPPLDeepLearning/plasma-python/54/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3f4e4cdc3169137b3cf888f9e08a7f6d814df4483a1e8af1718a5898ba3193e6/PPPLDeepLearning/plasma-python/issues/54 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3f4e4cdc3169137b3cf888f9e08a7f6d814df4483a1e8af1718a5898ba3193e6/PPPLDeepLearning/plasma-python/issues/54 |
| og:image:alt | Consider renaming TTDTarget to LogTTDTarget for clarity 7x threshold_range() class methods are never called anywhere. Vestige of old ROC calculation, e.g. in https://github.com/PPPLDeepLearning/pla... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | felker |
| hostname | github.com |
| expected-hostname | github.com |
| None | 666e30cc1de8ebdf458084bf731e95deba4f074a5008f91b50803aa9a71e3725 |
| turbo-cache-control | no-preview |
| go-import | github.com/PPPLDeepLearning/plasma-python git https://github.com/PPPLDeepLearning/plasma-python.git |
| octolytics-dimension-user_id | 23219101 |
| octolytics-dimension-user_login | PPPLDeepLearning |
| octolytics-dimension-repository_id | 72968591 |
| octolytics-dimension-repository_nwo | PPPLDeepLearning/plasma-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 72968591 |
| octolytics-dimension-repository_network_root_nwo | PPPLDeepLearning/plasma-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5daa44975c44e187dd9ea0d761c37973489d508 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width