Title: Fix for #210: Removed target attribute from some links. by Nickatak · Pull Request #227 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io · GitHub
Open Graph Title: Fix for #210: Removed target attribute from some links. by Nickatak · Pull Request #227 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io
X Title: Fix for #210: Removed target attribute from some links. by Nickatak · Pull Request #227 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io
Description: Checklist My branch is up-to-date with the upstream predev branch. I have added necessary documentation (if appropriate). Which issue does this PR fix?: Fixes issue #210 (links undesirably opening in new tab). This PR removes the target attribute entirely for each anchor tag mentioned in issue 210 inside /oshc/main/templates/base.html. To allow for consistency, I opted to completely remove the target attribute so that it matches other in-tab-opening links on the same page. This removal has been applied to the following links: Request a Session (under the Session drop-down of the nav-bar) Contests (on the nav-bar) Journey (in the footer, the flower-box emblem) Why do we need this PR?: UI/UX alteration to provide for favorable user interaction (altered links don't open in new tab when they don't need to). Testing instructions: I have taken the following steps, and am leaving them unchecked below for you to use: Create a virtual environment (and activate it) Clone the forked repository. Update to predev branch if you haven't [I don't know whether git saved that or not] (git fetch https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/predev) Install pre-commit collectstatic (python manage.py collectstatic) Run development server (python manage.py runserver) Click on altered links in order to verify desired functionality. TODOs (if any): None A picture of a cute animal (not mandatory but encouraged): Old but good:
Open Graph Description: Checklist My branch is up-to-date with the upstream predev branch. I have added necessary documentation (if appropriate). Which issue does this PR fix?: Fixes issue #210 (links undesirably open...
X Description: Checklist My branch is up-to-date with the upstream predev branch. I have added necessary documentation (if appropriate). Which issue does this PR fix?: Fixes issue #210 (links undesirably open...
Opengraph URL: https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/pull/227
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:35f8b29f-70fa-d458-b18c-4cf96b9b3c7e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F8E:2F8DA5:BE0A8F:103CFC9:6A619CBB |
| html-safe-nonce | b89ead1b792daf19ab8d118d7b7e272086c5e096c5d599cae00774d42ae300c6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjhFOjJGOERBNTpCRTBBOEY6MTAzQ0ZDOTo2QTYxOUNCQiIsInZpc2l0b3JfaWQiOiI3OTQ2NDUzNTQ4Mjk2OTM2NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0bc4f2710b6c73fee389d932a2bed44c67d444bff0e9f323d40f968d0b70ac6b |
| hovercard-subject-tag | pull_request:161765441 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/pull/227/files |
| twitter:image | https://avatars.githubusercontent.com/u/9625968?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9625968?s=400&v=4 |
| og:image:alt | Checklist My branch is up-to-date with the upstream predev branch. I have added necessary documentation (if appropriate). Which issue does this PR fix?: Fixes issue #210 (links undesirably open... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io git https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io.git |
| octolytics-dimension-user_id | 23719480 |
| octolytics-dimension-user_login | OpenSourceHelpCommunity |
| octolytics-dimension-repository_id | 89073455 |
| octolytics-dimension-repository_nwo | OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 89073455 |
| octolytics-dimension-repository_network_root_nwo | OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd05235d52ffb3318513d883a56c87a121015c8b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width