| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8279a959-2e70-5d54-bd53-34c18d3dfe1c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D356:1F1E93:1B745EF:27CCDE4:6A4BC828 |
| html-safe-nonce | 9988897f164c23e140d655b7f63175dca040ba67384ce2251f6abc187ad598b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzU2OjFGMUU5MzoxQjc0NUVGOjI3Q0NERTQ6NkE0QkM4MjgiLCJ2aXNpdG9yX2lkIjoiODM3MDA4OTM4Njk5ODIyMDg0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fb148964945aeecaebecdcfc1f499c860aedcae95902f465bb864a829cd75386 |
| hovercard-subject-tag | pull_request:1327123165 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/OpenModelica/OMSimulator/1214/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0ce71fee51bd62a017652be3a6a6311b9abcbb346ad1a9ba96487f84a831e148/OpenModelica/OMSimulator/pull/1214 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0ce71fee51bd62a017652be3a6a6311b9abcbb346ad1a9ba96487f84a831e148/OpenModelica/OMSimulator/pull/1214 |
| og:image:alt | Related Issues
Fixes #1213.
Purpose
Fix endless loop of broken FMUs where error test can't be satisfied.
Approach
If integrator CVode in oms::SystemSC::doStep() fails return an error. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AnHeuermann |
| hostname | github.com |
| expected-hostname | github.com |
| None | 14aa00ce5bdb34d0eefb5facbffd7de9e144c688d8a93ef8df902d5f94b51dd7 |
| turbo-cache-control | no-cache |
| go-import | github.com/OpenModelica/OMSimulator git https://github.com/OpenModelica/OMSimulator.git |
| octolytics-dimension-user_id | 4006504 |
| octolytics-dimension-user_login | OpenModelica |
| octolytics-dimension-repository_id | 111417328 |
| octolytics-dimension-repository_nwo | OpenModelica/OMSimulator |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111417328 |
| octolytics-dimension-repository_network_root_nwo | OpenModelica/OMSimulator |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 58b8f89190447502561829f30862aa0a99d53367 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/OpenModelica/OMSimulator/pull/1214#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenModelica%2FOMSimulator%2Fpull%2F1214 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenModelica%2FOMSimulator%2Fpull%2F1214 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=OpenModelica%2FOMSimulator |
| Reload | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| Reload | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| Reload | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
|
OpenModelica
| https://github.com/OpenModelica |
| OMSimulator | https://github.com/OpenModelica/OMSimulator |
|
Notifications
| https://github.com/login?return_to=%2FOpenModelica%2FOMSimulator |
|
Fork
60
| https://github.com/login?return_to=%2FOpenModelica%2FOMSimulator |
|
Star
95
| https://github.com/login?return_to=%2FOpenModelica%2FOMSimulator |
|
Code
| https://github.com/OpenModelica/OMSimulator |
|
Issues
65
| https://github.com/OpenModelica/OMSimulator/issues |
|
Pull requests
11
| https://github.com/OpenModelica/OMSimulator/pulls |
|
Discussions
| https://github.com/OpenModelica/OMSimulator/discussions |
|
Actions
| https://github.com/OpenModelica/OMSimulator/actions |
|
Projects
| https://github.com/OpenModelica/OMSimulator/projects |
|
Security and quality
0
| https://github.com/OpenModelica/OMSimulator/security |
|
Insights
| https://github.com/OpenModelica/OMSimulator/pulse |
|
Code
| https://github.com/OpenModelica/OMSimulator |
|
Issues
| https://github.com/OpenModelica/OMSimulator/issues |
|
Pull requests
| https://github.com/OpenModelica/OMSimulator/pulls |
|
Discussions
| https://github.com/OpenModelica/OMSimulator/discussions |
|
Actions
| https://github.com/OpenModelica/OMSimulator/actions |
|
Projects
| https://github.com/OpenModelica/OMSimulator/projects |
|
Security and quality
| https://github.com/OpenModelica/OMSimulator/security |
|
Insights
| https://github.com/OpenModelica/OMSimulator/pulse |
| lochel | https://github.com/lochel |
| OpenModelica:maintenance/v2.1 | https://github.com/OpenModelica/OMSimulator/tree/maintenance/v2.1 |
| AnHeuermann:throw-doStep | https://github.com/AnHeuermann/OMSimulator/tree/throw-doStep |
| Conversation | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| Commits2 (2) | https://github.com/OpenModelica/OMSimulator/pull/1214/commits |
| Checks | https://github.com/OpenModelica/OMSimulator/pull/1214/checks |
| Files changed | https://github.com/OpenModelica/OMSimulator/pull/1214/files |
| Return error if CVODE failed | https://github.com/OpenModelica/OMSimulator/pull/1214#top |
| lochel | https://github.com/lochel |
| OpenModelica:maintenance/v2.1 | https://github.com/OpenModelica/OMSimulator/tree/maintenance/v2.1 |
| AnHeuermann:throw-doStep | https://github.com/AnHeuermann/OMSimulator/tree/throw-doStep |
|
| https://github.com/AnHeuermann |
| AnHeuermann | https://github.com/AnHeuermann |
| Apr 25, 2023 | https://github.com/OpenModelica/OMSimulator/pull/1214#issue-1683155522 |
| #1213 | https://github.com/OpenModelica/OMSimulator/issues/1213 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| https://github.com/AnHeuermann |
| AnHeuermann | https://github.com/AnHeuermann |
| arun3688 | https://github.com/arun3688 |
| April 25, 2023 14:31 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-9093175625 |
| https://github.com/AnHeuermann |
| AnHeuermann | https://github.com/AnHeuermann |
| Apr 27, 2023 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-9111918475 |
| https://github.com/AnHeuermann |
| AnHeuermann | https://github.com/AnHeuermann |
| force-pushed | https://github.com/OpenModelica/OMSimulator/compare/affd5baf7ae94160b348ea2d740df5250cd34bf1..38720378ac474ecbf3f3aa9d496f4aa9ec2d90b0 |
| affd5ba | https://github.com/OpenModelica/OMSimulator/commit/affd5baf7ae94160b348ea2d740df5250cd34bf1 |
| 3872037 | https://github.com/OpenModelica/OMSimulator/commit/38720378ac474ecbf3f3aa9d496f4aa9ec2d90b0 |
|
Compare
| https://github.com/OpenModelica/OMSimulator/compare/affd5baf7ae94160b348ea2d740df5250cd34bf1..38720378ac474ecbf3f3aa9d496f4aa9ec2d90b0 |
| April 27, 2023 09:06 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-9111955408 |
|
| https://github.com/AnHeuermann |
| Return error if CVODE failed | https://github.com/OpenModelica/OMSimulator/pull/1214/commits/38720378ac474ecbf3f3aa9d496f4aa9ec2d90b0 |
| 3872037 | https://github.com/OpenModelica/OMSimulator/pull/1214/commits/38720378ac474ecbf3f3aa9d496f4aa9ec2d90b0 |
| https://github.com/CLAassistant |
| CLAassistant | https://github.com/CLAassistant |
| Oct 5, 2023 | https://github.com/OpenModelica/OMSimulator/pull/1214#issuecomment-1748648801 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| https://cla-assistant.io/OpenModelica/OMSimulator?pullRequest=1214 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| Nov 9, 2024 | https://github.com/OpenModelica/OMSimulator/pull/1214#issuecomment-2466308016 |
| @AnHeuermann | https://github.com/AnHeuermann |
| @arun3688 | https://github.com/arun3688 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| Nov 11, 2024 | https://github.com/OpenModelica/OMSimulator/pull/1214#issuecomment-2467746897 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| lochel | https://github.com/lochel |
| AnHeuermann | https://github.com/AnHeuermann |
| Nov 12, 2024 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-15269577644 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| November 15, 2024 08:47 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-15309300156 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| arun3688 | https://github.com/arun3688 |
| November 15, 2024 08:47 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-15309301895 |
|
| https://github.com/lochel |
| Merge branch 'maintenance/v2.1' into throw-doStep | https://github.com/OpenModelica/OMSimulator/pull/1214/commits/b15e647b1c0d7f18a53c24cf2e49992ea949c306 |
| b15e647 | https://github.com/OpenModelica/OMSimulator/pull/1214/commits/b15e647b1c0d7f18a53c24cf2e49992ea949c306 |
| https://github.com/lochel |
| lochel | https://github.com/lochel |
| 7bd5b8a | https://github.com/OpenModelica/OMSimulator/commit/7bd5b8ac56a16c71364156ad7d4130c60c43d0de |
| Nov 15, 2024 | https://github.com/OpenModelica/OMSimulator/pull/1214#event-15309435096 |
| https://github.co/hiddenchars |
| https://github.com/OpenModelica/OMSimulator/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenModelica%2FOMSimulator%2Fpull%2F1214 |
|
| https://github.com/lochel |
|
lochel
| https://github.com/lochel |
|
CVode error doesn't stop simulation / infinite loop
| https://github.com/OpenModelica/OMSimulator/issues/1213 |
| Please reload this page | https://github.com/OpenModelica/OMSimulator/pull/1214 |
|
| https://github.com/AnHeuermann |
|
| https://github.com/CLAassistant |
|
| https://github.com/lochel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |