René's URL Explorer Experiment


Title: honour response charset in gson and jackson iterator decoders by alhudz · Pull Request #3447 · OpenFeign/feign · GitHub

Open Graph Title: honour response charset in gson and jackson iterator decoders by alhudz · Pull Request #3447 · OpenFeign/feign

X Title: honour response charset in gson and jackson iterator decoders by alhudz · Pull Request #3447 · OpenFeign/feign

Description: Repro: a server response with Content-Type: application/json; charset=ISO-8859-1 and an ISO-8859-1 encoded body decoded through GsonDecoder, JacksonIteratorDecoder or Jackson3IteratorDecoder. Cause: those three read the body with asReader(UTF_8), dropping response.charset(), so non-ASCII bytes come back as U+FFFD. The sibling JacksonDecoder, Jackson3Decoder, Fastjson2Decoder, JacksonJrDecoder and JsonDecoder already pass response.charset(). Fix: pass response.charset() in the three decoders, matching the siblings. response.charset() already defaults to UTF-8, so plain UTF-8 responses are unchanged. Regression test added per module.

Open Graph Description: Repro: a server response with Content-Type: application/json; charset=ISO-8859-1 and an ISO-8859-1 encoded body decoded through GsonDecoder, JacksonIteratorDecoder or Jackson3IteratorDecoder. Cause...

X Description: Repro: a server response with Content-Type: application/json; charset=ISO-8859-1 and an ISO-8859-1 encoded body decoded through GsonDecoder, JacksonIteratorDecoder or Jackson3IteratorDecoder. Cause...

Opengraph URL: https://github.com/OpenFeign/feign/pull/3447

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb112cbc-c960-be88-bf79-1f6fde412b36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9264:280D83:77C5D4:9FC759:6AEDC565
html-safe-nonceb15511074cc644a740146a2fd2bc7491daaf0755a3c5fdc66a18df1d56768282
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjY0OjI4MEQ4Mzo3N0M1RDQ6OUZDNzU5OjZBRURDNTY1IiwidmlzaXRvcl9pZCI6IjE0OTg4Mzc1NjI1MzUyOTg0MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b5a1cfc291fc22f92ac70d4a5f4bd6c9242fa08d3b4a8069b701f56b90ae6e4
hovercard-subject-tagpull_request:3929161809
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
twitter:imagehttps://avatars.githubusercontent.com/u/50839256?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50839256?s=400&v=4
og:image:altRepro: a server response with Content-Type: application/json; charset=ISO-8859-1 and an ISO-8859-1 encoded body decoded through GsonDecoder, JacksonIteratorDecoder or Jackson3IteratorDecoder. Cause...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec7d2f3ac4f4f560c56267b765892ba5b093e8a5fb2c0ed937edd8947746942e9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/OpenFeign/feign git https://github.com/OpenFeign/feign.git
octolytics-dimension-user_id20077752
octolytics-dimension-user_loginOpenFeign
octolytics-dimension-repository_id10981994
octolytics-dimension-repository_nwoOpenFeign/feign
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id10981994
octolytics-dimension-repository_network_root_nwoOpenFeign/feign
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0cac2d0cb993b0ad48c49b076135ac558c742c30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F3447%2Ffiles%2Fcfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F3447%2Ffiles%2Fcfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=OpenFeign%2Ffeign
Reloadhttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Reloadhttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Reloadhttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
OpenFeignhttps://github.com/OpenFeign
feignhttps://github.com/OpenFeign/feign
Codehttps://github.com/OpenFeign/feign
Issues209 (209)https://github.com/OpenFeign/feign/issues
Pull requests26 (26)https://github.com/OpenFeign/feign/pulls
Actionshttps://github.com/OpenFeign/feign/actions
Projectshttps://github.com/OpenFeign/feign/projects
Wikihttps://github.com/OpenFeign/feign/wiki
Security and qualityhttps://github.com/OpenFeign/feign/security
Insightshttps://github.com/OpenFeign/feign/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FOpenFeign%2Ffeign%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FOpenFeign%2Ffeign%2Fissues%2Fnew%2Fchoose
velohttps://github.com/velo
OpenFeign:masterhttps://github.com/OpenFeign/feign/tree/master
alhudz:decoder-response-charsethttps://github.com/alhudz/feign/tree/decoder-response-charset
Conversation 1 https://github.com/OpenFeign/feign/pull/3447
Commits 1 https://github.com/OpenFeign/feign/pull/3447/commits
Checks 0 https://github.com/OpenFeign/feign/pull/3447/checks
Files changed https://github.com/OpenFeign/feign/pull/3447/files
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
honour response charset in gson and jackson iterator decoders https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#top
Show all changes 1 commit https://github.com/OpenFeign/feign/pull/3447/files
cfd92d6 honour response charset in gson and jackson iterator decoders alhudz Jun 24, 2026 https://github.com/OpenFeign/feign/pull/3447/commits/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Clear filters https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037
GsonDecoder.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
GsonCodecTest.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
JacksonIteratorDecoder.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
JacksonIteratorTest.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
Jackson3IteratorDecoder.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
Jackson3CodecTest.java https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-704244d8799be6c6868627149d4aec73c94c4e7716b6f57781312c0b913a6464
gson/src/main/java/feign/gson/GsonDecoder.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/gson/src/main/java/feign/gson/GsonDecoder.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-a4792793b1ea0215924937dd5f80ac9ce4642ab74a9741f30f82a79032761b87
gson/src/test/java/feign/gson/GsonCodecTest.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/gson/src/test/java/feign/gson/GsonCodecTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-5321ee18f37d1b6b4075ccff8891a30743653c389aa5077c1bdad899fa216067
jackson/src/main/java/feign/jackson/JacksonIteratorDecoder.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/jackson/src/main/java/feign/jackson/JacksonIteratorDecoder.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-eeee049739ecf12ecad65bbcd96df047ffee44d7699d63b6b65cdb2ce55200e7
jackson/src/test/java/feign/jackson/JacksonIteratorTest.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/jackson/src/test/java/feign/jackson/JacksonIteratorTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-584adb8220ba1289433e45754ab05cc2d1cbf8051d77ba5d74a9aa40d1eb1497
jackson3/src/main/java/feign/jackson3/Jackson3IteratorDecoder.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/jackson3/src/main/java/feign/jackson3/Jackson3IteratorDecoder.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-0381cc679fa8393fd72735d4119b005545973334bd42f64f9a6769c28f1b33a6
jackson3/src/test/java/feign/jackson3/Jackson3CodecTest.javahttps://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-704244d8799be6c6868627149d4aec73c94c4e7716b6f57781312c0b913a6464
View file https://github.com/alhudz/feign/blob/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037/jackson3/src/test/java/feign/jackson3/Jackson3CodecTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3447/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-704244d8799be6c6868627149d4aec73c94c4e7716b6f57781312c0b913a6464
https://github.com/OpenFeign/feign/pull/3447/files/cfd92d66fc2dd7f2915ecb33d0cbe4ed454a2037#diff-704244d8799be6c6868627149d4aec73c94c4e7716b6f57781312c0b913a6464
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.