René's URL Explorer Experiment


Title: honour requested charset in okhttp response body reader by alhudz · Pull Request #3441 · OpenFeign/feign · GitHub

Open Graph Title: honour requested charset in okhttp response body reader by alhudz · Pull Request #3441 · OpenFeign/feign

X Title: honour requested charset in okhttp response body reader by alhudz · Pull Request #3441 · OpenFeign/feign

Description: OkHttpClient's response Body.asReader(Charset) ignores the charset argument and delegates to the deprecated asReader(), which returns okhttp's ResponseBody.charStream() (charset taken from Content-Type, defaulting to UTF-8). decoders read a non-buffered response via response.body().asReader(response.charset()), so the resolved charset is dropped on the okhttp client only; httpclient, hc5 and the core InputStreamBody/ByteArrayBody all decode with the requested charset. Repro: a text/plain response (no charset parameter) whose body is café as ISO-8859-1 (63 61 66 E9), read via asReader(ISO_8859_1). Expected: café. Actual: caf� (decoded as UTF-8). Fix: decode with the requested charset using new InputStreamReader(asInputStream(), charset), matching the other clients.

Open Graph Description: OkHttpClient's response Body.asReader(Charset) ignores the charset argument and delegates to the deprecated asReader(), which returns okhttp's ResponseBody.charStream() (charset taken from ...

X Description: OkHttpClient's response Body.asReader(Charset) ignores the charset argument and delegates to the deprecated asReader(), which returns okhttp's ResponseBody.charStream() (charset tak...

Opengraph URL: https://github.com/OpenFeign/feign/pull/3441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a7e6dd8e-1a69-f2eb-fdc5-048c1b812e38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89CC:37437:A31A96:D86F03:6AEDCF94
html-safe-nonce61bb17bceab3c236d4ec406748aea831ca6b75cae4f7bf9f4f0bc481cb36ff83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUNDOjM3NDM3OkEzMUE5NjpEODZGMDM6NkFFRENGOTQiLCJ2aXNpdG9yX2lkIjoiMjU1ODc0NTg1NDE4NjQ5NDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac755a938d1c67384aedcfafdea6ee4af091926d207135237bcd7955c4a7c44c23
hovercard-subject-tagpull_request:3919573144
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
twitter:imagehttps://avatars.githubusercontent.com/u/50839256?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50839256?s=400&v=4
og:image:altOkHttpClient's response Body.asReader(Charset) ignores the charset argument and delegates to the deprecated asReader(), which returns okhttp's ResponseBody.charStream() (charset taken from ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef60373873bb1ef795e8511ea1f2a76997e9c649d72b02942aedf2def3423a0ce
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/OpenFeign/feign git https://github.com/OpenFeign/feign.git
octolytics-dimension-user_id20077752
octolytics-dimension-user_loginOpenFeign
octolytics-dimension-repository_id10981994
octolytics-dimension-repository_nwoOpenFeign/feign
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id10981994
octolytics-dimension-repository_network_root_nwoOpenFeign/feign
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0f55cfa61438c7dc93d1024a1e5e5182b36830e2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F3441%2Ffiles%2F5e1f44778a5506653306141950abbe5802999f3a
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F3441%2Ffiles%2F5e1f44778a5506653306141950abbe5802999f3a
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=OpenFeign%2Ffeign
Reloadhttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
Reloadhttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
Reloadhttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
OpenFeignhttps://github.com/OpenFeign
feignhttps://github.com/OpenFeign/feign
Codehttps://github.com/OpenFeign/feign
Issues209 (209)https://github.com/OpenFeign/feign/issues
Pull requests26 (26)https://github.com/OpenFeign/feign/pulls
Actionshttps://github.com/OpenFeign/feign/actions
Projectshttps://github.com/OpenFeign/feign/projects
Wikihttps://github.com/OpenFeign/feign/wiki
Security and qualityhttps://github.com/OpenFeign/feign/security
Insightshttps://github.com/OpenFeign/feign/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FOpenFeign%2Ffeign%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FOpenFeign%2Ffeign%2Fissues%2Fnew%2Fchoose
velohttps://github.com/velo
OpenFeign:masterhttps://github.com/OpenFeign/feign/tree/master
alhudz:okhttp-asreader-charsethttps://github.com/alhudz/feign/tree/okhttp-asreader-charset
Conversation 1 https://github.com/OpenFeign/feign/pull/3441
Commits 1 https://github.com/OpenFeign/feign/pull/3441/commits
Checks 0 https://github.com/OpenFeign/feign/pull/3441/checks
Files changed https://github.com/OpenFeign/feign/pull/3441/files
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
honour requested charset in okhttp response body reader https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#top
Show all changes 1 commit https://github.com/OpenFeign/feign/pull/3441/files
5e1f447 honour requested charset in okhttp response body reader alhudz Jun 23, 2026 https://github.com/OpenFeign/feign/pull/3441/commits/5e1f44778a5506653306141950abbe5802999f3a
Clear filters https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
Please reload this pagehttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a
OkHttpClient.java https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
OkHttpClientTest.java https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
okhttp/src/main/java/feign/okhttp/OkHttpClient.javahttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
View file https://github.com/alhudz/feign/blob/5e1f44778a5506653306141950abbe5802999f3a/okhttp/src/main/java/feign/okhttp/OkHttpClient.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3441/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-330d5264dcb844baf0c78d0b2de4f30a61db2bedeedd3e6abc46bb9db9456527
okhttp/src/test/java/feign/okhttp/OkHttpClientTest.javahttps://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
View file https://github.com/alhudz/feign/blob/5e1f44778a5506653306141950abbe5802999f3a/okhttp/src/test/java/feign/okhttp/OkHttpClientTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/3441/files/{{ revealButtonHref }}
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
https://github.com/OpenFeign/feign/pull/3441/files/5e1f44778a5506653306141950abbe5802999f3a#diff-ff0527fd4c20a6e753eee2100576a2e6b480f27821036ad3ae2ef567973a43ad
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.