Title: Document metrics published by the micrometer module by seonwooj0810 · Pull Request #3370 · OpenFeign/feign · GitHub
Open Graph Title: Document metrics published by the micrometer module by seonwooj0810 · Pull Request #3370 · OpenFeign/feign
X Title: Document metrics published by the micrometer module by seonwooj0810 · Pull Request #3370 · OpenFeign/feign
Description: Adds a new micrometer/README.md that documents the metrics published by MicrometerCapability and the observation published by MicrometerObservationCapability, picking up the request from the maintainer in #2248. What's documented Every metric emitted by MicrometerCapability — name, type (Timer / Counter / DistributionSummary), where it's recorded, and the per-metric extra tags. Covers the feign.Feign.*, feign.Client.*, feign.AsyncClient.*, feign.codec.Encoder.* and feign.codec.Decoder.* families. The common tags injected by FeignMetricTagResolver (client, method, host, exception_name, root_cause_name). The http.client.requests observation produced by MicrometerObservationCapability, the key values populated by DefaultFeignObservationConvention, and the additional KeyNames declared on FeignObservationDocumentation. Brief usage snippets for both capabilities, including how to pass a custom MeterRegistry / common tags or a custom FeignObservationConvention. The main README.md's Micrometer section now links to the new module README so the existing example stays minimal. Notes for reviewers One naming quirk is called out in the table: feign.codec.Encoder.response_size is recorded by MeteredEncoder against template.body().length, i.e. it actually measures the request body. The PR documents this honestly rather than silently aliasing or renaming. All facts were derived from the code in micrometer/src/main/java/feign/micrometer/ rather than guesswork; happy to adjust wording if anything reads inaccurately. Fixes #2248
Open Graph Description: Adds a new micrometer/README.md that documents the metrics published by MicrometerCapability and the observation published by MicrometerObservationCapability, picking up the request from the mainta...
X Description: Adds a new micrometer/README.md that documents the metrics published by MicrometerCapability and the observation published by MicrometerObservationCapability, picking up the request from the mainta...
Opengraph URL: https://github.com/OpenFeign/feign/pull/3370
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fe35f1c6-426c-6139-09d4-2cc312edc162 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9CAA:2463B8:1244161:17DF93F:6AED6884 |
| html-safe-nonce | 528706283ae5b1d333f274ca74639500855e4b0a6d4c91ff5505acfe55735fa9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0FBOjI0NjNCODoxMjQ0MTYxOjE3REY5M0Y6NkFFRDY4ODQiLCJ2aXNpdG9yX2lkIjoiNTEwMzg1Mzg5MDQwMjM0NzE0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0f34b70f1932040d8eb64e2b8eec1f821498bc7d4058e6820daf2fa204683dd0 |
| hovercard-subject-tag | pull_request:3736822378 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/OpenFeign/feign/pull/3370/files |
| twitter:image | https://avatars.githubusercontent.com/u/79202163?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/79202163?s=400&v=4 |
| og:image:alt | Adds a new micrometer/README.md that documents the metrics published by MicrometerCapability and the observation published by MicrometerObservationCapability, picking up the request from the mainta... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/OpenFeign/feign git https://github.com/OpenFeign/feign.git |
| octolytics-dimension-user_id | 20077752 |
| octolytics-dimension-user_login | OpenFeign |
| octolytics-dimension-repository_id | 10981994 |
| octolytics-dimension-repository_nwo | OpenFeign/feign |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 10981994 |
| octolytics-dimension-repository_network_root_nwo | OpenFeign/feign |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width