René's URL Explorer Experiment


Title: #1210 attempt to fix null body issue by finnetrolle · Pull Request #1237 · OpenFeign/feign · GitHub

Open Graph Title: #1210 attempt to fix null body issue by finnetrolle · Pull Request #1237 · OpenFeign/feign

X Title: #1210 attempt to fix null body issue by finnetrolle · Pull Request #1237 · OpenFeign/feign

Description: Feign makes writing java http clients easier. Contribute to OpenFeign/feign development by creating an account on GitHub.

Open Graph Description: Hi all, This is an attempt to fix an issue. I think if we have null-body for request it is better to provide null back if client ask Request#Body. But in fact we're sending back not Body but bo...

X Description: Hi all, This is an attempt to fix an issue. I think if we have null-body for request it is better to provide null back if client ask Request#Body. But in fact we're sending back not Body bu...

Opengraph URL: https://github.com/OpenFeign/feign/pull/1237

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:92460611-95e0-df5c-b118-edf3bb61ab3d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB30:151ADC:566F0A:759800:6AED5A2B
html-safe-nonceec0fa180102f9c6595d56c93358a1a7ca967e8c1e07034bd5f5b9c3c1813aeb3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjMwOjE1MUFEQzo1NjZGMEE6NzU5ODAwOjZBRUQ1QTJCIiwidmlzaXRvcl9pZCI6Ijc0OTk2NTgzNjk3NzAwMTkzNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac928d60692364f518a1e77e1cfded7f4316034ec1b2cb95176a0423df2d0be004
hovercard-subject-tagpull_request:432082105
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/OpenFeign/feign/1237/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf0cc6a20cd167de38c18cfe2ad8aa14308ab93558b1ab84a8dd8960d8a1034a/OpenFeign/feign/pull/1237
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf0cc6a20cd167de38c18cfe2ad8aa14308ab93558b1ab84a8dd8960d8a1034a/OpenFeign/feign/pull/1237
og:image:altHi all, This is an attempt to fix an issue. I think if we have null-body for request it is better to provide null back if client ask Request#Body. But in fact we're sending back not Body but bo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefinnetrolle
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/OpenFeign/feign git https://github.com/OpenFeign/feign.git
octolytics-dimension-user_id20077752
octolytics-dimension-user_loginOpenFeign
octolytics-dimension-repository_id10981994
octolytics-dimension-repository_nwoOpenFeign/feign
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id10981994
octolytics-dimension-repository_network_root_nwoOpenFeign/feign
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/OpenFeign/feign/pull/1237#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F1237
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F1237
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=OpenFeign%2Ffeign
Reloadhttps://github.com/OpenFeign/feign/pull/1237
Reloadhttps://github.com/OpenFeign/feign/pull/1237
Reloadhttps://github.com/OpenFeign/feign/pull/1237
OpenFeignhttps://github.com/OpenFeign
feignhttps://github.com/OpenFeign/feign
Codehttps://github.com/OpenFeign/feign
Issues209 (209)https://github.com/OpenFeign/feign/issues
Pull requests27 (27)https://github.com/OpenFeign/feign/pulls
Actionshttps://github.com/OpenFeign/feign/actions
Projectshttps://github.com/OpenFeign/feign/projects
Wikihttps://github.com/OpenFeign/feign/wiki
Security and qualityhttps://github.com/OpenFeign/feign/security
Insightshttps://github.com/OpenFeign/feign/pulse
https://github.com/OpenFeign/feign
finnetrollehttps://github.com/finnetrolle
OpenFeign:masterhttps://github.com/OpenFeign/feign/tree/master
finnetrolle:#1210https://github.com/finnetrolle/feign/tree/%231210
Conversationhttps://github.com/OpenFeign/feign/pull/1237
Commits2 (2)https://github.com/OpenFeign/feign/pull/1237/commits
Checkshttps://github.com/OpenFeign/feign/pull/1237/checks
Files changedhttps://github.com/OpenFeign/feign/pull/1237/files
#1210 attempt to fix null body issuehttps://github.com/OpenFeign/feign/pull/1237#top
finnetrollehttps://github.com/finnetrolle
OpenFeign:masterhttps://github.com/OpenFeign/feign/tree/master
finnetrolle:#1210https://github.com/finnetrolle/feign/tree/%231210
https://github.com/finnetrolle
finnetrollehttps://github.com/finnetrolle
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#issue-635778729
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/finnetrolle
OpenFeign#1210https://github.com/OpenFeign/feign/issues/1210
attempt to fix null body issuehttps://github.com/OpenFeign/feign/pull/1237/commits/4257869195fcaa08af30cc7376faedf447a2592c
4257869https://github.com/OpenFeign/feign/pull/1237/commits/4257869195fcaa08af30cc7376faedf447a2592c
https://github.com/velo
velohttps://github.com/velo
Jun 9, 2020 https://github.com/OpenFeign/feign/pull/1237#pullrequestreview-427569625
View reviewed changes https://github.com/OpenFeign/feign/pull/1237/files/4257869195fcaa08af30cc7376faedf447a2592c
core/src/main/java/feign/Request.javahttps://github.com/OpenFeign/feign/pull/1237/files/4257869195fcaa08af30cc7376faedf447a2592c#diff-798548cea29b601bab6d72150378df562bd119091f3dedbd8a9feb72d3d181b0
velohttps://github.com/velo
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r437741650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/OpenFeign/feign/blob/master/httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java#L135https://github.com/OpenFeign/feign/blob/master/httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java#L135
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
finnetrollehttps://github.com/finnetrolle
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r437744087
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
nikolas-charalambidishttps://github.com/nikolas-charalambidis
Aug 10, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r468125588
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/velo
velohttps://github.com/velo
breaking change https://github.com/OpenFeign/feign/issues?q=state%3Aopen%20label%3A%22breaking%20change%22
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#event-3426972288
https://github.com/velo
velohttps://github.com/velo
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#issuecomment-641600473
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/finnetrolle
finnetrollehttps://github.com/finnetrolle
Jun 9, 2020https://github.com/OpenFeign/feign/pull/1237#issuecomment-641601433
#1210https://github.com/OpenFeign/feign/issues/1210
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/finnetrolle
OpenFeign#1210https://github.com/OpenFeign/feign/issues/1210
add logic to getter instead of changing constructorhttps://github.com/OpenFeign/feign/pull/1237/commits/7f39c9b0d9537e1dc58045426105a80984d9925b
7f39c9bhttps://github.com/OpenFeign/feign/pull/1237/commits/7f39c9b0d9537e1dc58045426105a80984d9925b
https://github.com/finnetrolle
finnetrollehttps://github.com/finnetrolle
Jun 10, 2020https://github.com/OpenFeign/feign/pull/1237#issuecomment-642272610
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/velo
velohttps://github.com/velo
Jun 10, 2020 https://github.com/OpenFeign/feign/pull/1237#pullrequestreview-428477263
View reviewed changes https://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b
core/src/main/java/feign/Request.javahttps://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b#diff-798548cea29b601bab6d72150378df562bd119091f3dedbd8a9feb72d3d181b0
velohttps://github.com/velo
Jun 10, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r438446793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
velohttps://github.com/velo
Jun 10, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r438447752
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
finnetrollehttps://github.com/finnetrolle
Jun 11, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r438786679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
kdavisk6https://github.com/kdavisk6
Jun 17, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r441559278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
finnetrollehttps://github.com/finnetrolle
Jun 19, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r442583315
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
kdavisk6https://github.com/kdavisk6
Jun 22, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r443725141
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
finnetrollehttps://github.com/finnetrolle
Jun 25, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r445240639
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@kdavisk6https://github.com/kdavisk6
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/finnetrolle
finnetrollehttps://github.com/finnetrolle
velohttps://github.com/velo
June 11, 2020 13:33https://github.com/OpenFeign/feign/pull/1237#event-3434174113
https://github.com/kdavisk6
kdavisk6https://github.com/kdavisk6
feedback provided https://github.com/OpenFeign/feign/issues?q=state%3Aopen%20label%3A%22feedback%20provided%22
Jun 17, 2020https://github.com/OpenFeign/feign/pull/1237#event-3453684196
https://github.com/finnetrolle
finnetrollehttps://github.com/finnetrolle
kdavisk6https://github.com/kdavisk6
June 20, 2020 01:03https://github.com/OpenFeign/feign/pull/1237#event-3464228772
https://github.com/kdavisk6
kdavisk6https://github.com/kdavisk6
Jun 22, 2020 https://github.com/OpenFeign/feign/pull/1237#pullrequestreview-435144512
View reviewed changes https://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b
core/src/main/java/feign/Request.javahttps://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b#diff-798548cea29b601bab6d72150378df562bd119091f3dedbd8a9feb72d3d181b0
kdavisk6https://github.com/kdavisk6
Jun 22, 2020https://github.com/OpenFeign/feign/pull/1237#discussion_r443725475
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/velo
velohttps://github.com/velo
Jul 7, 2022https://github.com/OpenFeign/feign/pull/1237#event-6948476228
https://github.com/sharanggupta
sharangguptahttps://github.com/sharanggupta
Oct 6, 2026 https://github.com/OpenFeign/feign/pull/1237#ref-pullrequest-5734872184
Treat a null Request.Body as a request with no body #3605 https://github.com/OpenFeign/feign/pull/3605
https://github.co/hiddenchars
https://github.com/OpenFeign/feign/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FOpenFeign%2Ffeign%2Fpull%2F1237
https://github.com/kdavisk6
kdavisk6 https://github.com/kdavisk6
https://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b
https://github.com/velo
velo https://github.com/velo
https://github.com/nikolas-charalambidis
nikolas-charalambidis https://github.com/nikolas-charalambidis
https://github.com/OpenFeign/feign/pull/1237/files/7f39c9b0d9537e1dc58045426105a80984d9925b
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
breaking change https://github.com/OpenFeign/feign/issues?q=state%3Aopen%20label%3A%22breaking%20change%22
feedback provided https://github.com/OpenFeign/feign/issues?q=state%3Aopen%20label%3A%22feedback%20provided%22
Please reload this pagehttps://github.com/OpenFeign/feign/pull/1237
https://github.com/finnetrolle
https://github.com/velo
https://github.com/kdavisk6
https://github.com/nikolas-charalambidis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.