Title: Add optional geospatial functionality · Issue #70 · ODM2/ODM2PythonAPI · GitHub
Open Graph Title: Add optional geospatial functionality · Issue #70 · ODM2/ODM2PythonAPI
X Title: Add optional geospatial functionality · Issue #70 · ODM2/ODM2PythonAPI
Description: The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape method on the models.py SamplingFeatures cl...
Open Graph Description: The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape met...
X Description: The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape met...
Opengraph URL: https://github.com/ODM2/ODM2PythonAPI/issues/70
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add optional geospatial functionality","articleBody":"The recent PR #69 completed the removal of all geospatial capability (even optional ones) around `SamplingFeatures.FeatureGeometry` that [started with a commit in early June](https://github.com/ODM2/ODM2PythonAPI/commit/f89d58369a7e2cfdc7ac8179af87d1914fbe05df#diff-0ee3d0270e8061c9eb0e712c2e83d27a) that removed the `shape` method on the `models.py` `SamplingFeatures` class and related, geoalchemy-based functionality.\n\nFor convenience for future follow-ups, I'm pasting below [some of my own comments from the discussions on PR #69:](https://github.com/ODM2/ODM2PythonAPI/pull/69#issuecomment-244819377)\n\n\u003e more broadly, I don't agree with the complete removal of all geospatial capability that started in early June commits. I can definitely see the benefit of making that functionality more optional, including moving related import statements into the optional methods that use them (or even into a utilities module) so that packages like `shapely` and `geoalchemy` are not required. But that's different from removing all geospatial capability entirely. FYI, I believe Choonhan was relying on the `shape` function for ODM2RESTAPI, and I personally found it very useful and non-obtrusive, except requiring the installation of those geospatial packages.\n\n**TO-DO for me (Emilio):**\n- Start a new 'geospatial' branch to bring back the deleted functionality, and work towards making it as lightweight/optional as possible so it doesn't impose the burden of installing additional packages for user who would never use it.\n- Develop usage examples for that code.\n- Think about adding functionality to go from `FeatureGeometryWKT` to Python geospatial objects.\n- Look back through old issues to see what relevant, old discussions should be linked up into this issue.\n\ncc'ing @lsetiawan, b/c I plan to start pulling him into `odm2api` development later this month. He's already built some ODM2 geodjango experience, and has a strong Python geospatial experience.\n","author":{"url":"https://github.com/emiliom","@type":"Person","name":"emiliom"},"datePublished":"2016-09-05T23:09:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/70/ODM2PythonAPI/issues/70"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:59b0a9cd-d7bb-e618-9be7-e07c26abaefb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D86C:90EFB:23B8A39:335E2B7:6A58EE17 |
| html-safe-nonce | 2838c0012e5a0e164de24d7233716202a802ca0c69f9f36fe3cf1e207376a993 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODZDOjkwRUZCOjIzQjhBMzk6MzM1RTJCNzo2QTU4RUUxNyIsInZpc2l0b3JfaWQiOiIzNzc1NjU4NjE0NDMxNzM5NDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 92807520d4f80cf751ed549b150c2f31f488f8dadcb4b214371c6d80119e2a83 |
| hovercard-subject-tag | issue:175135304 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ODM2/ODM2PythonAPI/70/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6ce8e31302c28696a5a131c0b0f72a99c2d772a93ab963e1a2faacfbaf2e5626/ODM2/ODM2PythonAPI/issues/70 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ce8e31302c28696a5a131c0b0f72a99c2d772a93ab963e1a2faacfbaf2e5626/ODM2/ODM2PythonAPI/issues/70 |
| og:image:alt | The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape met... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | emiliom |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| go-import | github.com/ODM2/ODM2PythonAPI git https://github.com/ODM2/ODM2PythonAPI.git |
| octolytics-dimension-user_id | 12091612 |
| octolytics-dimension-user_login | ODM2 |
| octolytics-dimension-repository_id | 34542098 |
| octolytics-dimension-repository_nwo | ODM2/ODM2PythonAPI |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 34542098 |
| octolytics-dimension-repository_network_root_nwo | ODM2/ODM2PythonAPI |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width