Title: fix: resolve NDK path discovery on Windows by AttalliAyoub · Pull Request #3 · NexusDynamic/android_libcpp_shared · GitHub
Open Graph Title: fix: resolve NDK path discovery on Windows by AttalliAyoub · Pull Request #3 · NexusDynamic/android_libcpp_shared
X Title: fix: resolve NDK path discovery on Windows by AttalliAyoub · Pull Request #3 · NexusDynamic/android_libcpp_shared
Description: What does this PR do? Fixes an issue on Windows where locate_ndk.dart crashes because Platform.environment['HOME'] is null, and addresses a secondary issue where the Glob package fails to match Windows paths containing backslashes. How was this fixed? Used Platform.environment['USERPROFILE'] as the home directory fallback on Windows. Normalized the Windows directory path separators (replaced \ with /) before passing them to the Glob package so that glob pattern matching correctly finds the NDK installation directories. Bumped version to 0.1.2 and updated the CHANGELOG. Testing Tested locally on Windows. NDKLocator.locate() now successfully discovers the NDK installation without crashing or failing to match directories.
Open Graph Description: What does this PR do? Fixes an issue on Windows where locate_ndk.dart crashes because Platform.environment['HOME'] is null, and addresses a secondary issue where the Glob package fails to m...
X Description: What does this PR do? Fixes an issue on Windows where locate_ndk.dart crashes because Platform.environment['HOME'] is null, and addresses a secondary issue where the Glob package fa...
Opengraph URL: https://github.com/NexusDynamic/android_libcpp_shared/pull/3
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e477bfce-511a-ceac-016f-5cafc6c9c429 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB06:179A4C:18A504E:23FFE3F:6A4E558A |
| html-safe-nonce | 0ba1020da081e8ddd760ed214aa44b9f779b3c79da9847f64047dd12bc6b4626 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjA2OjE3OUE0QzoxOEE1MDRFOjIzRkZFM0Y6NkE0RTU1OEEiLCJ2aXNpdG9yX2lkIjoiMTMzMTM1MzA2MjI1NDQ2NjQ0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6e00e0998f374cdb4a3d9ec8a120e25f68bbb506d3f42682dca66244d74c05d0 |
| hovercard-subject-tag | pull_request:3732722483 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NexusDynamic/android_libcpp_shared/pull/3/files |
| twitter:image | https://avatars.githubusercontent.com/u/41020025?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/41020025?s=400&v=4 |
| og:image:alt | What does this PR do? Fixes an issue on Windows where locate_ndk.dart crashes because Platform.environment['HOME'] is null, and addresses a secondary issue where the Glob package fails to m... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NexusDynamic/android_libcpp_shared git https://github.com/NexusDynamic/android_libcpp_shared.git |
| octolytics-dimension-user_id | 215839682 |
| octolytics-dimension-user_login | NexusDynamic |
| octolytics-dimension-repository_id | 1184665524 |
| octolytics-dimension-repository_nwo | NexusDynamic/android_libcpp_shared |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1184665524 |
| octolytics-dimension-repository_network_root_nwo | NexusDynamic/android_libcpp_shared |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f344f1eab54fc7dfc02d0d018cda7e158c3db65c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width