René's URL Explorer Experiment


Title: Kddimitrov/fix worker loader cachable by KristianDD · Pull Request #48 · NativeScript/worker-loader · GitHub

Open Graph Title: Kddimitrov/fix worker loader cachable by KristianDD · Pull Request #48 · NativeScript/worker-loader

X Title: Kddimitrov/fix worker loader cachable by KristianDD · Pull Request #48 · NativeScript/worker-loader

Description: The worker loader was marked as non cachable - here, which caused a new child compilation and new emit on every change - source here. When the cache disable is removed initially(after first compilation) the worker files are added as a dependency and watched, because the file dependencies of the child compilation are added to the fileDependencies of the parent compilation - here. After the first change webpack doesn't find any module dependent on the files and the loader result is cached, so no child compilation is started. This results in that the watcher no longer is even watching the files - source here. To fix this, we should take all file dependencies of the child compilation and add them to the file dependencies of the module. Now this method will mark the module as one that needs rebuild which will in turn invoke the loader logic. Fixes #41

Open Graph Description: The worker loader was marked as non cachable - here, which caused a new child compilation and new emit on every change - source here. When the cache disable is removed initially(after first compila...

X Description: The worker loader was marked as non cachable - here, which caused a new child compilation and new emit on every change - source here. When the cache disable is removed initially(after first compila...

Opengraph URL: https://github.com/NativeScript/worker-loader/pull/48

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fc3ee212-3d80-d942-18de-06b75ca0c280
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8256:8226C:C2E5F:10121E:6B015F01
html-safe-noncecf39f5eb4cb2e893e7360293870146543c4b2a2f12e6b5d2c06697f90c123045
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjU2OjgyMjZDOkMyRTVGOjEwMTIxRTo2QjAxNUYwMSIsInZpc2l0b3JfaWQiOiI3MDAwNDgxODA4NzQ3OTQ1NzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd79616d7e2a0a6dcb16d75b491af138f00be1f36962ef0c63d4699a4d4f4aaec
hovercard-subject-tagpull_request:341544107
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/worker-loader/pull/48/files
twitter:imagehttps://avatars.githubusercontent.com/u/2412096?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2412096?s=400&v=4
og:image:altThe worker loader was marked as non cachable - here, which caused a new child compilation and new emit on every change - source here. When the cache disable is removed initially(after first compila...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/worker-loader git https://github.com/NativeScript/worker-loader.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id99676258
octolytics-dimension-repository_nwoNativeScript/worker-loader
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id99676258
octolytics-dimension-repository_network_root_nwoNativeScript/worker-loader
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/worker-loader/pull/48/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fworker-loader%2Fpull%2F48%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fworker-loader%2Fpull%2F48%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fworker-loader
Reloadhttps://github.com/NativeScript/worker-loader/pull/48/files
Reloadhttps://github.com/NativeScript/worker-loader/pull/48/files
Reloadhttps://github.com/NativeScript/worker-loader/pull/48/files
NativeScripthttps://github.com/NativeScript
worker-loaderhttps://github.com/NativeScript/worker-loader
Codehttps://github.com/NativeScript/worker-loader
Issues18 (18)https://github.com/NativeScript/worker-loader/issues
Pull requests22 (22)https://github.com/NativeScript/worker-loader/pulls
Actionshttps://github.com/NativeScript/worker-loader/actions
Projectshttps://github.com/NativeScript/worker-loader/projects
Security and qualityhttps://github.com/NativeScript/worker-loader/security
Insightshttps://github.com/NativeScript/worker-loader/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fworker-loader%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fworker-loader%2Fissues%2Fnew%2Fchoose
KristianDDhttps://github.com/KristianDD
masterhttps://github.com/NativeScript/worker-loader/tree/master
kddimitrov/fix-worker-loader-cachablehttps://github.com/NativeScript/worker-loader/tree/kddimitrov/fix-worker-loader-cachable
Conversation 1 https://github.com/NativeScript/worker-loader/pull/48
Commits 4 https://github.com/NativeScript/worker-loader/pull/48/commits
Checks 0 https://github.com/NativeScript/worker-loader/pull/48/checks
Files changed https://github.com/NativeScript/worker-loader/pull/48/files
Please reload this pagehttps://github.com/NativeScript/worker-loader/pull/48/files
Kddimitrov/fix worker loader cachable https://github.com/NativeScript/worker-loader/pull/48/files#top
Show all changes 4 commits https://github.com/NativeScript/worker-loader/pull/48/files
d4b3931 fix: worker loader not cacheable KristianDD Nov 15, 2019 https://github.com/NativeScript/worker-loader/pull/48/commits/d4b39314edfe8e1870b95a4ba8904c6a475c93b2
6f8ad0e fix: disable HMR in child compilation and clear compilation hash KristianDD Nov 15, 2019 https://github.com/NativeScript/worker-loader/pull/48/commits/6f8ad0ec7a1b4eb7bcf6d10244b9bf233da4e12f
d462cb9 chore: format code comments KristianDD Nov 15, 2019 https://github.com/NativeScript/worker-loader/pull/48/commits/d462cb93a1fbe1a261c10c272ed030b1d3fff3b3
112385a chore: bump version to 0.10.0 KristianDD Nov 18, 2019 https://github.com/NativeScript/worker-loader/pull/48/commits/112385a1124b1a07b0272baf56041057b0db674a
Clear filters https://github.com/NativeScript/worker-loader/pull/48/files
Please reload this pagehttps://github.com/NativeScript/worker-loader/pull/48/files
Please reload this pagehttps://github.com/NativeScript/worker-loader/pull/48/files
index.js https://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
package.json https://github.com/NativeScript/worker-loader/pull/48/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
src/index.jshttps://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
View file https://github.com/NativeScript/worker-loader/blob/112385a1124b1a07b0272baf56041057b0db674a/src/index.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/worker-loader/pull/48/{{ revealButtonHref }}
https://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
https://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
https://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
KristianDDhttps://github.com/KristianDD
Nov 18, 2019https://github.com/NativeScript/worker-loader/pull/48/files#r347396026
Please reload this pagehttps://github.com/NativeScript/worker-loader/pull/48/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
jantimon/html-webpack-plugin#1089https://github.com/jantimon/html-webpack-plugin/issues/1089
Please reload this pagehttps://github.com/NativeScript/worker-loader/pull/48/files
https://github.com/NativeScript/worker-loader/pull/48/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
src/package.jsonhttps://github.com/NativeScript/worker-loader/pull/48/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
View file https://github.com/NativeScript/worker-loader/blob/112385a1124b1a07b0272baf56041057b0db674a/src/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/worker-loader/pull/48/{{ revealButtonHref }}
https://github.com/NativeScript/worker-loader/pull/48/files#diff-cc5a2f170768969f124108ad3be7fdbcbed774c11774d99a87a3a78fef4ab97b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.