René's URL Explorer Experiment


Title: fix(winrt): unsealed class returns and static method overloads by triniwiz · Pull Request #55 · NativeScript/windows · GitHub

Open Graph Title: fix(winrt): unsealed class returns and static method overloads by triniwiz · Pull Request #55 · NativeScript/windows

X Title: fix(winrt): unsealed class returns and static method overloads by triniwiz · Pull Request #55 · NativeScript/windows

Description: Two projection fixes in calls to WinRT statics and their return values. Unsealed class returns A method whose declared return type is a class others can derive from came back as a wrapper of the declared class. The runtime class was never asked for. VisualTreeHelper.GetParent declares DependencyObject and returns a Grid, which came back without IsHitTestVisible or any other Grid member. An unsealed declared class now resolves the runtime class, as interface returns already did. Both engines: return_value_from_kind (classic) and create_instance_proxy (Node-API). Static overloads Statics had no overload selection. The constructor held one function per name, bound to whichever overload came first in metadata, and [Overload] names were not exposed for statics. So VisualTreeHelper.FindElementsInHostCoordinates(point, element) could reach the Rect overload. Statics are now grouped by name and the overload is picked per call: by argument count (trailing out parameters may be left off); then by the struct whose fields an object argument has, preferring the most fields matched; then [DefaultOverload], then metadata order. Their [Overload] names (FindElementsInHostCoordinatesPoint, ...Rect) are exposed too, as for instance methods. The Node-API engine's instance and constructor overloads use the same selection (class_helpers::pick_overload). Verified On Windows 11, in the NativeScript canvas demo with this build: VisualTreeHelper.GetParent of a hosted view returns a Microsoft.UI.Xaml.Controls.Grid. FindElementsInHostCoordinates(Point, UIElement) and FindElementsInHostCoordinates(Rect, UIElement) return the same element counts as FindElementsInHostCoordinatesPoint and FindElementsInHostCoordinatesRect called by name. The canvas spec suite passes, including the HTML-in-Canvas hit tests, which call FindElementsInHostCoordinates(Point, UIElement). cargo build -p nativescript --release (classic) and cargo check -p runtime --no-default-features --features napi_engine for x86_64-pc-windows-msvc. Tested together with #54, which the canvas addons need to load.

Open Graph Description: Two projection fixes in calls to WinRT statics and their return values. Unsealed class returns A method whose declared return type is a class others can derive from came back as a wrapper of the de...

X Description: Two projection fixes in calls to WinRT statics and their return values. Unsealed class returns A method whose declared return type is a class others can derive from came back as a wrapper of the de...

Opengraph URL: https://github.com/NativeScript/windows/pull/55

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d90b770-3335-cf68-50ea-fa93292d5d45
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2F6:65478:204FEFE:2AD14B4:6B0176D6
html-safe-nonce1cd35f14ef71007bcb5e0ca1fc0c72882c5057bfaefcf9e18a45e9f75754bb59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkY2OjY1NDc4OjIwNEZFRkU6MkFEMTRCNDo2QjAxNzZENiIsInZpc2l0b3JfaWQiOiI0NDIwNzQ0NjUwNTU0NDM5MzgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf449daaf8d3f324f4fd9e86ffff6c2cb2ee5a91e5047d4cfc1323d2ed4b029c3
hovercard-subject-tagpull_request:5405313812
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/windows/pull/55/files
twitter:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
og:image:altTwo projection fixes in calls to WinRT statics and their return values. Unsealed class returns A method whose declared return type is a class others can derive from came back as a wrapper of the de...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/windows git https://github.com/NativeScript/windows.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id373653886
octolytics-dimension-repository_nwoNativeScript/windows
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id373653886
octolytics-dimension-repository_network_root_nwoNativeScript/windows
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/windows/pull/55/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fwindows%2Fpull%2F55%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fwindows%2Fpull%2F55%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fwindows
Reloadhttps://github.com/NativeScript/windows/pull/55/files
Reloadhttps://github.com/NativeScript/windows/pull/55/files
Reloadhttps://github.com/NativeScript/windows/pull/55/files
NativeScripthttps://github.com/NativeScript
windowshttps://github.com/NativeScript/windows
Codehttps://github.com/NativeScript/windows
Issueshttps://github.com/NativeScript/windows/issues
Pull requestshttps://github.com/NativeScript/windows/pulls
Actionshttps://github.com/NativeScript/windows/actions
Projectshttps://github.com/NativeScript/windows/projects
Security and qualityhttps://github.com/NativeScript/windows/security
Insightshttps://github.com/NativeScript/windows/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fwindows%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fwindows%2Fissues%2Fnew%2Fchoose
triniwizhttps://github.com/triniwiz
mainhttps://github.com/NativeScript/windows/tree/main
fix/winrt-runtime-class-and-static-overloadshttps://github.com/NativeScript/windows/tree/fix/winrt-runtime-class-and-static-overloads
Conversation 1 https://github.com/NativeScript/windows/pull/55
Commits 1 https://github.com/NativeScript/windows/pull/55/commits
Checks 3 https://github.com/NativeScript/windows/pull/55/checks
Files changed https://github.com/NativeScript/windows/pull/55/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/55/files
fix(winrt): unsealed class returns and static method overloads https://github.com/NativeScript/windows/pull/55/files#top
Show all changes 1 commit https://github.com/NativeScript/windows/pull/55/files
e3cdaea fix(winrt): unsealed class returns and static method overloads triniwiz Nov 20, 2026 https://github.com/NativeScript/windows/pull/55/commits/e3cdaead3722271bb6d82a619b60bd62774a1c2a
Clear filters https://github.com/NativeScript/windows/pull/55/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/55/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/55/files
class_helpers.rs https://github.com/NativeScript/windows/pull/55/files#diff-b2fd3576f552248f3b01e1ccc0eb7138c1c9cf3c2c473692864e1c8dfeae7e09
lib.rs https://github.com/NativeScript/windows/pull/55/files#diff-0ec06ea58bd455f09ce6b3bb4c2c1c0d37bda51c1e1be2151c560c9c973959ec
ns_hostobject.rs https://github.com/NativeScript/windows/pull/55/files#diff-1d9331b970a9afcc9a4a6cc02b60c50f2501221efeabb9fb14f56be2355d14ec
ns_proxy.rs https://github.com/NativeScript/windows/pull/55/files#diff-f4a0bdf411cd492e43a59f077f2c52f9eced8fe7a102177cee28ac9f7c6b66d3
runtime/src/class_helpers.rshttps://github.com/NativeScript/windows/pull/55/files#diff-b2fd3576f552248f3b01e1ccc0eb7138c1c9cf3c2c473692864e1c8dfeae7e09
View file https://github.com/NativeScript/windows/blob/e3cdaead3722271bb6d82a619b60bd62774a1c2a/runtime/src/class_helpers.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/windows/pull/55/{{ revealButtonHref }}
https://github.com/NativeScript/windows/pull/55/files#diff-b2fd3576f552248f3b01e1ccc0eb7138c1c9cf3c2c473692864e1c8dfeae7e09
https://github.com/NativeScript/windows/pull/55/files#diff-b2fd3576f552248f3b01e1ccc0eb7138c1c9cf3c2c473692864e1c8dfeae7e09
Please reload this pagehttps://github.com/NativeScript/windows/pull/55/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.