René's URL Explorer Experiment


Title: fix(napi): napi_wrap an object without internal fields by triniwiz · Pull Request #54 · NativeScript/windows · GitHub

Open Graph Title: fix(napi): napi_wrap an object without internal fields by triniwiz · Pull Request #54 · NativeScript/windows

X Title: fix(napi): napi_wrap an object without internal fields by triniwiz · Pull Request #54 · NativeScript/windows

Description: napi_wrap aborted V8 on any object that is not an instance of a napi_define_class class. Cause The V8 shim kept every wrap in internal field 0, and only napi_define_class instances have one. Node wraps any object. napi-rs 3.16 wraps a plain object while a module registers (create_custom_gc_sentinel), so loading an addon built with it aborted with Internal field out of bounds. NativeScript canvas hit this on every load. Change packages/windows-v8/vendor/shim: an object without the internal field keeps its wrap under a private symbol, as Node does. napi_unwrap and napi_remove_wrap read it from there. Class instances keep using the internal field. Verified Windows 11: the NativeScript canvas demo loads its napi-rs 3.16 addons with this build, and the canvas spec suite passes.

Open Graph Description: napi_wrap aborted V8 on any object that is not an instance of a napi_define_class class. Cause The V8 shim kept every wrap in internal field 0, and only napi_define_class instances have one. Node w...

X Description: napi_wrap aborted V8 on any object that is not an instance of a napi_define_class class. Cause The V8 shim kept every wrap in internal field 0, and only napi_define_class instances have one. Node w...

Opengraph URL: https://github.com/NativeScript/windows/pull/54

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:01145693-496b-c2b1-b241-40ec7d9bec42
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB822:A99C2:267E51B:30F6587:6B017CEE
html-safe-nonce6d21c12fc7966c23c8574a62b3f48e9957786ca89d9ef1b5facf6a1012a8e066
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODIyOkE5OUMyOjI2N0U1MUI6MzBGNjU4Nzo2QjAxN0NFRSIsInZpc2l0b3JfaWQiOiIxMDQ3MDI2OTgzMTg1MjUxNTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac24580842a1e19e3722e2b380ee5e8cc3eb45e53c149d737d5ff4f0797096845c
hovercard-subject-tagpull_request:5405312481
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/windows/pull/54/files
twitter:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
og:image:altnapi_wrap aborted V8 on any object that is not an instance of a napi_define_class class. Cause The V8 shim kept every wrap in internal field 0, and only napi_define_class instances have one. Node w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/windows git https://github.com/NativeScript/windows.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id373653886
octolytics-dimension-repository_nwoNativeScript/windows
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id373653886
octolytics-dimension-repository_network_root_nwoNativeScript/windows
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/windows/pull/54/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fwindows%2Fpull%2F54%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fwindows%2Fpull%2F54%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fwindows
Reloadhttps://github.com/NativeScript/windows/pull/54/files
Reloadhttps://github.com/NativeScript/windows/pull/54/files
Reloadhttps://github.com/NativeScript/windows/pull/54/files
NativeScripthttps://github.com/NativeScript
windowshttps://github.com/NativeScript/windows
Codehttps://github.com/NativeScript/windows
Issueshttps://github.com/NativeScript/windows/issues
Pull requestshttps://github.com/NativeScript/windows/pulls
Actionshttps://github.com/NativeScript/windows/actions
Projectshttps://github.com/NativeScript/windows/projects
Security and qualityhttps://github.com/NativeScript/windows/security
Insightshttps://github.com/NativeScript/windows/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fwindows%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fwindows%2Fissues%2Fnew%2Fchoose
triniwizhttps://github.com/triniwiz
mainhttps://github.com/NativeScript/windows/tree/main
fix/napi-wrap-plain-objectshttps://github.com/NativeScript/windows/tree/fix/napi-wrap-plain-objects
Conversation 1 https://github.com/NativeScript/windows/pull/54
Commits 1 https://github.com/NativeScript/windows/pull/54/commits
Checks 1 https://github.com/NativeScript/windows/pull/54/checks
Files changed https://github.com/NativeScript/windows/pull/54/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/54/files
fix(napi): napi_wrap an object without internal fields https://github.com/NativeScript/windows/pull/54/files#top
Show all changes 1 commit https://github.com/NativeScript/windows/pull/54/files
994d1e3 fix(napi): napi_wrap an object without internal fields triniwiz Nov 18, 2026 https://github.com/NativeScript/windows/pull/54/commits/994d1e3ff88b8ce0806e8dbb5b2bc33e51e9ad51
Clear filters https://github.com/NativeScript/windows/pull/54/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/54/files
Please reload this pagehttps://github.com/NativeScript/windows/pull/54/files
v8-api.cpp https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
v8-api.h https://github.com/NativeScript/windows/pull/54/files#diff-7a1bda294afca9c5560df412229d30958361c3f95d98955667440b45ff1174c2
packages/windows-v8/vendor/shim/v8-api.cpphttps://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
View file https://github.com/NativeScript/windows/blob/994d1e3ff88b8ce0806e8dbb5b2bc33e51e9ad51/packages/windows-v8/vendor/shim/v8-api.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/windows/pull/54/{{ revealButtonHref }}
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
https://github.com/NativeScript/windows/pull/54/files#diff-5ec2a075360637be8b0e1c71bc28aa07b0d454c4d96fb0f9c61d7857487608e8
packages/windows-v8/vendor/shim/v8-api.hhttps://github.com/NativeScript/windows/pull/54/files#diff-7a1bda294afca9c5560df412229d30958361c3f95d98955667440b45ff1174c2
View file https://github.com/NativeScript/windows/blob/994d1e3ff88b8ce0806e8dbb5b2bc33e51e9ad51/packages/windows-v8/vendor/shim/v8-api.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/windows/pull/54/{{ revealButtonHref }}
https://github.com/NativeScript/windows/pull/54/files#diff-7a1bda294afca9c5560df412229d30958361c3f95d98955667440b45ff1174c2
https://github.com/NativeScript/windows/pull/54/files#diff-7a1bda294afca9c5560df412229d30958361c3f95d98955667440b45ff1174c2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.