Title: Fix quotes and lastKnownFileType by Fatme · Pull Request #1 · NativeScript/node-xcode · GitHub
Open Graph Title: Fix quotes and lastKnownFileType by Fatme · Pull Request #1 · NativeScript/node-xcode
X Title: Fix quotes and lastKnownFileType by Fatme · Pull Request #1 · NativeScript/node-xcode
Description: Problem1 - Quotes Quotes are added every time when pbxFileReferenceObj function is called. But we need them only when the file contains special characters. If the file doesn't contain special characters and removeResourceFile function is called, the resource was successfully removed from pbxBuildFileSection. But the file reference is not removed from pbxFileReferenceSection. This happens because the reference in pbxproject file doesn't contain quotes but we add the quotes and do incorrect comparison. Problem2 - Unknown lastKnownFileType addResourceFile function sets lastKnownFileType property of file to unknown in PBXFileReference section. This PR fixes the type only .png image is added as resource.
Open Graph Description: Problem1 - Quotes Quotes are added every time when pbxFileReferenceObj function is called. But we need them only when the file contains special characters. If the file doesn't contain special c...
X Description: Problem1 - Quotes Quotes are added every time when pbxFileReferenceObj function is called. But we need them only when the file contains special characters. If the file doesn't contain speci...
Opengraph URL: https://github.com/NativeScript/node-xcode/pull/1
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:594653c1-79cd-4436-277d-fd090d09c60b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 991A:1A456E:991112:CDD342:6A62A1BD |
| html-safe-nonce | c8cc4f99c4b0a4936c113a99f4c1af081ea31def07d7480a8bbbee2a3c96b056 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTFBOjFBNDU2RTo5OTExMTI6Q0REMzQyOjZBNjJBMUJEIiwidmlzaXRvcl9pZCI6Ijg3MzEwNzY5NDcyMzIzMzQyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 675b824f5531826bc310823b915f3b4f48d85646a74575f612c7b1bb4a979809 |
| hovercard-subject-tag | pull_request:38458153 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/node-xcode/pull/1/files |
| twitter:image | https://avatars.githubusercontent.com/u/760518?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/760518?s=400&v=4 |
| og:image:alt | Problem1 - Quotes Quotes are added every time when pbxFileReferenceObj function is called. But we need them only when the file contains special characters. If the file doesn't contain special c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a6443033349a18134b517627f043d4a59a5110337b879810c7229c2c7e28eda0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/node-xcode git https://github.com/NativeScript/node-xcode.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31066824 |
| octolytics-dimension-repository_nwo | NativeScript/node-xcode |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 30308228 |
| octolytics-dimension-repository_parent_nwo | fealebenpae/node-xcode |
| octolytics-dimension-repository_network_root_id | 3278975 |
| octolytics-dimension-repository_network_root_nwo | alunny/node-xcode |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d6c6cacbe32d3ddfd1796fbd1a39b8fb47b87daf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width