René's URL Explorer Experiment


Title: perf: download bundletool on demand instead of vendoring it by edusperoni · Pull Request #6097 · NativeScript/nativescript-cli · GitHub

Open Graph Title: perf: download bundletool on demand instead of vendoring it by edusperoni · Pull Request #6097 · NativeScript/nativescript-cli

X Title: perf: download bundletool on demand instead of vendoring it by edusperoni · Pull Request #6097 · NativeScript/nativescript-cli

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base Tests for the changes are included. No tracking issue — happy to open one if preferred. What is the current behavior? vendor/aab-tool/bundletool.jar is checked into the repo and shipped with every install. At 32,515,387 bytes it is the single largest thing in the package — roughly nine tenths of the published tarball. It earns none of that. AndroidBundleToolService is only reached from AndroidApplicationManager.installApplication() when the artifact being installed is an .aab, i.e. ns run/ns deploy against a bundle. Producing the .aab is gradle's job and never touches the jar, so ns build android --aab doesn't need it either. Every user pays 32MB of download and disk for a path most of them never take. What is the new behavior? bundletool is resolved lazily, the first time it is actually invoked, and cached per-user: NS_BUNDLETOOL_PATH, if set, is used as-is (fails loudly if the file is missing) — the escape hatch for offline, air-gapped or mirrored setups. Otherwise /bundletool/bundletool-all-.jar, reused when its sha256 matches the pinned value. Otherwise downloaded from the pinned GitHub release, verified against the pinned sha256, and moved into place with an atomic rename, all under $lockService so two concurrent CLIs neither race nor fetch the same 32MB twice. A tampered or partial cache entry is discarded and re-fetched. The version lives in the filename, so bumping BUNDLETOOL_VERSION simply fetches the new jar — no staleness logic, and two CLI versions can coexist on one machine. A failed download names the URL and points at NS_BUNDLETOOL_PATH. The download reports progress through the existing $terminalSpinnerService, once, on first use. Supporting changes httpRequest gained a pipeTo option. It previously ran every response through JSON.stringify, which buffers and corrupts a binary payload — streaming was a prerequisite, not a nicety. The same axios call now also passes httpsAgent. axios selects the agent by protocol, so with httpAgent alone every https:// request was silently bypassing the configured proxy tunnel. That is a pre-existing bug, but the download depends on the fix, so it is included here. Size Measured with npm pack --dry-run ./dist on a --release build, before and after: packed unpacked before 34.0 MB 42.9 MB after 3.4 MB 10.3 MB A jar is already-compressed, so the saving survives gzip almost intact: -90% on the published tarball. vendor/ still ships — vendor/gradle-plugin (148KB) remains vendored and unaffected. Trade-off The first .aab install on a machine now needs network access. NS_BUNDLETOOL_PATH covers the cases where that is not acceptable. Given the jar is untouched by every other command, taxing every install to pre-stage it was the worse default. Verification Full suite green: 1523 passing, 38 skipped, 102 files. 9 new unit tests for the resolution logic: env-var override and its failure mode, cache hit, resolve-once memoisation, download + verify + atomic rename, re-check under the lock when another process won the race, checksum mismatch, download failure, and eviction of a tampered cache entry. The download path itself was exercised against the real GitHub release, outside the stubs: 32,515,387 bytes retrieved, redirect to objects.githubusercontent.com followed transparently, progress events delivered with a total, body left undefined on the pipe path, and the resulting sha256 equal to the pinned constant — which is also byte-identical to the jar this PR deletes. ns doctor needs no changes; it has never had any knowledge of bundletool or vendor/. Summary by CodeRabbit New Features Android app package generation now automatically downloads and caches the required Bundletool version. Added integrity checks to validate downloaded tools and safely recover from incomplete or corrupted downloads. Supports using a locally provided Bundletool JAR through an environment variable. Improved download progress reporting and prevents duplicate downloads during concurrent operations. Bug Fixes Improved streaming download handling and proxy authentication error messages. Ensured invalid cached tools are removed and replaced automatically.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/6097

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c1503cb9-c341-bf88-1e8f-a13b090e4972
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBBE:136CDA:B5139D:F07F4D:6B01C24D
html-safe-nonce3a8e426668d7b58c475982e7f82f34fb5160dc8f2feff6f52614f88d8f231a44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkJFOjEzNkNEQTpCNTEzOUQ6RjA3RjREOjZCMDFDMjREIiwidmlzaXRvcl9pZCI6IjY4MzE1ODA1MTQ3MzA3NTQ2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac99ed38f18737b96221908b3809d0d67c04a6f5386c35fb57bf3b0a09e3ddbaf3
hovercard-subject-tagpull_request:4162782169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/6097/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/6097/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6097%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6097%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6097/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6097/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6097/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
mainhttps://github.com/NativeScript/nativescript-cli/tree/main
feat/lazy-bundletoolhttps://github.com/NativeScript/nativescript-cli/tree/feat/lazy-bundletool
Conversation 4 https://github.com/NativeScript/nativescript-cli/pull/6097
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/6097/commits
Checks 11 https://github.com/NativeScript/nativescript-cli/pull/6097/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/6097/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
perf: download bundletool on demand instead of vendoring it https://github.com/NativeScript/nativescript-cli/pull/6097/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/6097/files
bae97e9 perf: download bundletool on demand instead of vendoring it edusperoni Jul 29, 2026 https://github.com/NativeScript/nativescript-cli/pull/6097/commits/bae97e92c8646b29fb001069fef18b03ee422996
Clear filters https://github.com/NativeScript/nativescript-cli/pull/6097/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
http-client.ts https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
constants.ts https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-561ab956a0b904914573a9544f92493c5493b6e14d30372365bcdd9c5c7f6e59
android-bundle-tool-service.ts https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-e521b1a0d869bd612bc2fd8507a813f30c040cf24197c6601cba49ce21c9a23e
copy-assets.js https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-c09ab817828733799eca92ef5549fb39e30d30561fe53cdbd6c244795a251c62
android-bundle-tool-service.ts https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-c0e28e4af19a8fe8e77f97851ced21b2071e02d65b74bf11270a455fad01b2fb
LICENSE https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-10fa4ff720119b24b93aa008ea71752ebcaafea38285ce0aef96836c83126660
README.txt https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-20241ad6ef2f93b308d8e8e1491d74e2d4cef6a98d5e927bbf81da8e1cc07cbc
bundletool.jar https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-18d90209ab21616ec5331b0ec6e77d436f50e5bfc35d966ce173cd170fc9e6a6
lib/common/http-client.tshttps://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
View file https://github.com/NativeScript/nativescript-cli/blob/bae97e92c8646b29fb001069fef18b03ee422996/lib/common/http-client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6097/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
coderabbitaihttps://github.com/apps/coderabbitai
Jul 29, 2026https://github.com/NativeScript/nativescript-cli/pull/6097/files#r3676726149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-6863fb772004d87d51d27aa354eae60b2934b9dc1fb0edc4edddb8d829faf65c
lib/constants.tshttps://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-561ab956a0b904914573a9544f92493c5493b6e14d30372365bcdd9c5c7f6e59
View file https://github.com/NativeScript/nativescript-cli/blob/bae97e92c8646b29fb001069fef18b03ee422996/lib/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6097/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-561ab956a0b904914573a9544f92493c5493b6e14d30372365bcdd9c5c7f6e59
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-561ab956a0b904914573a9544f92493c5493b6e14d30372365bcdd9c5c7f6e59
lib/services/android/android-bundle-tool-service.tshttps://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-e521b1a0d869bd612bc2fd8507a813f30c040cf24197c6601cba49ce21c9a23e
View file https://github.com/NativeScript/nativescript-cli/blob/bae97e92c8646b29fb001069fef18b03ee422996/lib/services/android/android-bundle-tool-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6097/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-e521b1a0d869bd612bc2fd8507a813f30c040cf24197c6601cba49ce21c9a23e
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-e521b1a0d869bd612bc2fd8507a813f30c040cf24197c6601cba49ce21c9a23e
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-e521b1a0d869bd612bc2fd8507a813f30c040cf24197c6601cba49ce21c9a23e
coderabbitaihttps://github.com/apps/coderabbitai
Jul 29, 2026https://github.com/NativeScript/nativescript-cli/pull/6097/files#r3676726185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
scripts/copy-assets.jshttps://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-c09ab817828733799eca92ef5549fb39e30d30561fe53cdbd6c244795a251c62
View file https://github.com/NativeScript/nativescript-cli/blob/bae97e92c8646b29fb001069fef18b03ee422996/scripts/copy-assets.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6097/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-c09ab817828733799eca92ef5549fb39e30d30561fe53cdbd6c244795a251c62
https://github.com/NativeScript/nativescript-cli/pull/6097/files#diff-c09ab817828733799eca92ef5549fb39e30d30561fe53cdbd6c244795a251c62
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6097/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.