Title: ci: test on macOS and Node 24 by edusperoni · Pull Request #6096 · NativeScript/nativescript-cli · GitHub
Open Graph Title: ci: test on macOS and Node 24 by edusperoni · Pull Request #6096 · NativeScript/nativescript-cli
X Title: ci: test on macOS and Node 24 by edusperoni · Pull Request #6096 · NativeScript/nativescript-cli
Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are passing. Tests for the changes are included. (this PR is CI configuration) What is the current behavior? ubuntu-latest with Node 20.x and 22.x — four gaps in one line. No macOS. Seven test files contain darwin-gated paths that have therefore never executed in CI: ios-project-service, ios-device-debug-service, debug-controller, xcode-select-service, ios-simulator-discovery, host-info, devices-service. On a CLI whose primary job is building iOS apps, the iOS-specific logic is the part with no coverage. This is also the source of the count difference between local (1514) and CI (1501) — 13 tests that simply never run. No Node 24. Node 24 is the active LTS. Node 20 reached end of life in April 2026 and Node 22 is in maintenance — so the matrix tests a dead runtime and the maintenance one, while the release publishes from 22 and most users are on 24. What is the new behavior? runner Node ubuntu-latest 20.x, 22.x, 24.x macos-latest 24.x Four jobs rather than a 3×2 cross-product. macOS runners are free on a public repo, but queue time is not, and one darwin leg is enough to cover platform-gated code — a second Node version there would re-run the same suite for very little. Node 24 is added rather than 20 dropped, since engines still declares >=20.0.0. Worth noting separately that permitting an end-of-life runtime is its own decision; this PR only makes the matrix match what is declared. harden-runner is now conditional on runner.os == 'Linux' — it only supports the Ubuntu runners. Verification Node 24 was validated locally before proposing it, rather than pushing and hoping: full suite on Node 24.18.0: 1514 passing, 38 skipped, 101 files — identical to Node 22 npm run build.release succeeds on Node 24, and the built CLI reports its version and renders help The macOS leg is the one that cannot be pre-validated from a single machine — the point of adding it is to execute code no CI job has run before, so it is possible those 13 tests surface problems. That is the intent, and worth watching on the first run. Summary by CodeRabbit Tests Expanded automated test coverage across Ubuntu and macOS environments. Added testing for Node.js 24.x alongside existing Node.js 20.x and 22.x configurations. Enabled platform-specific test coverage for iOS-related suites on macOS.
Open Graph Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ...
X Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ...
Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/6096
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4d737f2d-bd1d-5894-ad42-bae8aff4c889 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D06E:1D20B7:26375F5:3076E9F:6B01C674 |
| html-safe-nonce | 5a95b1828d849467976488ffed8ba3734c169e8b2a205d17228ac80ae3c38075 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDZFOjFEMjBCNzoyNjM3NUY1OjMwNzZFOUY6NkIwMUM2NzQiLCJ2aXNpdG9yX2lkIjoiNjg3MTA3MDY1NTk1ODMzNzE0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0ee3a9d4ce5dae6e233ddb59a767d51d2ad43128edb487975fb5b2dac480bf81 |
| hovercard-subject-tag | pull_request:4161032653 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/6096/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 21347346 |
| octolytics-dimension-repository_nwo | NativeScript/nativescript-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21347346 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/nativescript-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width